Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811408/?format=api
{ "id": 811408, "url": "http://patchwork.ozlabs.org/api/patches/811408/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908091700.14867-2-famz@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170908091700.14867-2-famz@redhat.com>", "list_archive_url": null, "date": "2017-09-08T09:16:54", "name": "[RFC,1/7] Makefile: Rename TARGET_DIRS to TARGET_LIST", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "187d1ba4f420e6554be5c05e829e48e6181d954a", "submitter": { "id": 24872, "url": "http://patchwork.ozlabs.org/api/people/24872/?format=api", "name": "Fam Zheng", "email": "famz@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170908091700.14867-2-famz@redhat.com/mbox/", "series": [ { "id": 2149, "url": "http://patchwork.ozlabs.org/api/series/2149/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2149", "date": "2017-09-08T09:16:53", "name": "Proof of concept to power up \"make test\" with docker", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2149/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811408/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811408/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpWvS2Ckgz9sCZ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Sep 2017 19:18:12 +1000 (AEST)", "from localhost ([::1]:44036 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dqFQQ-00063s-7W\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 05:18:10 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:52471)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <famz@redhat.com>) id 1dqFPc-0005yW-1H\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:17:26 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <famz@redhat.com>) id 1dqFPX-0000NQ-4z\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:17:20 -0400", "from mx1.redhat.com ([209.132.183.28]:57032)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <famz@redhat.com>) id 1dqFPW-0000Mm-Sy\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:17:15 -0400", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 01CEA81DE7;\n\tFri, 8 Sep 2017 09:17:14 +0000 (UTC)", "from lemon.redhat.com (ovpn-12-98.pek2.redhat.com [10.72.12.98])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 1798460241;\n\tFri, 8 Sep 2017 09:17:09 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 01CEA81DE7", "From": "Fam Zheng <famz@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Fri, 8 Sep 2017 17:16:54 +0800", "Message-Id": "<20170908091700.14867-2-famz@redhat.com>", "In-Reply-To": "<20170908091700.14867-1-famz@redhat.com>", "References": "<20170908091700.14867-1-famz@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tFri, 08 Sep 2017 09:17:14 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH RFC 1/7] Makefile: Rename TARGET_DIRS to\n\tTARGET_LIST", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "peter.maydell@linaro.org, thuth@redhat.com, Fam Zheng <famz@redhat.com>, \n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>,\n\tprogrammingkidx@gmail.com, crosa@redhat.com, pbonzini@redhat.com, \n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>, rth@twiddle.net", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "To be more accurate on its purpose and make code that looks for a certain\ntarget out of this variable more readable.\n\nSigned-off-by: Fam Zheng <famz@redhat.com>\n---\n Makefile | 20 ++++++++++----------\n configure | 2 +-\n scripts/create_config | 2 +-\n tests/Makefile.include | 2 +-\n 4 files changed, 13 insertions(+), 13 deletions(-)", "diff": "diff --git a/Makefile b/Makefile\nindex 337a1f6f9b..c1e35b1fd0 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -24,8 +24,8 @@ seems to have been used for an in-tree build. You can fix this by running \\\n endif\n endif\n \n-CONFIG_SOFTMMU := $(if $(filter %-softmmu,$(TARGET_DIRS)),y)\n-CONFIG_USER_ONLY := $(if $(filter %-user,$(TARGET_DIRS)),y)\n+CONFIG_SOFTMMU := $(if $(filter %-softmmu,$(TARGET_LIST)),y)\n+CONFIG_USER_ONLY := $(if $(filter %-user,$(TARGET_LIST)),y)\n CONFIG_XEN := $(CONFIG_XEN_BACKEND)\n CONFIG_ALL=y\n -include config-all-devices.mak\n@@ -217,8 +217,8 @@ DOCS=\n endif\n \n SUBDIR_MAKEFLAGS=$(if $(V),,--no-print-directory) BUILD_DIR=$(BUILD_DIR)\n-SUBDIR_DEVICES_MAK=$(patsubst %, %/config-devices.mak, $(TARGET_DIRS))\n-SUBDIR_DEVICES_MAK_DEP=$(patsubst %, %-config-devices.mak.d, $(TARGET_DIRS))\n+SUBDIR_DEVICES_MAK=$(patsubst %, %/config-devices.mak, $(TARGET_LIST))\n+SUBDIR_DEVICES_MAK_DEP=$(patsubst %, %-config-devices.mak.d, $(TARGET_LIST))\n \n ifeq ($(SUBDIR_DEVICES_MAK),)\n config-all-devices.mak:\n@@ -314,7 +314,7 @@ config-host.h-timestamp: config-host.mak\n qemu-options.def: $(SRC_PATH)/qemu-options.hx $(SRC_PATH)/scripts/hxtool\n \t$(call quiet-command,sh $(SRC_PATH)/scripts/hxtool -h < $< > $@,\"GEN\",\"$@\")\n \n-SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS))\n+SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_LIST))\n SOFTMMU_SUBDIR_RULES=$(filter %-softmmu,$(SUBDIR_RULES))\n \n $(SOFTMMU_SUBDIR_RULES): $(block-obj-y)\n@@ -352,7 +352,7 @@ ROMSUBDIR_RULES=$(patsubst %,romsubdir-%, $(ROMS))\n romsubdir-%:\n \t$(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C pc-bios/$* V=\"$(V)\" TARGET_DIR=\"$*/\" CFLAGS=\"$(filter -O% -g%,$(CFLAGS))\",)\n \n-ALL_SUBDIRS=$(TARGET_DIRS) $(patsubst %,pc-bios/%, $(ROMS))\n+ALL_SUBDIRS=$(TARGET_LIST) $(patsubst %,pc-bios/%, $(ROMS))\n \n recurse-all: $(SUBDIR_RULES) $(ROMSUBDIR_RULES)\n \n@@ -537,7 +537,7 @@ distclean: clean\n \trm -f docs/interop/qemu-qmp-ref.txt docs/interop/qemu-ga-ref.txt\n \trm -f docs/interop/qemu-qmp-ref.pdf docs/interop/qemu-ga-ref.pdf\n \trm -f docs/interop/qemu-qmp-ref.html docs/interop/qemu-ga-ref.html\n-\tfor d in $(TARGET_DIRS); do \\\n+\tfor d in $(TARGET_LIST); do \\\n \trm -rf $$d || exit 1 ; \\\n done\n \trm -Rf .sdk\n@@ -638,7 +638,7 @@ endif\n \t\t$(INSTALL_DATA) $(SRC_PATH)/pc-bios/keymaps/$$x \"$(DESTDIR)$(qemu_datadir)/keymaps\"; \\\n \tdone\n \t$(INSTALL_DATA) $(BUILD_DIR)/trace-events-all \"$(DESTDIR)$(qemu_datadir)/trace-events-all\"\n-\tfor d in $(TARGET_DIRS); do \\\n+\tfor d in $(TARGET_LIST); do \\\n \t$(MAKE) $(SUBDIR_MAKEFLAGS) TARGET_DIR=$$d/ -C $$d $@ || exit 1 ; \\\n done\n \n@@ -832,9 +832,9 @@ help:\n \t@echo ' ctags/TAGS - Generate tags file for editors'\n \t@echo ' cscope - Generate cscope index'\n \t@echo ''\n-\t@$(if $(TARGET_DIRS), \\\n+\t@$(if $(TARGET_LIST), \\\n \t\techo 'Architecture specific targets:'; \\\n-\t\t$(foreach t, $(TARGET_DIRS), \\\n+\t\t$(foreach t, $(TARGET_LIST), \\\n \t\tprintf \" %-30s - Build for %s\\\\n\" $(patsubst %,subdir-%,$(t)) $(t);) \\\n \t\techo '')\n \t@echo 'Cleaning targets:'\ndiff --git a/configure b/configure\nindex a541aadebc..36a2fa1f23 100755\n--- a/configure\n+++ b/configure\n@@ -5587,7 +5587,7 @@ qemu_version=$(head $source_path/VERSION)\n echo \"VERSION=$qemu_version\" >>$config_host_mak\n echo \"PKGVERSION=$pkgversion\" >>$config_host_mak\n echo \"SRC_PATH=$source_path\" >> $config_host_mak\n-echo \"TARGET_DIRS=$target_list\" >> $config_host_mak\n+echo \"TARGET_LIST=$target_list\" >> $config_host_mak\n if [ \"$docs\" = \"yes\" ] ; then\n echo \"BUILD_DOCS=yes\" >> $config_host_mak\n fi\ndiff --git a/scripts/create_config b/scripts/create_config\nindex e6929dd61e..3612f8154f 100755\n--- a/scripts/create_config\n+++ b/scripts/create_config\n@@ -107,7 +107,7 @@ case $line in\n target_name=${line#*=}\n echo \"#define TARGET_NAME \\\"$target_name\\\"\"\n ;;\n- TARGET_DIRS=*)\n+ TARGET_LIST=*)\n # do nothing\n ;;\n TARGET_*=y) # configuration\ndiff --git a/tests/Makefile.include b/tests/Makefile.include\nindex fae5715e9c..debaf845db 100644\n--- a/tests/Makefile.include\n+++ b/tests/Makefile.include\n@@ -820,7 +820,7 @@ endif\n \n # QTest rules\n \n-TARGETS=$(patsubst %-softmmu,%, $(filter %-softmmu,$(TARGET_DIRS)))\n+TARGETS=$(patsubst %-softmmu,%, $(filter %-softmmu,$(TARGET_LIST)))\n ifeq ($(CONFIG_POSIX),y)\n QTEST_TARGETS = $(TARGETS)\n check-qtest-y=$(foreach TARGET,$(TARGETS), $(check-qtest-$(TARGET)-y))\n", "prefixes": [ "RFC", "1/7" ] }