Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811400/?format=api
{ "id": 811400, "url": "http://patchwork.ozlabs.org/api/patches/811400/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20170908091322.GA88791@adacore.com/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170908091322.GA88791@adacore.com>", "list_archive_url": null, "date": "2017-09-08T09:13:22", "name": "[Ada] Do not generate .ali files for subunits", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6a9c6234ce1435633204b5fe4947f61ff974c07d", "submitter": { "id": 4418, "url": "http://patchwork.ozlabs.org/api/people/4418/?format=api", "name": "Arnaud Charlet", "email": "charlet@adacore.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20170908091322.GA88791@adacore.com/mbox/", "series": [ { "id": 2145, "url": "http://patchwork.ozlabs.org/api/series/2145/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=2145", "date": "2017-09-08T09:13:22", "name": "[Ada] Do not generate .ali files for subunits", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2145/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811400/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811400/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-return-461705-incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "mailing list gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461705-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"nHUbpgXx\"; dkim-atps=neutral", "sourceware.org; auth=none" ], "Received": [ "from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpWpJ4sWRz9s82\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Sep 2017 19:13:44 +1000 (AEST)", "(qmail 45792 invoked by alias); 8 Sep 2017 09:13:29 -0000", "(qmail 45720 invoked by uid 89); 8 Sep 2017 09:13:29 -0000", "from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tFri, 08 Sep 2017 09:13:24 +0000", "from localhost (localhost.localdomain [127.0.0.1])\tby\n\tfiltered-rock.gnat.com (Postfix) with ESMTP id 0EEFD5625A;\n\tFri, 8 Sep 2017 05:13:23 -0400 (EDT)", "from rock.gnat.com ([127.0.0.1])\tby localhost (rock.gnat.com\n\t[127.0.0.1]) (amavisd-new, port 10024)\twith LMTP id\n\tgcBUJxXK3RL4; Fri, 8 Sep 2017 05:13:22 -0400 (EDT)", "from tron.gnat.com (tron.gnat.com\n\t[IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294])\tby rock.gnat.com\n\t(Postfix) with ESMTP id F177156126;\n\tFri, 8 Sep 2017 05:13:22 -0400 (EDT)", "by tron.gnat.com (Postfix, from userid 4192)\tid F0A44505;\n\tFri, 8 Sep 2017 05:13:22 -0400 (EDT)" ], "DomainKey-Signature": "a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:mime-version:content-type; q=dns;\n\ts=default; b=yPEfuUyRIlynOc/FdWTeZHVHMW6mUmunzGKOoeQML//mT9LyPd\n\tHJ8X6XCOSdFcaIQu0U3vu5CWjhyTFBsYyof0fbS3tMTwz/GTkRtjjr9v9BZbeBOT\n\txrcTL1P5IqBGLKC3FMv7WnsyUDO1Xg+JUHiJ4G6Dw4OuD0mwBHaCiBtJw=", "DKIM-Signature": "v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:mime-version:content-type; s=\n\tdefault; bh=WX/Opp3mpbFaJNtb3UTLM3LxHRo=; b=nHUbpgXxGAUEnvkzVVrq\n\tBfgwQaGGjjNkLjROsLR7K2vpcePi8ozUsR5OiwU4cgJ8gEmqELi5zHV6lvDIQOWi\n\tnyKaDgQHuNGf6ii4LFOMz6Sc87uuaS++tbr3oeoJmxX1n95kj0VRK4V4y62a+uap\n\tFzLgs71Tl8katMCW/Z3cdXU=", "Mailing-List": "contact gcc-patches-help@gcc.gnu.org; run by ezmlm", "Precedence": "bulk", "List-Id": "<gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org>", "List-Archive": "<http://gcc.gnu.org/ml/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-help@gcc.gnu.org>", "Sender": "gcc-patches-owner@gcc.gnu.org", "X-Virus-Found": "No", "X-Spam-SWARE-Status": "No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_2,\n\tGIT_PATCH_3, RCVD_IN_DNSWL_NONE,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1324", "X-HELO": "rock.gnat.com", "Date": "Fri, 8 Sep 2017 05:13:22 -0400", "From": "Arnaud Charlet <charlet@adacore.com>", "To": "gcc-patches@gcc.gnu.org", "Cc": "Bob Duff <duff@adacore.com>", "Subject": "[Ada] Do not generate .ali files for subunits", "Message-ID": "<20170908091322.GA88791@adacore.com>", "MIME-Version": "1.0", "Content-Type": "multipart/mixed; boundary=\"C7zPtVaVf+AK4Oqc\"", "Content-Disposition": "inline", "User-Agent": "Mutt/1.5.23 (2014-03-12)" }, "content": "This patch fixes a bug in which the compiler creates .ali files when a\nsubunit is compiled. Given the following code:\n\npackage P is\n procedure F;\nend P;\n\npackage body P is\n procedure F is separate;\nend P;\n\nseparate (P)\nprocedure F is\nbegin\n null;\nend F;\n\nThe command:\n\ngcc -c p-f.adb\n\nshould generate an error:\n\ncannot generate code for file p-f.adb (subunit)\n\nand p-f.ali should not be created.\n\nTested on x86_64-pc-linux-gnu, committed on trunk\n\n2017-09-08 Bob Duff <duff@adacore.com>\n\n\t* gnat1drv.adb (Gnat1drv): Do not set the Force_ALI_Tree_File flag in\n\tthe subunit case. It's still OK to set it in the \"missing subunits\"\n\tcase, because that won't cause the obsolete .ali files that cause\n\tconfusion.", "diff": "Index: gnat1drv.adb\n===================================================================\n--- gnat1drv.adb\t(revision 251863)\n+++ gnat1drv.adb\t(working copy)\n@@ -1353,10 +1353,10 @@\n Write_Str (\" (subunit)\");\n Write_Eol;\n \n- -- Force generation of ALI file, for backward compatibility\n+ -- Do not generate an ALI file in this case, because it would\n+ -- become obsolete when the parent is compiled, and thus\n+ -- confuse tools such as gnatfind.\n \n- Opt.Force_ALI_Tree_File := True;\n-\n elsif Main_Unit_Kind = N_Subprogram_Declaration then\n Write_Str (\" (subprogram spec)\");\n Write_Eol;\n", "prefixes": [ "Ada" ] }