Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811229/?format=api
{ "id": 811229, "url": "http://patchwork.ozlabs.org/api/patches/811229/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/patch/20170907224219.12483-30-albert.aribaud@3adev.fr/", "project": { "id": 41, "url": "http://patchwork.ozlabs.org/api/projects/41/?format=api", "name": "GNU C Library", "link_name": "glibc", "list_id": "libc-alpha.sourceware.org", "list_email": "libc-alpha@sourceware.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170907224219.12483-30-albert.aribaud@3adev.fr>", "list_archive_url": null, "date": "2017-09-07T22:41:56", "name": "[RFC,29/52] Y2038: add function __stime_t64", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e1ba5d9d15b6638e7d11222940508d53ccb3dcaf", "submitter": { "id": 65557, "url": "http://patchwork.ozlabs.org/api/people/65557/?format=api", "name": "Albert ARIBAUD (3ADEV)", "email": "albert.aribaud@3adev.fr" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/glibc/patch/20170907224219.12483-30-albert.aribaud@3adev.fr/mbox/", "series": [ { "id": 2074, "url": "http://patchwork.ozlabs.org/api/series/2074/?format=api", "web_url": "http://patchwork.ozlabs.org/project/glibc/list/?series=2074", "date": "2017-09-07T22:41:27", "name": "Make GLIBC Y2038-proof", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2074/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811229/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811229/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<libc-alpha-return-84347-incoming=patchwork.ozlabs.org@sourceware.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "mailing list libc-alpha@sourceware.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84347-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"b0YgKKAH\"; dkim-atps=neutral", "sourceware.org; auth=none" ], "Received": [ "from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpFwH12Hdz9sDB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Sep 2017 08:47:58 +1000 (AEST)", "(qmail 88923 invoked by alias); 7 Sep 2017 22:44:33 -0000", "(qmail 88758 invoked by uid 89); 7 Sep 2017 22:44:33 -0000" ], "DomainKey-Signature": "a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:date:message-id:in-reply-to\n\t:references; q=dns; s=default; b=Mu09fvM5bWYFnvv9x9w8p8DUCTosErM\n\tXUzykJRGkWxpNP7dd8nR4ppZl6qB1MzF3nvMJZ34TRXV3H+2k9cZnNdO6hdYmi4t\n\t63CqU+Dhh3UA0BHsylKQ6JY722jySrkcZXxwZzJawHsIW+j70HAqm8UdUdUKMj0/\n\tTVQ0XoMYp3i8=", "DKIM-Signature": "v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:from:to:cc:subject:date:message-id:in-reply-to\n\t:references; s=default; bh=HVOvmjUt/I1tb5uThdaWXUf4+Yc=; b=b0YgK\n\tKAHXb59Yl3nJ1AZKjUYiFAnWHjasg97WlO1bthW1/6ITwomagC60GeW0eiUehaYs\n\tMAPm/jDN0NXVWeEKlQq8fPwDRZkEXHSGRZSxMCO68fz7vapSCk0DFxra//rw92Fw\n\tHZVpg1IXeczCUBqnj3JAuyrh3lOnISiyH+vNXI=", "Mailing-List": "contact libc-alpha-help@sourceware.org; run by ezmlm", "Precedence": "bulk", "List-Id": "<libc-alpha.sourceware.org>", "List-Unsubscribe": "<mailto:libc-alpha-unsubscribe-incoming=patchwork.ozlabs.org@sourceware.org>", "List-Subscribe": "<mailto:libc-alpha-subscribe@sourceware.org>", "List-Archive": "<http://sourceware.org/ml/libc-alpha/>", "List-Post": "<mailto:libc-alpha@sourceware.org>", "List-Help": "<mailto:libc-alpha-help@sourceware.org>,\n\t<http://sourceware.org/ml/#faqs>", "Sender": "libc-alpha-owner@sourceware.org", "X-Virus-Found": "No", "X-Spam-SWARE-Status": "No, score=-26.6 required=5.0 tests=BAYES_00, GIT_PATCH_0,\n\tGIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,\n\tKAM_LAZY_DOMAIN_SECURITY,\n\tRCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=", "X-HELO": "smtp6-g21.free.fr", "From": "\"Albert ARIBAUD (3ADEV)\" <albert.aribaud@3adev.fr>", "To": "libc-alpha@sourceware.org", "Cc": "\"Albert ARIBAUD (3ADEV)\" <albert.aribaud@3adev.fr>", "Subject": "[RFC PATCH 29/52] Y2038: add function __stime_t64", "Date": "Fri, 8 Sep 2017 00:41:56 +0200", "Message-Id": "<20170907224219.12483-30-albert.aribaud@3adev.fr>", "In-Reply-To": "<20170907224219.12483-29-albert.aribaud@3adev.fr>", "References": "<20170907224219.12483-1-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-2-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-3-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-4-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-5-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-6-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-7-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-8-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-9-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-10-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-11-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-12-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-13-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-14-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-15-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-16-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-17-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-18-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-19-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-20-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-21-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-22-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-23-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-24-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-25-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-26-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-27-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-28-albert.aribaud@3adev.fr>\n\t<20170907224219.12483-29-albert.aribaud@3adev.fr>" }, "content": "These implementations use only 32-bit time kernel syscalls.\n\nTherefore, stime() will always set errno to EOVERFLOW and return -1 for dates beyond Y2038.\n\nSigned-off-by: Albert ARIBAUD (3ADEV) <albert.aribaud@3adev.fr>\n---\n sysdeps/unix/sysv/linux/stime.c | 70 +++++++++++++++++++++++++++++++++++++++++\n time/Versions | 1 +\n time/stime.c | 17 ++++++++++\n 3 files changed, 88 insertions(+)\n create mode 100644 sysdeps/unix/sysv/linux/stime.c", "diff": "diff --git a/sysdeps/unix/sysv/linux/stime.c b/sysdeps/unix/sysv/linux/stime.c\nnew file mode 100644\nindex 0000000000..177c9334ef\n--- /dev/null\n+++ b/sysdeps/unix/sysv/linux/stime.c\n@@ -0,0 +1,70 @@\n+/* Copyright (C) 1992-2017 Free Software Foundation, Inc.\n+ This file is part of the GNU C Library.\n+\n+ The GNU C Library is free software; you can redistribute it and/or\n+ modify it under the terms of the GNU Lesser General Public\n+ License as published by the Free Software Foundation; either\n+ version 2.1 of the License, or (at your option) any later version.\n+\n+ The GNU C Library is distributed in the hope that it will be useful,\n+ but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU\n+ Lesser General Public License for more details.\n+\n+ You should have received a copy of the GNU Lesser General Public\n+ License along with the GNU C Library; if not, see\n+ <http://www.gnu.org/licenses/>. */\n+\n+#include <errno.h>\n+#include <stddef.h>\t\t/* For NULL. */\n+#include <sys/time.h>\n+#include <time.h>\n+\n+/* Set the system clock to *WHEN. */\n+\n+int\n+stime (const time_t *when)\n+{\n+ struct timeval tv;\n+\n+ if (when == NULL)\n+ {\n+ __set_errno (EINVAL);\n+ return -1;\n+ }\n+\n+ tv.tv_sec = *when;\n+ tv.tv_usec = 0;\n+ return __settimeofday (&tv, (struct timezone *) 0);\n+}\n+\n+/* 64-bit time version */\n+\n+extern int __y2038_linux_support;\n+\n+int\n+__stime_t64 (const __time64_t *when)\n+{\n+ struct timeval tv32;\n+\n+ if (when == NULL)\n+ {\n+ __set_errno (EINVAL);\n+ return -1;\n+ }\n+\n+ if (__y2038_linux_support)\n+ {\n+ /* TODO: implement 64-bit-time syscall case */\n+ }\n+\n+ if (*when > INT_MAX)\n+ {\n+ __set_errno (EOVERFLOW);\n+ return -1;\n+ }\n+\n+ tv32.tv_sec = *when;\n+ tv32.tv_usec = 0;\n+ return __settimeofday (&tv32, (struct timezone *) 0);\n+}\ndiff --git a/time/Versions b/time/Versions\nindex 02dc8d6146..3dca51abcb 100644\n--- a/time/Versions\n+++ b/time/Versions\n@@ -72,5 +72,6 @@ libc {\n GLIBC_Y2038 {\n __timespec_get64;\n __time_t64;\n+ __stime_t64;\n }\n }\ndiff --git a/time/stime.c b/time/stime.c\nindex 723eedacf1..c1c7c4c9b5 100644\n--- a/time/stime.c\n+++ b/time/stime.c\n@@ -35,3 +35,20 @@ stime (const time_t *when)\n }\n \n stub_warning (stime)\n+\n+/* 64-bit time version */\n+\n+int\n+__stime_t64 (const __time64_t *when)\n+{\n+ if (when == NULL)\n+ {\n+ __set_errno (EINVAL);\n+ return -1;\n+ }\n+\n+ __set_errno (ENOSYS);\n+ return -1;\n+}\n+\n+stub_warning (__stime_t64)\n", "prefixes": [ "RFC", "29/52" ] }