Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811154/?format=api
{ "id": 811154, "url": "http://patchwork.ozlabs.org/api/patches/811154/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170907201335.13956-16-david@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170907201335.13956-16-david@redhat.com>", "list_archive_url": null, "date": "2017-09-07T20:13:29", "name": "[v3,15/21] s390x: print CPU definitions in sorted order", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "953eaea749cf65bb03b44ca935aea412a005888c", "submitter": { "id": 70402, "url": "http://patchwork.ozlabs.org/api/people/70402/?format=api", "name": "David Hildenbrand", "email": "david@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170907201335.13956-16-david@redhat.com/mbox/", "series": [ { "id": 2053, "url": "http://patchwork.ozlabs.org/api/series/2053/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2053", "date": "2017-09-07T20:13:14", "name": "s390x cleanups and CPU hotplug via device_add", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/2053/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811154/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811154/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpBm12XNwz9sBW\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Sep 2017 06:25:34 +1000 (AEST)", "from localhost ([::1]:42144 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dq3Mh-0005RV-Mk\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 16:25:31 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:39097)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dq3C4-0004Th-Jg\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 16:14:37 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dq3Bz-0002OM-MT\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 16:14:32 -0400", "from mx1.redhat.com ([209.132.183.28]:3686)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <david@redhat.com>) id 1dq3Bz-0002Nz-E0\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 16:14:27 -0400", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8C8E8356EA;\n\tThu, 7 Sep 2017 20:14:26 +0000 (UTC)", "from t460s.redhat.com (ovpn-116-60.ams2.redhat.com [10.36.116.60])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 653FE68D48;\n\tThu, 7 Sep 2017 20:14:24 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 8C8E8356EA", "From": "David Hildenbrand <david@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Thu, 7 Sep 2017 22:13:29 +0200", "Message-Id": "<20170907201335.13956-16-david@redhat.com>", "In-Reply-To": "<20170907201335.13956-1-david@redhat.com>", "References": "<20170907201335.13956-1-david@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tThu, 07 Sep 2017 20:14:26 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v3 15/21] s390x: print CPU definitions in\n\tsorted order", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Matthew Rosato <mjrosato@linux.vnet.ibm.com>, thuth@redhat.com,\n\tEduardo Habkost <ehabkost@redhat.com>, david@redhat.com,\n\tcohuck@redhat.com, Richard Henderson <richard.henderson@linaro.org>,\n\tAlexander Graf <agraf@suse.de>, borntraeger@de.ibm.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Other architectures provide nicely sorted lists, let's do it similarly on\ns390x.\n\nWhile at it, clean up the code we have to touch either way.\n\nSigned-off-by: David Hildenbrand <david@redhat.com>\n---\n target/s390x/cpu_models.c | 56 ++++++++++++++++++++++++++++++++++-------------\n 1 file changed, 41 insertions(+), 15 deletions(-)", "diff": "diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c\nindex 8e20e7637b..c295e641e6 100644\n--- a/target/s390x/cpu_models.c\n+++ b/target/s390x/cpu_models.c\n@@ -270,16 +270,11 @@ const S390CPUDef *s390_find_cpu_def(uint16_t type, uint8_t gen, uint8_t ec_ga,\n return last_compatible;\n }\n \n-struct S390PrintCpuListInfo {\n- FILE *f;\n- fprintf_function print;\n-};\n-\n-static void print_cpu_model_list(ObjectClass *klass, void *opaque)\n+static void s390_print_cpu_model_list_entry(gpointer data, gpointer user_data)\n {\n- struct S390PrintCpuListInfo *info = opaque;\n- S390CPUClass *scc = S390_CPU_CLASS(klass);\n- char *name = g_strdup(object_class_get_name(klass));\n+ CPUListState *s = user_data;\n+ const S390CPUClass *scc = S390_CPU_CLASS((ObjectClass *)data);\n+ char *name = g_strdup(object_class_get_name((ObjectClass *)data));\n const char *details = \"\";\n \n if (scc->is_static) {\n@@ -290,21 +285,52 @@ static void print_cpu_model_list(ObjectClass *klass, void *opaque)\n \n /* strip off the -s390-cpu */\n g_strrstr(name, \"-\" TYPE_S390_CPU)[0] = 0;\n- (*info->print)(info->f, \"s390 %-15s %-35s %s\\n\", name, scc->desc,\n- details);\n+ (*s->cpu_fprintf)(s->file, \"s390 %-15s %-35s %s\\n\", name, scc->desc,\n+ details);\n g_free(name);\n }\n \n+static gint s390_cpu_list_compare(gconstpointer a, gconstpointer b)\n+{\n+ const S390CPUClass *cc_a = S390_CPU_CLASS((ObjectClass *)a);\n+ const S390CPUClass *cc_b = S390_CPU_CLASS((ObjectClass *)b);\n+ const char *name_a = object_class_get_name((ObjectClass *)a);\n+ const char *name_b = object_class_get_name((ObjectClass *)b);\n+\n+ /* move qemu and host to the top of the list, qemu first, host second */\n+ if (name_a[0] == 'q') {\n+ return -1;\n+ } else if (name_b[0] == 'q') {\n+ return 1;\n+ } else if (name_a[0] == 'h') {\n+ return -1;\n+ } else if (name_b[0] == 'h') {\n+ return 1;\n+ }\n+\n+ /* keep the same order we have in our table (sorted by release date) */\n+ if (cc_a->cpu_def != cc_b->cpu_def) {\n+ return cc_a->cpu_def - cc_b->cpu_def;\n+ }\n+\n+ /* exact same definition - list base model first */\n+ return cc_a->is_static ? -1 : 1;\n+}\n+\n void s390_cpu_list(FILE *f, fprintf_function print)\n {\n- struct S390PrintCpuListInfo info = {\n- .f = f,\n- .print = print,\n+ CPUListState s = {\n+ .file = f,\n+ .cpu_fprintf = print,\n };\n S390FeatGroup group;\n S390Feat feat;\n+ GSList *list;\n \n- object_class_foreach(print_cpu_model_list, TYPE_S390_CPU, false, &info);\n+ list = object_class_get_list(TYPE_S390_CPU, false);\n+ list = g_slist_sort(list, s390_cpu_list_compare);\n+ g_slist_foreach(list, s390_print_cpu_model_list_entry, &s);\n+ g_slist_free(list);\n \n (*print)(f, \"\\nRecognized feature flags:\\n\");\n for (feat = 0; feat < S390_FEAT_MAX; feat++) {\n", "prefixes": [ "v3", "15/21" ] }