Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811146/?format=api
{ "id": 811146, "url": "http://patchwork.ozlabs.org/api/patches/811146/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170907201335.13956-12-david@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170907201335.13956-12-david@redhat.com>", "list_archive_url": null, "date": "2017-09-07T20:13:25", "name": "[v3,11/21] s390x: allow only 1 CPU with TCG", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3f87792a4e92558f82c5c295a87d27086b501b87", "submitter": { "id": 70402, "url": "http://patchwork.ozlabs.org/api/people/70402/?format=api", "name": "David Hildenbrand", "email": "david@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170907201335.13956-12-david@redhat.com/mbox/", "series": [ { "id": 2053, "url": "http://patchwork.ozlabs.org/api/series/2053/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2053", "date": "2017-09-07T20:13:14", "name": "s390x cleanups and CPU hotplug via device_add", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/2053/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811146/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811146/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpBb26Rlvz9sBW\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Sep 2017 06:17:50 +1000 (AEST)", "from localhost ([::1]:42112 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dq3FE-0006bN-Vj\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 16:17:49 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:38974)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dq3Br-0004Ie-B8\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 16:14:24 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dq3Bm-0002Hw-P5\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 16:14:19 -0400", "from mx1.redhat.com ([209.132.183.28]:52732)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <david@redhat.com>) id 1dq3Bm-0002HU-Il\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 16:14:14 -0400", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 976E5883CD;\n\tThu, 7 Sep 2017 20:14:13 +0000 (UTC)", "from t460s.redhat.com (ovpn-116-60.ams2.redhat.com [10.36.116.60])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 6DCDE5C88F;\n\tThu, 7 Sep 2017 20:14:11 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 976E5883CD", "From": "David Hildenbrand <david@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Thu, 7 Sep 2017 22:13:25 +0200", "Message-Id": "<20170907201335.13956-12-david@redhat.com>", "In-Reply-To": "<20170907201335.13956-1-david@redhat.com>", "References": "<20170907201335.13956-1-david@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tThu, 07 Sep 2017 20:14:13 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v3 11/21] s390x: allow only 1 CPU with TCG", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Matthew Rosato <mjrosato@linux.vnet.ibm.com>, thuth@redhat.com,\n\tEduardo Habkost <ehabkost@redhat.com>, david@redhat.com,\n\tcohuck@redhat.com, Richard Henderson <richard.henderson@linaro.org>,\n\tAlexander Graf <agraf@suse.de>, borntraeger@de.ibm.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Specifying more than 1 CPU (e.g. -smp 5) leads to SIGP errors (the\nguest tries to bring these CPUs up but fails), because we don't support\nmultiple CPUs on s390x under TCG.\n\nLet's bail out if more than 1 is specified, so we don't raise people's\nhope. Make it a define, so we can easily bump it up later.\n\nTested-by: Matthew Rosato <mjrosato@linux.vnet.ibm.com>\nSigned-off-by: David Hildenbrand <david@redhat.com>\n---\n hw/s390x/s390-virtio-ccw.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)", "diff": "diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\nindex f67b4b5d58..f1198b2745 100644\n--- a/hw/s390x/s390-virtio-ccw.c\n+++ b/hw/s390x/s390-virtio-ccw.c\n@@ -23,6 +23,7 @@\n #include \"hw/s390x/css.h\"\n #include \"virtio-ccw.h\"\n #include \"qemu/config-file.h\"\n+#include \"qemu/error-report.h\"\n #include \"s390-pci-bus.h\"\n #include \"hw/s390x/storage-keys.h\"\n #include \"hw/s390x/storage-attributes.h\"\n@@ -47,6 +48,8 @@ S390CPU *s390_cpu_addr2state(uint16_t cpu_addr)\n return cpu_states[cpu_addr];\n }\n \n+/* #define S390_TCG_SMP_SUPPORT */\n+\n static void s390_init_cpus(MachineState *machine)\n {\n int i;\n@@ -55,6 +58,13 @@ static void s390_init_cpus(MachineState *machine)\n if (machine->cpu_model == NULL) {\n machine->cpu_model = s390_default_cpu_model_name();\n }\n+#ifndef S390_TCG_SMP_SUPPORT\n+ if (tcg_enabled() && max_cpus > 1) {\n+ error_report(\"Number of SMP CPUs requested (%d) exceeds max CPUs \"\n+ \"supported by TCG (1) on s390x\", max_cpus);\n+ exit(1);\n+ }\n+#endif\n \n cpu_states = g_new0(S390CPU *, max_cpus);\n \n", "prefixes": [ "v3", "11/21" ] }