Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811137/?format=api
{ "id": 811137, "url": "http://patchwork.ozlabs.org/api/patches/811137/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170907120556.45699-2-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170907120556.45699-2-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-09-07T12:05:47", "name": "[next,S80-V3,02/11] i40evf: fix mac filter removal timing issue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b6d0d0c1d7116677410f82ba4a562b13a8b20453", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170907120556.45699-2-alice.michael@intel.com/mbox/", "series": [ { "id": 2052, "url": "http://patchwork.ozlabs.org/api/series/2052/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=2052", "date": "2017-09-07T12:05:46", "name": "[next,S80-V3,01/11] i40e: use the safe hash table iterator when deleting mac filters", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2052/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811137/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811137/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpBRM5wR5z9t2M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Sep 2017 06:11:11 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1F2E988981;\n\tThu, 7 Sep 2017 20:11:10 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id kSoR9h5Zs7Jw; Thu, 7 Sep 2017 20:11:08 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 07B5188969;\n\tThu, 7 Sep 2017 20:11:08 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9C6841CEB4A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 20:11:01 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 972DC85910\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 20:11:01 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id KTi9obs8sAtv for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 20:10:58 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id B4A91879F6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 20:10:58 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga105.fm.intel.com with ESMTP; 07 Sep 2017 13:10:58 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga001.jf.intel.com with ESMTP; 07 Sep 2017 13:10:57 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.42,360,1500966000\"; d=\"scan'208\";\n\ta=\"1170126567\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Thu, 7 Sep 2017 08:05:47 -0400", "Message-Id": "<20170907120556.45699-2-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.4", "In-Reply-To": "<20170907120556.45699-1-alice.michael@intel.com>", "References": "<20170907120556.45699-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S80-V3 02/11] i40evf: fix mac filter\n\tremoval timing issue", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alan Brady <alan.brady@intel.com>\n\nDue to the asynchronous nature in which mac filters are added and\ndeleted, there exists a bug in which filters are erroneously removed if\nremoved then added again quickly.\n\nThe events are as such:\n - filter marked for removal\n - same filter is re-added before watchdog that cleans up filters\n - we skip re-adding the filter because we have it already in the\nlist\n - watchdog filter cleanup kicks off and filter is removed\n\nSo when we were re-adding the same filter, it didn't actually get added\nbecause it already existed in the list, but was marked for removal and\nhad yet to actually be removed.\n\nThis patch fixes the issue by making sure that when adding a filter, if\nwe find it already existing in our list, make sure it is not marked to\nbe removed.\n\nSigned-off-by: Alan Brady <alan.brady@intel.com>\n---\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex c5371da..4496c48 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -880,6 +880,8 @@ i40evf_mac_filter *i40evf_add_filter(struct i40evf_adapter *adapter,\n \t\tlist_add_tail(&f->list, &adapter->mac_filter_list);\n \t\tf->add = true;\n \t\tadapter->aq_required |= I40EVF_FLAG_AQ_ADD_MAC_FILTER;\n+\t} else {\n+\t\tf->remove = false;\n \t}\n \n \tclear_bit(__I40EVF_IN_CRITICAL_TASK, &adapter->crit_section);\n", "prefixes": [ "next", "S80-V3", "02/11" ] }