Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811135/?format=api
{ "id": 811135, "url": "http://patchwork.ozlabs.org/api/patches/811135/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170907120556.45699-4-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170907120556.45699-4-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-09-07T12:05:49", "name": "[next,S80-V3,04/11] i40e/i40evf: always set the CLEARPBA flag when re-enabling interrupts", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a84afda0e5e1d78c68714c972637b29ba370f473", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170907120556.45699-4-alice.michael@intel.com/mbox/", "series": [ { "id": 2052, "url": "http://patchwork.ozlabs.org/api/series/2052/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=2052", "date": "2017-09-07T12:05:46", "name": "[next,S80-V3,01/11] i40e: use the safe hash table iterator when deleting mac filters", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2052/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811135/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811135/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpBRM3W0gz9t16\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Sep 2017 06:11:10 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4E5C1893B7;\n\tThu, 7 Sep 2017 20:11:09 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id aQqWhbl658Ex; Thu, 7 Sep 2017 20:11:07 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id AF63489F0D;\n\tThu, 7 Sep 2017 20:11:07 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6A4641C1283\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 20:11:01 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 629AA85910\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 20:11:01 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id XOXAnPytSIS0 for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 20:10:59 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 1281987A37\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 20:10:59 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga105.fm.intel.com with ESMTP; 07 Sep 2017 13:10:58 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga001.jf.intel.com with ESMTP; 07 Sep 2017 13:10:57 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.42,360,1500966000\"; d=\"scan'208\";\n\ta=\"1170126574\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Thu, 7 Sep 2017 08:05:49 -0400", "Message-Id": "<20170907120556.45699-4-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.4", "In-Reply-To": "<20170907120556.45699-1-alice.michael@intel.com>", "References": "<20170907120556.45699-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S80-V3 04/11] i40e/i40evf: always set\n\tthe CLEARPBA flag when re-enabling interrupts", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nIn the past we changed driver behavior to not clear the PBA when\nre-enabling interrupts. This change was motivated by the flawed belief\nthat clearing the PBA would cause a lost interrupt if a receive\ninterrupt occurred while interrupts were disabled.\n\nAccording to empirical testing this isn't the case. Additionally, the\ndata sheet specifically says that we should set the CLEARPBA bit when\nre-enabling interrupts in a polling setup.\n\nThis reverts commit 40d72a509862 (\"i40e/i40evf: don't lose interrupts\")\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e.h | 5 +----\n drivers/net/ethernet/intel/i40e/i40e_main.c | 11 +++++------\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 6 ++----\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 +-\n drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 4 +---\n 5 files changed, 10 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h\nindex 18c453a..46df389 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e.h\n@@ -949,9 +949,6 @@ static inline void i40e_irq_dynamic_enable(struct i40e_vsi *vsi, int vector)\n \tstruct i40e_hw *hw = &pf->hw;\n \tu32 val;\n \n-\t/* definitely clear the PBA here, as this function is meant to\n-\t * clean out all previous interrupts AND enable the interrupt\n-\t */\n \tval = I40E_PFINT_DYN_CTLN_INTENA_MASK |\n \t I40E_PFINT_DYN_CTLN_CLEARPBA_MASK |\n \t (I40E_ITR_NONE << I40E_PFINT_DYN_CTLN_ITR_INDX_SHIFT);\n@@ -960,7 +957,7 @@ static inline void i40e_irq_dynamic_enable(struct i40e_vsi *vsi, int vector)\n }\n \n void i40e_irq_dynamic_disable_icr0(struct i40e_pf *pf);\n-void i40e_irq_dynamic_enable_icr0(struct i40e_pf *pf, bool clearpba);\n+void i40e_irq_dynamic_enable_icr0(struct i40e_pf *pf);\n int i40e_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd);\n int i40e_open(struct net_device *netdev);\n int i40e_close(struct net_device *netdev);\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex cc5327c..3d9b65f 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -3403,15 +3403,14 @@ void i40e_irq_dynamic_disable_icr0(struct i40e_pf *pf)\n /**\n * i40e_irq_dynamic_enable_icr0 - Enable default interrupt generation for icr0\n * @pf: board private structure\n- * @clearpba: true when all pending interrupt events should be cleared\n **/\n-void i40e_irq_dynamic_enable_icr0(struct i40e_pf *pf, bool clearpba)\n+void i40e_irq_dynamic_enable_icr0(struct i40e_pf *pf)\n {\n \tstruct i40e_hw *hw = &pf->hw;\n \tu32 val;\n \n \tval = I40E_PFINT_DYN_CTL0_INTENA_MASK |\n-\t (clearpba ? I40E_PFINT_DYN_CTL0_CLEARPBA_MASK : 0) |\n+\t I40E_PFINT_DYN_CTL0_CLEARPBA_MASK |\n \t (I40E_ITR_NONE << I40E_PFINT_DYN_CTL0_ITR_INDX_SHIFT);\n \n \twr32(hw, I40E_PFINT_DYN_CTL0, val);\n@@ -3597,7 +3596,7 @@ static int i40e_vsi_enable_irq(struct i40e_vsi *vsi)\n \t\tfor (i = 0; i < vsi->num_q_vectors; i++)\n \t\t\ti40e_irq_dynamic_enable(vsi, i);\n \t} else {\n-\t\ti40e_irq_dynamic_enable_icr0(pf, true);\n+\t\ti40e_irq_dynamic_enable_icr0(pf);\n \t}\n \n \ti40e_flush(&pf->hw);\n@@ -3746,7 +3745,7 @@ static irqreturn_t i40e_intr(int irq, void *data)\n \twr32(hw, I40E_PFINT_ICR0_ENA, ena_mask);\n \tif (!test_bit(__I40E_DOWN, pf->state)) {\n \t\ti40e_service_event_schedule(pf);\n-\t\ti40e_irq_dynamic_enable_icr0(pf, false);\n+\t\ti40e_irq_dynamic_enable_icr0(pf);\n \t}\n \n \treturn ret;\n@@ -8455,7 +8454,7 @@ static int i40e_setup_misc_vector(struct i40e_pf *pf)\n \n \ti40e_flush(hw);\n \n-\ti40e_irq_dynamic_enable_icr0(pf, true);\n+\ti40e_irq_dynamic_enable_icr0(pf);\n \n \treturn err;\n }\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex 53e1998..0e9a910 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -2201,9 +2201,7 @@ static u32 i40e_buildreg_itr(const int type, const u16 itr)\n \tu32 val;\n \n \tval = I40E_PFINT_DYN_CTLN_INTENA_MASK |\n-\t /* Don't clear PBA because that can cause lost interrupts that\n-\t * came in while we were cleaning/polling\n-\t */\n+\t I40E_PFINT_DYN_CTLN_CLEARPBA_MASK |\n \t (type << I40E_PFINT_DYN_CTLN_ITR_INDX_SHIFT) |\n \t (itr << I40E_PFINT_DYN_CTLN_INTERVAL_SHIFT);\n \n@@ -2240,7 +2238,7 @@ static inline void i40e_update_enable_itr(struct i40e_vsi *vsi,\n \n \t/* If we don't have MSIX, then we only need to re-enable icr0 */\n \tif (!(vsi->back->flags & I40E_FLAG_MSIX_ENABLED)) {\n-\t\ti40e_irq_dynamic_enable_icr0(vsi->back, false);\n+\t\ti40e_irq_dynamic_enable_icr0(vsi->back);\n \t\treturn;\n \t}\n \ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex d8fbdda..c7f0a72 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -1355,7 +1355,7 @@ int i40e_alloc_vfs(struct i40e_pf *pf, u16 num_alloc_vfs)\n \t\ti40e_free_vfs(pf);\n err_iov:\n \t/* Re-enable interrupt 0. */\n-\ti40e_irq_dynamic_enable_icr0(pf, false);\n+\ti40e_irq_dynamic_enable_icr0(pf);\n \treturn ret;\n }\n \ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\nindex 8167617..4ae054d 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n@@ -1409,9 +1409,7 @@ static u32 i40e_buildreg_itr(const int type, const u16 itr)\n \tu32 val;\n \n \tval = I40E_VFINT_DYN_CTLN1_INTENA_MASK |\n-\t /* Don't clear PBA because that can cause lost interrupts that\n-\t * came in while we were cleaning/polling\n-\t */\n+\t I40E_VFINT_DYN_CTLN1_CLEARPBA_MASK |\n \t (type << I40E_VFINT_DYN_CTLN1_ITR_INDX_SHIFT) |\n \t (itr << I40E_VFINT_DYN_CTLN1_INTERVAL_SHIFT);\n \n", "prefixes": [ "next", "S80-V3", "04/11" ] }