Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811133/?format=api
{ "id": 811133, "url": "http://patchwork.ozlabs.org/api/patches/811133/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170907120556.45699-3-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170907120556.45699-3-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-09-07T12:05:48", "name": "[next,S80-V3,03/11] i40e/i40evf: fix incorrect default ITR values on driver load", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3058b9b9b9ea7fa68cb3f6d74d8758df5d2c5451", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170907120556.45699-3-alice.michael@intel.com/mbox/", "series": [ { "id": 2052, "url": "http://patchwork.ozlabs.org/api/series/2052/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=2052", "date": "2017-09-07T12:05:46", "name": "[next,S80-V3,01/11] i40e: use the safe hash table iterator when deleting mac filters", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2052/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811133/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811133/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpBRL3Mn1z9sBW\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Sep 2017 06:11:10 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0019187A37;\n\tThu, 7 Sep 2017 20:11:08 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id m_P-HpDL1-Z2; Thu, 7 Sep 2017 20:11:08 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 5390A87A3B;\n\tThu, 7 Sep 2017 20:11:08 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id B90ED1C1283\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 20:11:01 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B1CC685910\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 20:11:01 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tj-dtwGZB-qO for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 20:10:59 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id DEEAE87A18\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 20:10:58 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga105.fm.intel.com with ESMTP; 07 Sep 2017 13:10:58 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga001.jf.intel.com with ESMTP; 07 Sep 2017 13:10:57 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.42,360,1500966000\"; d=\"scan'208\";\n\ta=\"1170126571\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Thu, 7 Sep 2017 08:05:48 -0400", "Message-Id": "<20170907120556.45699-3-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.4", "In-Reply-To": "<20170907120556.45699-1-alice.michael@intel.com>", "References": "<20170907120556.45699-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S80-V3 03/11] i40e/i40evf: fix\n\tincorrect default ITR values on driver load", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nThe ITR register expects to be programmed in units of 2 microseconds.\nBecause of this, all of the drivers I40E_ITR_* constants are in terms of\nthis 2 microsecond register.\n\nUnfortunately, the rx_itr_default value is expected to be programmed in\nmicroseconds.\n\nEffectively the driver defaults to an ITR value of half the expected\nvalue (in terms of minimum microseconds between interrupts).\n\nFix this by changing the default values to be calculated using\nITR_REG_TO_USEC macro which indicates that we're converting from the\nregister units into microseconds.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--\n drivers/net/ethernet/intel/i40e/i40e_txrx.h | 6 ++++--\n drivers/net/ethernet/intel/i40evf/i40e_txrx.h | 6 ++++--\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 4 ++--\n 4 files changed, 12 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 76b03f7..cc5327c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -8983,8 +8983,8 @@ static int i40e_sw_init(struct i40e_pf *pf)\n \t\t I40E_FLAG_MSIX_ENABLED;\n \n \t/* Set default ITR */\n-\tpf->rx_itr_default = I40E_ITR_DYNAMIC | I40E_ITR_RX_DEF;\n-\tpf->tx_itr_default = I40E_ITR_DYNAMIC | I40E_ITR_TX_DEF;\n+\tpf->rx_itr_default = I40E_ITR_RX_DEF;\n+\tpf->tx_itr_default = I40E_ITR_TX_DEF;\n \n \t/* Depending on PF configurations, it is possible that the RSS\n \t * maximum might end up larger than the available queues\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.h b/drivers/net/ethernet/intel/i40e/i40e_txrx.h\nindex a4e3e66..c3156aa 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.h\n@@ -38,8 +38,10 @@\n #define I40E_ITR_8K 0x003E\n #define I40E_ITR_4K 0x007A\n #define I40E_MAX_INTRL 0x3B /* reg uses 4 usec resolution */\n-#define I40E_ITR_RX_DEF I40E_ITR_20K\n-#define I40E_ITR_TX_DEF I40E_ITR_20K\n+#define I40E_ITR_RX_DEF (ITR_REG_TO_USEC(I40E_ITR_20K) | \\\n+\t\t\t\t I40E_ITR_DYNAMIC)\n+#define I40E_ITR_TX_DEF (ITR_REG_TO_USEC(I40E_ITR_20K) | \\\n+\t\t\t\t I40E_ITR_DYNAMIC)\n #define I40E_ITR_DYNAMIC 0x8000 /* use top bit as a flag */\n #define I40E_MIN_INT_RATE 250 /* ~= 1000000 / (I40E_MAX_ITR * 2) */\n #define I40E_MAX_INT_RATE 500000 /* == 1000000 / (I40E_MIN_ITR * 2) */\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.h b/drivers/net/ethernet/intel/i40evf/i40e_txrx.h\nindex d8ca802..8f9830d 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.h\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.h\n@@ -38,8 +38,10 @@\n #define I40E_ITR_8K 0x003E\n #define I40E_ITR_4K 0x007A\n #define I40E_MAX_INTRL 0x3B /* reg uses 4 usec resolution */\n-#define I40E_ITR_RX_DEF I40E_ITR_20K\n-#define I40E_ITR_TX_DEF I40E_ITR_20K\n+#define I40E_ITR_RX_DEF (ITR_REG_TO_USEC(I40E_ITR_20K) | \\\n+\t\t\t\t I40E_ITR_DYNAMIC)\n+#define I40E_ITR_TX_DEF (ITR_REG_TO_USEC(I40E_ITR_20K) | \\\n+\t\t\t\t I40E_ITR_DYNAMIC)\n #define I40E_ITR_DYNAMIC 0x8000 /* use top bit as a flag */\n #define I40E_MIN_INT_RATE 250 /* ~= 1000000 / (I40E_MAX_ITR * 2) */\n #define I40E_MAX_INT_RATE 500000 /* == 1000000 / (I40E_MIN_ITR * 2) */\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex 4496c48..d621daa 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -1223,7 +1223,7 @@ static int i40evf_alloc_queues(struct i40evf_adapter *adapter)\n \t\ttx_ring->netdev = adapter->netdev;\n \t\ttx_ring->dev = &adapter->pdev->dev;\n \t\ttx_ring->count = adapter->tx_desc_count;\n-\t\ttx_ring->tx_itr_setting = (I40E_ITR_DYNAMIC | I40E_ITR_TX_DEF);\n+\t\ttx_ring->tx_itr_setting = I40E_ITR_TX_DEF;\n \t\tif (adapter->flags & I40EVF_FLAG_WB_ON_ITR_CAPABLE)\n \t\t\ttx_ring->flags |= I40E_TXR_FLAGS_WB_ON_ITR;\n \n@@ -1232,7 +1232,7 @@ static int i40evf_alloc_queues(struct i40evf_adapter *adapter)\n \t\trx_ring->netdev = adapter->netdev;\n \t\trx_ring->dev = &adapter->pdev->dev;\n \t\trx_ring->count = adapter->rx_desc_count;\n-\t\trx_ring->rx_itr_setting = (I40E_ITR_DYNAMIC | I40E_ITR_RX_DEF);\n+\t\trx_ring->rx_itr_setting = I40E_ITR_RX_DEF;\n \t}\n \n \tadapter->num_active_queues = num_active_queues;\n", "prefixes": [ "next", "S80-V3", "03/11" ] }