Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811132/?format=api
{ "id": 811132, "url": "http://patchwork.ozlabs.org/api/patches/811132/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170907120556.45699-11-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170907120556.45699-11-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-09-07T12:05:56", "name": "[next,S80-V3,11/11] i40e: use a local variable instead of calculating multiple times", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3c864d899ff739f39744356ece611be3f03c4883", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170907120556.45699-11-alice.michael@intel.com/mbox/", "series": [ { "id": 2052, "url": "http://patchwork.ozlabs.org/api/series/2052/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=2052", "date": "2017-09-07T12:05:46", "name": "[next,S80-V3,01/11] i40e: use the safe hash table iterator when deleting mac filters", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2052/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811132/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811132/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpBRK3bGDz9sBW\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Sep 2017 06:11:09 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 13A7830587;\n\tThu, 7 Sep 2017 20:11:08 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id W8xB1H8HKcLN; Thu, 7 Sep 2017 20:11:07 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 1EE6D3058E;\n\tThu, 7 Sep 2017 20:11:07 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 22B291C1283\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 20:11:01 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1C84D85910\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 20:11:01 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 49Gj13ppQ24a for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 20:11:00 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id D241F87A8B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 20:10:59 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga105.fm.intel.com with ESMTP; 07 Sep 2017 13:10:58 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga001.jf.intel.com with ESMTP; 07 Sep 2017 13:10:58 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.42,360,1500966000\"; d=\"scan'208\";\n\ta=\"1170126596\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Thu, 7 Sep 2017 08:05:56 -0400", "Message-Id": "<20170907120556.45699-11-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.4", "In-Reply-To": "<20170907120556.45699-1-alice.michael@intel.com>", "References": "<20170907120556.45699-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S80-V3 11/11] i40e: use a local\n\tvariable instead of calculating multiple times", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Lihong Yang <lihong.yang@intel.com>\n\nThe computed result of I40E_MAX_VSI_QP * I40E_VIRTCHNL_SUPPORTED_QTYPES\nis used more than three times in function i40e_config_irq_link_list.\nSimply declare a local variable to store it to improve readability.\n\nSigned-off-by: Lihong Yang <lihong.yang@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 20 +++++++-------------\n 1 file changed, 7 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex b2bdf27..341944b 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -273,7 +273,7 @@ static void i40e_config_irq_link_list(struct i40e_vf *vf, u16 vsi_id,\n \tstruct i40e_hw *hw = &pf->hw;\n \tu16 vsi_queue_id, pf_queue_id;\n \tenum i40e_queue_type qtype;\n-\tu16 next_q, vector_id;\n+\tu16 next_q, vector_id, size;\n \tu32 reg, reg_idx;\n \tu16 itr_idx = 0;\n \n@@ -303,11 +303,9 @@ static void i40e_config_irq_link_list(struct i40e_vf *vf, u16 vsi_id,\n \t\t\t\t vsi_queue_id + 1));\n \t}\n \n-\tnext_q = find_first_bit(&linklistmap,\n-\t\t\t\t(I40E_MAX_VSI_QP *\n-\t\t\t\t I40E_VIRTCHNL_SUPPORTED_QTYPES));\n-\tif (unlikely(next_q == (I40E_MAX_VSI_QP *\n-\t\t\t\tI40E_VIRTCHNL_SUPPORTED_QTYPES)))\n+\tsize = I40E_MAX_VSI_QP * I40E_VIRTCHNL_SUPPORTED_QTYPES;\n+\tnext_q = find_first_bit(&linklistmap, size);\n+\tif (unlikely(next_q == size))\n \t\tgoto irq_list_done;\n \n \tvsi_queue_id = next_q / I40E_VIRTCHNL_SUPPORTED_QTYPES;\n@@ -317,7 +315,7 @@ static void i40e_config_irq_link_list(struct i40e_vf *vf, u16 vsi_id,\n \n \twr32(hw, reg_idx, reg);\n \n-\twhile (next_q < (I40E_MAX_VSI_QP * I40E_VIRTCHNL_SUPPORTED_QTYPES)) {\n+\twhile (next_q < size) {\n \t\tswitch (qtype) {\n \t\tcase I40E_QUEUE_TYPE_RX:\n \t\t\treg_idx = I40E_QINT_RQCTL(pf_queue_id);\n@@ -331,12 +329,8 @@ static void i40e_config_irq_link_list(struct i40e_vf *vf, u16 vsi_id,\n \t\t\tbreak;\n \t\t}\n \n-\t\tnext_q = find_next_bit(&linklistmap,\n-\t\t\t\t (I40E_MAX_VSI_QP *\n-\t\t\t\t\tI40E_VIRTCHNL_SUPPORTED_QTYPES),\n-\t\t\t\t next_q + 1);\n-\t\tif (next_q <\n-\t\t (I40E_MAX_VSI_QP * I40E_VIRTCHNL_SUPPORTED_QTYPES)) {\n+\t\tnext_q = find_next_bit(&linklistmap, size, next_q + 1);\n+\t\tif (next_q < size) {\n \t\t\tvsi_queue_id = next_q / I40E_VIRTCHNL_SUPPORTED_QTYPES;\n \t\t\tqtype = next_q % I40E_VIRTCHNL_SUPPORTED_QTYPES;\n \t\t\tpf_queue_id = i40e_vc_get_pf_queue_id(vf, vsi_id,\n", "prefixes": [ "next", "S80-V3", "11/11" ] }