Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811131/?format=api
{ "id": 811131, "url": "http://patchwork.ozlabs.org/api/patches/811131/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170907120556.45699-10-alice.michael@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170907120556.45699-10-alice.michael@intel.com>", "list_archive_url": null, "date": "2017-09-07T12:05:55", "name": "[next,S80-V3,10/11] i40e: Retry AQC GetPhyAbilities to overcome I2CRead hangs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "617e8f490d4d043217f721cd3acf57ebd631cb7c", "submitter": { "id": 71123, "url": "http://patchwork.ozlabs.org/api/people/71123/?format=api", "name": "Michael, Alice", "email": "alice.michael@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170907120556.45699-10-alice.michael@intel.com/mbox/", "series": [ { "id": 2052, "url": "http://patchwork.ozlabs.org/api/series/2052/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=2052", "date": "2017-09-07T12:05:46", "name": "[next,S80-V3,01/11] i40e: use the safe hash table iterator when deleting mac filters", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2052/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811131/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811131/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpBRJ5cDSz9sMN\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Sep 2017 06:11:08 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 56A51893BA;\n\tThu, 7 Sep 2017 20:11:07 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bR7i1-VSgD6R; Thu, 7 Sep 2017 20:11:06 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id BCB7689C4F;\n\tThu, 7 Sep 2017 20:11:06 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id EBBB51CEB4A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 20:11:00 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E579685910\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 20:11:00 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id sYm95FiqkAmp for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 20:11:00 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id B1F5387A59\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 7 Sep 2017 20:10:59 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga105.fm.intel.com with ESMTP; 07 Sep 2017 13:10:58 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby orsmga001.jf.intel.com with ESMTP; 07 Sep 2017 13:10:58 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.42,360,1500966000\"; d=\"scan'208\";\n\ta=\"1170126594\"", "From": "Alice Michael <alice.michael@intel.com>", "To": "alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Thu, 7 Sep 2017 08:05:55 -0400", "Message-Id": "<20170907120556.45699-10-alice.michael@intel.com>", "X-Mailer": "git-send-email 2.9.4", "In-Reply-To": "<20170907120556.45699-1-alice.michael@intel.com>", "References": "<20170907120556.45699-1-alice.michael@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S80-V3 10/11] i40e: Retry AQC\n\tGetPhyAbilities to overcome I2CRead hangs", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jayaprakash Shanmugam <jayaprakash.shanmugam@intel.com>\n\n- When the I2C is busy, the PHY reads are delayed. The firmware will\n return EGAIN in these cases with an expectation that the SW will\n trigger the reads again\n- This patch retries the operation for a maximum period of 500ms\n\nSigned-off-by: Jayaprakash Shanmugam <jayaprakash.shanmugam@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_common.c | 42 ++++++++++++++++++---------\n drivers/net/ethernet/intel/i40e/i40e_type.h | 3 ++\n drivers/net/ethernet/intel/i40evf/i40e_type.h | 3 ++\n 3 files changed, 35 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c\nindex cb4468c..e7d8a01 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c\n@@ -1567,30 +1567,46 @@ i40e_status i40e_aq_get_phy_capabilities(struct i40e_hw *hw,\n \tstruct i40e_aq_desc desc;\n \ti40e_status status;\n \tu16 abilities_size = sizeof(struct i40e_aq_get_phy_abilities_resp);\n+\tu16 max_delay = I40E_MAX_PHY_TIMEOUT, total_delay = 0;\n \n \tif (!abilities)\n \t\treturn I40E_ERR_PARAM;\n \n-\ti40e_fill_default_direct_cmd_desc(&desc,\n-\t\t\t\t\t i40e_aqc_opc_get_phy_abilities);\n+\tdo {\n+\t\ti40e_fill_default_direct_cmd_desc(&desc,\n+\t\t\t\t\t i40e_aqc_opc_get_phy_abilities);\n \n-\tdesc.flags |= cpu_to_le16((u16)I40E_AQ_FLAG_BUF);\n-\tif (abilities_size > I40E_AQ_LARGE_BUF)\n-\t\tdesc.flags |= cpu_to_le16((u16)I40E_AQ_FLAG_LB);\n+\t\tdesc.flags |= cpu_to_le16((u16)I40E_AQ_FLAG_BUF);\n+\t\tif (abilities_size > I40E_AQ_LARGE_BUF)\n+\t\t\tdesc.flags |= cpu_to_le16((u16)I40E_AQ_FLAG_LB);\n \n-\tif (qualified_modules)\n-\t\tdesc.params.external.param0 |=\n+\t\tif (qualified_modules)\n+\t\t\tdesc.params.external.param0 |=\n \t\t\tcpu_to_le32(I40E_AQ_PHY_REPORT_QUALIFIED_MODULES);\n \n-\tif (report_init)\n-\t\tdesc.params.external.param0 |=\n+\t\tif (report_init)\n+\t\t\tdesc.params.external.param0 |=\n \t\t\tcpu_to_le32(I40E_AQ_PHY_REPORT_INITIAL_VALUES);\n \n-\tstatus = i40e_asq_send_command(hw, &desc, abilities, abilities_size,\n-\t\t\t\t cmd_details);\n+\t\tstatus = i40e_asq_send_command(hw, &desc, abilities,\n+\t\t\t\t\t abilities_size, cmd_details);\n \n-\tif (hw->aq.asq_last_status == I40E_AQ_RC_EIO)\n-\t\tstatus = I40E_ERR_UNKNOWN_PHY;\n+\t\tif (status)\n+\t\t\tbreak;\n+\n+\t\tif (hw->aq.asq_last_status == I40E_AQ_RC_EIO) {\n+\t\t\tstatus = I40E_ERR_UNKNOWN_PHY;\n+\t\t\tbreak;\n+\t\t} else if (hw->aq.asq_last_status == I40E_AQ_RC_EAGAIN) {\n+\t\t\tusleep_range(1000, 2000);\n+\t\t\ttotal_delay++;\n+\t\t\tstatus = I40E_ERR_TIMEOUT;\n+\t\t}\n+\t} while ((hw->aq.asq_last_status != I40E_AQ_RC_OK) &&\n+\t\t (total_delay < max_delay));\n+\n+\tif (status)\n+\t\treturn status;\n \n \tif (report_init) {\n \t\tif (hw->mac.type == I40E_MAC_XL710 &&\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h\nindex 4b32b1d..0410fcb 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_type.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_type.h\n@@ -46,6 +46,9 @@\n /* Max default timeout in ms, */\n #define I40E_MAX_NVM_TIMEOUT\t\t18000\n \n+/* Max timeout in ms for the phy to respond */\n+#define I40E_MAX_PHY_TIMEOUT\t\t500\n+\n /* Switch from ms to the 1usec global time (this is the GTIME resolution) */\n #define I40E_MS_TO_GTIME(time)\t\t((time) * 1000)\n \ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_type.h b/drivers/net/ethernet/intel/i40evf/i40e_type.h\nindex 9364b67..213b773 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_type.h\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_type.h\n@@ -46,6 +46,9 @@\n /* Max default timeout in ms, */\n #define I40E_MAX_NVM_TIMEOUT\t\t18000\n \n+/* Max timeout in ms for the phy to respond */\n+#define I40E_MAX_PHY_TIMEOUT\t\t500\n+\n /* Switch from ms to the 1usec global time (this is the GTIME resolution) */\n #define I40E_MS_TO_GTIME(time)\t\t((time) * 1000)\n \n", "prefixes": [ "next", "S80-V3", "10/11" ] }