Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811115/?format=api
{ "id": 811115, "url": "http://patchwork.ozlabs.org/api/patches/811115/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170907185057.23421-4-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170907185057.23421-4-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2017-09-07T18:50:55", "name": "[v2,3/5] target/sh4: Do not singlestep after exceptions", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "65c57473f92595a66f70b8bfc4f26cc58e9a9e45", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170907185057.23421-4-richard.henderson@linaro.org/mbox/", "series": [ { "id": 2042, "url": "http://patchwork.ozlabs.org/api/series/2042/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=2042", "date": "2017-09-07T18:50:52", "name": "target/sh4 updates", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/2042/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811115/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811115/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"JnwOSDVH\"; dkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp8kG2RCdz9t16\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 8 Sep 2017 04:53:54 +1000 (AEST)", "from localhost ([::1]:41774 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dq1w0-00026n-RU\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 14:53:52 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:54143)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1dq1tM-0000A4-PZ\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 14:51:13 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1dq1tI-0000VH-7l\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 14:51:08 -0400", "from mail-pf0-x233.google.com ([2607:f8b0:400e:c00::233]:35759)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <richard.henderson@linaro.org>)\n\tid 1dq1tI-0000Ur-1b\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 14:51:04 -0400", "by mail-pf0-x233.google.com with SMTP id g13so834775pfm.2\n\tfor <qemu-devel@nongnu.org>; Thu, 07 Sep 2017 11:51:03 -0700 (PDT)", "from pike.twiddle.net (97-126-108-236.tukw.qwest.net.\n\t[97.126.108.236]) by smtp.gmail.com with ESMTPSA id\n\tl74sm481401pfi.9.2017.09.07.11.51.01\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 07 Sep 2017 11:51:01 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=+obuuT3KDqk3lML+4zyj2n1JXa6qR78HKFY2pMtYFmA=;\n\tb=JnwOSDVH65IdZBt4GomioBwawVzPBNGhhQmwF+vK/2rG8mb1dPW+0r5sjhaa8la1yB\n\teW50md0xERs5pLkDps2lvfdyuhLvuuRu38xI7o1LJwIDgSJDyUiiQx5vW9qGrahXjsTn\n\tgnn3BHKaLGUc5WJQVdFwN1ty66mD3JZ9bawrY=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=+obuuT3KDqk3lML+4zyj2n1JXa6qR78HKFY2pMtYFmA=;\n\tb=KJcoPz6MdPjWJyp9pZAYL77DI4q0E98RtIRJPAWmrpn95z0Y/nbsKm//YFLCZ9mYb8\n\tjYEbRv6gkcSawubzmNGTPLmug1OtP+JQwV6dKehL99eSF7CuXh1TQBnQMfNhtgXM3qFN\n\t/ZheoG5eudxMjQV9UKh3FX2umSD4l0Tf2xlN8SBIXsdcoDfXfGmLOq1VpqqFSM0SHLE8\n\tijMsvkl00UxQ7ZwF3JXNQAnm3EJJGblbu5x+2ltNOGrRu1Z7q83/t+ZlzvaGsHS1RFNq\n\tbLfPV7kqeN/62iP0e8uwjvcmxXLgVHCJYWvp07JVVVzZ2YLXaGbg5UBvvskLSRD4VQGI\n\t2+Hw==", "X-Gm-Message-State": "AHPjjUg+W91CLsei8STNdDbdxxAVN0s+xra2duN8Igs7sRTJrDRFW6Vb\n\tYHzsfVpbgiRWjdvBFTOzfQ==", "X-Google-Smtp-Source": "ADKCNb5Pq79h9mMTbhRSZKBQQqool5j18X6wC25rhbhLh6sM3GsB/EHoOtieaQym5SIkl9jr/MQn1A==", "X-Received": "by 10.99.44.86 with SMTP id s83mr299904pgs.341.1504810262625;\n\tThu, 07 Sep 2017 11:51:02 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Date": "Thu, 7 Sep 2017 11:50:55 -0700", "Message-Id": "<20170907185057.23421-4-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.13.5", "In-Reply-To": "<20170907185057.23421-1-richard.henderson@linaro.org>", "References": "<20170907185057.23421-1-richard.henderson@linaro.org>", "X-detected-operating-system": "by eggs.gnu.org: Genre and OS details not\n\trecognized.", "X-Received-From": "2607:f8b0:400e:c00::233", "Subject": "[Qemu-devel] [PATCH v2 3/5] target/sh4: Do not singlestep after\n\texceptions", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "aurelien@aurel32.net, Richard Henderson <rth@twiddle.net>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Richard Henderson <rth@twiddle.net>\n\nIf we've already raised an exception (and set NORETURN),\ndo not emit unreachable code to raise a debug exception.\nNote that gen_goto_tb takes single-stepping into account.\n\nSigned-off-by: Richard Henderson <rth@twiddle.net>\n---\n target/sh4/translate.c | 32 ++++++++++++++++----------------\n 1 file changed, 16 insertions(+), 16 deletions(-)", "diff": "diff --git a/target/sh4/translate.c b/target/sh4/translate.c\nindex 6e03370871..5cda27cc0a 100644\n--- a/target/sh4/translate.c\n+++ b/target/sh4/translate.c\n@@ -281,6 +281,7 @@ static void gen_jump(DisasContext * ctx)\n } else {\n tcg_gen_lookup_and_goto_ptr(cpu_pc);\n }\n+ ctx->bstate = DISAS_NORETURN;\n } else {\n \tgen_goto_tb(ctx, 0, ctx->delayed_pc);\n }\n@@ -2349,24 +2350,23 @@ void gen_intermediate_code(CPUState *cs, struct TranslationBlock *tb)\n ctx.envflags &= ~GUSA_MASK;\n }\n \n- if (cs->singlestep_enabled) {\n+ switch (ctx.bstate) {\n+ case DISAS_STOP:\n gen_save_cpu_state(&ctx, true);\n- gen_helper_debug(cpu_env);\n- } else {\n-\tswitch (ctx.bstate) {\n- case DISAS_STOP:\n- gen_save_cpu_state(&ctx, true);\n+ if (cs->singlestep_enabled) {\n+ gen_helper_debug(cpu_env);\n+ } else {\n tcg_gen_exit_tb(0);\n- break;\n- case DISAS_NEXT:\n- gen_save_cpu_state(&ctx, false);\n- gen_goto_tb(&ctx, 0, ctx.pc);\n- break;\n- case DISAS_NORETURN:\n- break;\n- default:\n- g_assert_not_reached();\n-\t}\n+ }\n+ break;\n+ case DISAS_NEXT:\n+ gen_save_cpu_state(&ctx, false);\n+ gen_goto_tb(&ctx, 0, ctx.pc);\n+ break;\n+ case DISAS_NORETURN:\n+ break;\n+ default:\n+ g_assert_not_reached();\n }\n \n gen_tb_end(tb, num_insns);\n", "prefixes": [ "v2", "3/5" ] }