Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/811044/?format=api
{ "id": 811044, "url": "http://patchwork.ozlabs.org/api/patches/811044/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20170907135138.2199-2-kleber.souza@canonical.com/", "project": { "id": 15, "url": "http://patchwork.ozlabs.org/api/projects/15/?format=api", "name": "Ubuntu Kernel", "link_name": "ubuntu-kernel", "list_id": "kernel-team.lists.ubuntu.com", "list_email": "kernel-team@lists.ubuntu.com", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170907135138.2199-2-kleber.souza@canonical.com>", "list_archive_url": null, "date": "2017-09-07T13:51:38", "name": "[Xenial,SRU,1/1] mm: revert x86_64 and arm64 ELF_ET_DYN_BASE base changes", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8d9ae6ce41cf33034d85295f6010b87c2aa701af", "submitter": { "id": 71419, "url": "http://patchwork.ozlabs.org/api/people/71419/?format=api", "name": "Kleber Sacilotto de Souza", "email": "kleber.souza@canonical.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20170907135138.2199-2-kleber.souza@canonical.com/mbox/", "series": [ { "id": 2003, "url": "http://patchwork.ozlabs.org/api/series/2003/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ubuntu-kernel/list/?series=2003", "date": "2017-09-07T13:51:37", "name": "Fix for LP: #1715636", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/2003/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/811044/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/811044/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<kernel-team-bounces@lists.ubuntu.com>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=<UNKNOWN>)", "Received": [ "from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xp21f3MrMz9t2M;\n\tThu, 7 Sep 2017 23:51:50 +1000 (AEST)", "from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from <kernel-team-bounces@lists.ubuntu.com>)\n\tid 1dpxDe-0003so-DQ; Thu, 07 Sep 2017 13:51:46 +0000", "from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from <kleber.souza@canonical.com>)\n\tid 1dpxDc-0003sX-2C\n\tfor kernel-team@lists.ubuntu.com; Thu, 07 Sep 2017 13:51:44 +0000", "from mail-wm0-f72.google.com ([74.125.82.72])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from <kleber.souza@canonical.com>)\n\tid 1dpxDb-000660-RK\n\tfor kernel-team@lists.ubuntu.com; Thu, 07 Sep 2017 13:51:43 +0000", "by mail-wm0-f72.google.com with SMTP id l19so1560941wmi.1\n\tfor <kernel-team@lists.ubuntu.com>;\n\tThu, 07 Sep 2017 06:51:43 -0700 (PDT)", "from localhost (ip5f5bd015.dynamic.kabel-deutschland.de.\n\t[95.91.208.21]) by smtp.gmail.com with ESMTPSA id\n\te56sm3075852edb.7.2017.09.07.06.51.41\n\tfor <kernel-team@lists.ubuntu.com>\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 07 Sep 2017 06:51:42 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=ToVixC1vogDphSu/yL6NMv9zdqWsZfB+AjCzSJum3L8=;\n\tb=MEKVQ9/iGIAsW6jGz2s1fIjyH3f0oW8BPyCpOdsWQQcNKvNNsco94QwO3CERMOEtJl\n\tWJDfVg5CVOUe2MXio7hJtL3z3Jkk4aSwIaOSWRGjFzgAiSn7oSzxobb4k+h80LHr7b5P\n\tjGOrNX8o9mlyzYWsUKsRfko1WOk6RAK8bnVB303qVCnxLR0cA3LfAifWL+hbxPblUk1h\n\tIjiHdTmgsOZgmvI5nHYi7aGr3rxs0IysgpVYcH1Vunsthk9028/Ipf6iZcGgKjdKGbCq\n\tkcqhWa9/lxdBWYkJYBx6lrqV+T+ZVgpP+V39QvWCwYBnWg2ULIZNy5/98UyQvsckccrU\n\tUQ5Q==", "X-Gm-Message-State": "AHPjjUjMfv/BqMPDXvAWkGvJ1wJphIOQXztYN/zTQp24ivhslb2pPHOB\n\t2k0yiEiGhI55biAmQml7fZH0O5+zmYgJJUFm8rYHQhSQHEvG1vEXlFn04OR7PY7d0Ax67OCgV6z\n\t2KWvSj2B7g+WmE5qXfKa/Na3hB2LvGym2", "X-Received": [ "by 10.80.206.68 with SMTP id k4mr2614543edj.48.1504792303234;\n\tThu, 07 Sep 2017 06:51:43 -0700 (PDT)", "by 10.80.206.68 with SMTP id k4mr2614535edj.48.1504792303015;\n\tThu, 07 Sep 2017 06:51:43 -0700 (PDT)" ], "X-Google-Smtp-Source": "ADKCNb5X5khUte9G3ln9LcB9XmpHdimyhU3yk/2zhWGgCp5/ce4zK3GVBH/UZUN9CsQq/H+Ka0bCCg==", "From": "Kleber Sacilotto de Souza <kleber.souza@canonical.com>", "To": "kernel-team@lists.ubuntu.com", "Subject": "[Xenial SRU][PATCH 1/1] mm: revert x86_64 and arm64 ELF_ET_DYN_BASE\n\tbase changes", "Date": "Thu, 7 Sep 2017 15:51:38 +0200", "Message-Id": "<20170907135138.2199-2-kleber.souza@canonical.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20170907135138.2199-1-kleber.souza@canonical.com>", "References": "<20170907135138.2199-1-kleber.souza@canonical.com>", "X-BeenThere": "kernel-team@lists.ubuntu.com", "X-Mailman-Version": "2.1.20", "Precedence": "list", "List-Id": "Kernel team discussions <kernel-team.lists.ubuntu.com>", "List-Unsubscribe": "<https://lists.ubuntu.com/mailman/options/kernel-team>,\n\t<mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe>", "List-Archive": "<https://lists.ubuntu.com/archives/kernel-team>", "List-Post": "<mailto:kernel-team@lists.ubuntu.com>", "List-Help": "<mailto:kernel-team-request@lists.ubuntu.com?subject=help>", "List-Subscribe": "<https://lists.ubuntu.com/mailman/listinfo/kernel-team>,\n\t<mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "kernel-team-bounces@lists.ubuntu.com", "Sender": "\"kernel-team\" <kernel-team-bounces@lists.ubuntu.com>" }, "content": "From: Kees Cook <keescook@chromium.org>\n\nBugLink: http://bugs.launchpad.net/bugs/1715636\n\nMoving the x86_64 and arm64 PIE base from 0x555555554000 to 0x000100000000\nbroke AddressSanitizer. This is a partial revert of:\n\n eab09532d400 (\"binfmt_elf: use ELF_ET_DYN_BASE only for PIE\")\n 02445990a96e (\"arm64: move ELF_ET_DYN_BASE to 4GB / 4MB\")\n\nThe AddressSanitizer tool has hard-coded expectations about where\nexecutable mappings are loaded.\n\nThe motivation for changing the PIE base in the above commits was to\navoid the Stack-Clash CVEs that allowed executable mappings to get too\nclose to heap and stack. This was mainly a problem on 32-bit, but the\n64-bit bases were moved too, in an effort to proactively protect those\nsystems (proofs of concept do exist that show 64-bit collisions, but\nother recent changes to fix stack accounting and setuid behaviors will\nminimize the impact).\n\nThe new 32-bit PIE base is fine for ASan (since it matches the ET_EXEC\nbase), so only the 64-bit PIE base needs to be reverted to let x86 and\narm64 ASan binaries run again. Future changes to the 64-bit PIE base on\nthese architectures can be made optional once a more dynamic method for\ndealing with AddressSanitizer is found. (e.g. always loading PIE into\nthe mmap region for marked binaries.)\n\nLink: http://lkml.kernel.org/r/20170807201542.GA21271@beast\nFixes: eab09532d400 (\"binfmt_elf: use ELF_ET_DYN_BASE only for PIE\")\nFixes: 02445990a96e (\"arm64: move ELF_ET_DYN_BASE to 4GB / 4MB\")\nSigned-off-by: Kees Cook <keescook@chromium.org>\nReported-by: Kostya Serebryany <kcc@google.com>\nAcked-by: Will Deacon <will.deacon@arm.com>\nCc: Ingo Molnar <mingo@elte.hu>\nCc: \"H. Peter Anvin\" <hpa@zytor.com>\nCc: Thomas Gleixner <tglx@linutronix.de>\nCc: <stable@vger.kernel.org>\nSigned-off-by: Andrew Morton <akpm@linux-foundation.org>\nSigned-off-by: Linus Torvalds <torvalds@linux-foundation.org>\n(cherry picked from commit c715b72c1ba406f133217b509044c38d8e714a37)\nSigned-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>\n---\n arch/arm64/include/asm/elf.h | 4 ++--\n arch/x86/include/asm/elf.h | 4 ++--\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/arch/arm64/include/asm/elf.h b/arch/arm64/include/asm/elf.h\nindex 9e11dbe1cec3..329c127e13dc 100644\n--- a/arch/arm64/include/asm/elf.h\n+++ b/arch/arm64/include/asm/elf.h\n@@ -121,10 +121,10 @@ typedef struct user_fpsimd_state elf_fpregset_t;\n \n /*\n * This is the base location for PIE (ET_DYN with INTERP) loads. On\n- * 64-bit, this is raised to 4GB to leave the entire 32-bit address\n+ * 64-bit, this is above 4GB to leave the entire 32-bit address\n * space open for things that want to use the area for 32-bit pointers.\n */\n-#define ELF_ET_DYN_BASE\t\t0x100000000UL\n+#define ELF_ET_DYN_BASE\t\t(2 * TASK_SIZE_64 / 3)\n \n /*\n * When the program starts, a1 contains a pointer to a function to be\ndiff --git a/arch/x86/include/asm/elf.h b/arch/x86/include/asm/elf.h\nindex 07cf288b692e..bcd3d6199464 100644\n--- a/arch/x86/include/asm/elf.h\n+++ b/arch/x86/include/asm/elf.h\n@@ -247,11 +247,11 @@ extern int force_personality32;\n \n /*\n * This is the base location for PIE (ET_DYN with INTERP) loads. On\n- * 64-bit, this is raised to 4GB to leave the entire 32-bit address\n+ * 64-bit, this is above 4GB to leave the entire 32-bit address\n * space open for things that want to use the area for 32-bit pointers.\n */\n #define ELF_ET_DYN_BASE\t\t(mmap_is_ia32() ? 0x000400000UL : \\\n-\t\t\t\t\t\t 0x100000000UL)\n+\t\t\t\t\t\t (TASK_SIZE / 3 * 2))\n \n /* This yields a mask that user programs can use to figure out what\n instruction set this CPU supports. This could be done in user space,\n", "prefixes": [ "Xenial", "SRU", "1/1" ] }