Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 810963,
    "url": "http://patchwork.ozlabs.org/api/patches/810963/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/150478201163.24662.6473874525961508125.stgit@anamdev.jf.intel.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<150478201163.24662.6473874525961508125.stgit@anamdev.jf.intel.com>",
    "list_archive_url": null,
    "date": "2017-09-07T11:00:11",
    "name": "[RFC,v3,2/6] i40e: Add macro for PF reset bit",
    "commit_ref": null,
    "pull_url": null,
    "state": "rfc",
    "archived": true,
    "hash": "04b2dd1f3ad03b75ebcf7010ab6ffd28c1058b21",
    "submitter": {
        "id": 68504,
        "url": "http://patchwork.ozlabs.org/api/people/68504/?format=api",
        "name": "Nambiar, Amritha",
        "email": "amritha.nambiar@intel.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/150478201163.24662.6473874525961508125.stgit@anamdev.jf.intel.com/mbox/",
    "series": [
        {
            "id": 1978,
            "url": "http://patchwork.ozlabs.org/api/series/1978/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=1978",
            "date": "2017-09-07T11:00:01",
            "name": "Configuring traffic classes via new hardware offload mechanism in tc/mqprio",
            "version": 3,
            "mbox": "http://patchwork.ozlabs.org/series/1978/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/810963/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/810963/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnyF102G6z9s7C\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu,  7 Sep 2017 21:01:25 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754930AbdIGLBX (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 7 Sep 2017 07:01:23 -0400",
            "from mga14.intel.com ([192.55.52.115]:52692 \"EHLO mga14.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1754745AbdIGLBW (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tThu, 7 Sep 2017 07:01:22 -0400",
            "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Sep 2017 04:01:21 -0700",
            "from anamdev.jf.intel.com ([10.166.29.110])\n\tby FMSMGA003.fm.intel.com with ESMTP; 07 Sep 2017 04:01:16 -0700"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.42,357,1500966000\"; d=\"scan'208\";a=\"897990576\"",
        "Subject": "[RFC PATCH v3 2/6] i40e: Add macro for PF reset bit",
        "From": "Amritha Nambiar <amritha.nambiar@intel.com>",
        "To": "intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com",
        "Cc": "alexander.h.duyck@intel.com, netdev@vger.kernel.org,\n\tamritha.nambiar@intel.com",
        "Date": "Thu, 07 Sep 2017 04:00:11 -0700",
        "Message-ID": "<150478201163.24662.6473874525961508125.stgit@anamdev.jf.intel.com>",
        "In-Reply-To": "<150478158684.24662.17975701233699487888.stgit@anamdev.jf.intel.com>",
        "References": "<150478158684.24662.17975701233699487888.stgit@anamdev.jf.intel.com>",
        "User-Agent": "StGit/0.17.1-dirty",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=\"utf-8\"",
        "Content-Transfer-Encoding": "7bit",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "Introduce a macro for the bit setting the PF reset flag and\nupdate its usages. This makes it easier to use this flag\nin functions to be introduced in future without encountering\ncheckpatch issues related to alignment and line over 80\ncharacters.\n\nSigned-off-by: Amritha Nambiar <amritha.nambiar@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e.h             |    2 ++\n drivers/net/ethernet/intel/i40e/i40e_debugfs.c     |    3 +--\n drivers/net/ethernet/intel/i40e/i40e_main.c        |    9 ++++-----\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c |    5 ++---\n 4 files changed, 9 insertions(+), 10 deletions(-)",
    "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h\nindex 18c453a..d414adc 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e.h\n@@ -157,6 +157,8 @@ enum i40e_state_t {\n \t__I40E_STATE_SIZE__,\n };\n \n+#define I40E_PF_RESET_FLAG\tBIT_ULL(__I40E_PF_RESET_REQUESTED)\n+\n /* VSI state flags */\n enum i40e_vsi_state_t {\n \t__I40E_VSI_DOWN,\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\nindex 6f2725f..2b8bbc8 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n@@ -798,8 +798,7 @@ static ssize_t i40e_dbg_command_write(struct file *filp,\n \t\t */\n \t\tif (!(pf->flags & I40E_FLAG_VEB_MODE_ENABLED)) {\n \t\t\tpf->flags |= I40E_FLAG_VEB_MODE_ENABLED;\n-\t\t\ti40e_do_reset_safe(pf,\n-\t\t\t\t\t   BIT_ULL(__I40E_PF_RESET_REQUESTED));\n+\t\t\ti40e_do_reset_safe(pf, I40E_PF_RESET_FLAG);\n \t\t}\n \n \t\tvsi = i40e_vsi_setup(pf, I40E_VSI_VMDQ2, vsi_seid, 0);\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 76b03f7..2fdb99f 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -5753,7 +5753,7 @@ int i40e_vsi_open(struct i40e_vsi *vsi)\n err_setup_tx:\n \ti40e_vsi_free_tx_resources(vsi);\n \tif (vsi == pf->vsi[pf->lan_vsi])\n-\t\ti40e_do_reset(pf, BIT_ULL(__I40E_PF_RESET_REQUESTED), true);\n+\t\ti40e_do_reset(pf, I40E_PF_RESET_FLAG, true);\n \n \treturn err;\n }\n@@ -5881,7 +5881,7 @@ void i40e_do_reset(struct i40e_pf *pf, u32 reset_flags, bool lock_acquired)\n \t\twr32(&pf->hw, I40E_GLGEN_RTRIG, val);\n \t\ti40e_flush(&pf->hw);\n \n-\t} else if (reset_flags & BIT_ULL(__I40E_PF_RESET_REQUESTED)) {\n+\t} else if (reset_flags & I40E_PF_RESET_FLAG) {\n \n \t\t/* Request a PF Reset\n \t\t *\n@@ -9229,7 +9229,7 @@ static int i40e_set_features(struct net_device *netdev,\n \tneed_reset = i40e_set_ntuple(pf, features);\n \n \tif (need_reset)\n-\t\ti40e_do_reset(pf, BIT_ULL(__I40E_PF_RESET_REQUESTED), true);\n+\t\ti40e_do_reset(pf, I40E_PF_RESET_FLAG, true);\n \n \treturn 0;\n }\n@@ -9481,8 +9481,7 @@ static int i40e_ndo_bridge_setlink(struct net_device *dev,\n \t\t\t\tpf->flags |= I40E_FLAG_VEB_MODE_ENABLED;\n \t\t\telse\n \t\t\t\tpf->flags &= ~I40E_FLAG_VEB_MODE_ENABLED;\n-\t\t\ti40e_do_reset(pf, BIT_ULL(__I40E_PF_RESET_REQUESTED),\n-\t\t\t\t      true);\n+\t\t\ti40e_do_reset(pf, I40E_PF_RESET_FLAG, true);\n \t\t\tbreak;\n \t\t}\n \t}\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 8bedc74c..ac88d96 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -1424,8 +1424,7 @@ int i40e_pci_sriov_configure(struct pci_dev *pdev, int num_vfs)\n \tif (num_vfs) {\n \t\tif (!(pf->flags & I40E_FLAG_VEB_MODE_ENABLED)) {\n \t\t\tpf->flags |= I40E_FLAG_VEB_MODE_ENABLED;\n-\t\t\ti40e_do_reset_safe(pf,\n-\t\t\t\t\t   BIT_ULL(__I40E_PF_RESET_REQUESTED));\n+\t\t\ti40e_do_reset_safe(pf, I40E_PF_RESET_FLAG);\n \t\t}\n \t\treturn i40e_pci_sriov_enable(pdev, num_vfs);\n \t}\n@@ -1433,7 +1432,7 @@ int i40e_pci_sriov_configure(struct pci_dev *pdev, int num_vfs)\n \tif (!pci_vfs_assigned(pf->pdev)) {\n \t\ti40e_free_vfs(pf);\n \t\tpf->flags &= ~I40E_FLAG_VEB_MODE_ENABLED;\n-\t\ti40e_do_reset_safe(pf, BIT_ULL(__I40E_PF_RESET_REQUESTED));\n+\t\ti40e_do_reset_safe(pf, I40E_PF_RESET_FLAG);\n \t} else {\n \t\tdev_warn(&pdev->dev, \"Unable to free VFs because some are assigned to VMs.\\n\");\n \t\treturn -EINVAL;\n",
    "prefixes": [
        "RFC",
        "v3",
        "2/6"
    ]
}