Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/810760/?format=api
{ "id": 810760, "url": "http://patchwork.ozlabs.org/api/patches/810760/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170906184133.25524-2-dgilbert@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170906184133.25524-2-dgilbert@redhat.com>", "list_archive_url": null, "date": "2017-09-06T18:41:26", "name": "[PULL,1/8] migration: Report when bdrv_inactivate_all fails", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "fad9938017365d369049de6e10bb4b646163e73d", "submitter": { "id": 48102, "url": "http://patchwork.ozlabs.org/api/people/48102/?format=api", "name": "Dr. David Alan Gilbert", "email": "dgilbert@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170906184133.25524-2-dgilbert@redhat.com/mbox/", "series": [ { "id": 1865, "url": "http://patchwork.ozlabs.org/api/series/1865/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1865", "date": "2017-09-06T18:41:26", "name": "[PULL,1/8] migration: Report when bdrv_inactivate_all fails", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1865/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/810760/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/810760/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=dgilbert@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnXWT3cpsz9sRY\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 7 Sep 2017 04:42:28 +1000 (AEST)", "from localhost ([::1]:37465 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dpfHN-00030K-Va\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 14:42:26 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:57638)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <dgilbert@redhat.com>) id 1dpfGk-0002z3-Sj\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 14:41:47 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <dgilbert@redhat.com>) id 1dpfGg-0001bR-Cn\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 14:41:46 -0400", "from mx1.redhat.com ([209.132.183.28]:56876)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <dgilbert@redhat.com>) id 1dpfGg-0001a6-73\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 14:41:42 -0400", "from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 36C5B81DEF\n\tfor <qemu-devel@nongnu.org>; Wed, 6 Sep 2017 18:41:41 +0000 (UTC)", "from dgilbert-t530.redhat.com (ovpn-117-207.ams2.redhat.com\n\t[10.36.117.207])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E04955D6A4;\n\tWed, 6 Sep 2017 18:41:39 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 36C5B81DEF", "From": "\"Dr. David Alan Gilbert (git)\" <dgilbert@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 6 Sep 2017 19:41:26 +0100", "Message-Id": "<20170906184133.25524-2-dgilbert@redhat.com>", "In-Reply-To": "<20170906184133.25524-1-dgilbert@redhat.com>", "References": "<20170906184133.25524-1-dgilbert@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tWed, 06 Sep 2017 18:41:41 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PULL 1/8] migration: Report when bdrv_inactivate_all\n\tfails", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "kwolf@redhat.com, armbru@redhat.com, peterx@redhat.com,\n\tquintela@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: \"Dr. David Alan Gilbert\" <dgilbert@redhat.com>\n\nIf the bdrv_inactivate_all fails near the end of the migration,\nthe migration will fail and often the only diagnostics in the log\nare an I/O error which you can't distinguish from an error on\nthe socket connection.\n\nAdd an error so we know when it's actually a block problem.\n\nSigned-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>\nMessage-Id: <20170822170212.27347-1-dgilbert@redhat.com>\nReviewed-by: Peter Xu <peterx@redhat.com>\nReviewed-by: Stefan Hajnoczi <stefanha@redhat.com>\nSigned-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>\n---\n migration/savevm.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/migration/savevm.c b/migration/savevm.c\nindex fdd15fa0a7..7a55023d1a 100644\n--- a/migration/savevm.c\n+++ b/migration/savevm.c\n@@ -1157,6 +1157,8 @@ int qemu_savevm_state_complete_precopy(QEMUFile *f, bool iterable_only,\n * bdrv_invalidate_cache_all() on the other end won't fail. */\n ret = bdrv_inactivate_all();\n if (ret) {\n+ error_report(\"%s: bdrv_inactivate_all() failed (%d)\",\n+ __func__, ret);\n qemu_file_set_error(f, ret);\n return ret;\n }\n", "prefixes": [ "PULL", "1/8" ] }