Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/810704/?format=api
{ "id": 810704, "url": "http://patchwork.ozlabs.org/api/patches/810704/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170906160612.22769-6-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170906160612.22769-6-richard.henderson@linaro.org>", "list_archive_url": null, "date": "2017-09-06T16:05:45", "name": "[PULL,05/32] target/arm: Delay check for magic kernel page", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c88e0b3e15237334e2c8f45b6f088620504e715f", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170906160612.22769-6-richard.henderson@linaro.org/mbox/", "series": [ { "id": 1847, "url": "http://patchwork.ozlabs.org/api/series/1847/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1847", "date": "2017-09-06T16:05:41", "name": "[PULL,01/32] tcg: Add generic DISAS_NORETURN", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1847/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/810704/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/810704/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"SofYr54n\"; dkim-atps=neutral" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnTFc2Rmvz9s7F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 7 Sep 2017 02:15:16 +1000 (AEST)", "from localhost ([::1]:36987 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dpcyw-0007CY-EV\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 12:15:14 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:41649)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1dpcqV-0008Qv-Sa\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 12:06:41 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1dpcqM-0001eo-GW\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 12:06:31 -0400", "from mail-pg0-x22a.google.com ([2607:f8b0:400e:c05::22a]:33604)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <richard.henderson@linaro.org>)\n\tid 1dpcqM-0001cE-B5\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 12:06:22 -0400", "by mail-pg0-x22a.google.com with SMTP id t3so16077697pgt.0\n\tfor <qemu-devel@nongnu.org>; Wed, 06 Sep 2017 09:06:22 -0700 (PDT)", "from bigtime.twiddle.net (97-126-108-236.tukw.qwest.net.\n\t[97.126.108.236]) by smtp.gmail.com with ESMTPSA id\n\tt65sm262863pfk.59.2017.09.06.09.06.19\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 06 Sep 2017 09:06:20 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=1QHcEjTLfMJkurWFMJ47TbFcFe8SFh914sj8uv7xMjI=;\n\tb=SofYr54nbQCV9eS2oWNzTNAYVRZ26dCZjaHxVYWWKjaPDKn4ijjXWS1ZXHqrovUKqa\n\tHvt0PMafPddB+nd1GkLSMwcMnYJ+iShsL2JO7tWfKJe+Ih7/y9SLsqgEd5ErFZQzUElq\n\ti+b6nswquSptT6NDSUTqjHrUZzFcSqQWEccrA=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=1QHcEjTLfMJkurWFMJ47TbFcFe8SFh914sj8uv7xMjI=;\n\tb=gBfTnW0MqAUrL9lRLQZ2chlkFLtYEfGgwxe+Ohap6thveDeZq3lTFnIgz4dumgtc/P\n\txy+GUI9f/07iN5GdWdPCtgqTxgpl7ko+//itRxE5iLs5q6tcBSfKxqlDD24EPZSr3ZaK\n\tWm30hiBALA8/ZFCXe5qDGy997vgpYSV2MbBO/YTf62XJuijJYyyEOKaOTxtEzfnWLzAv\n\tWPhBg9tHkqydzkRPLaUFi9jaX2/TsBOM4jlLzqNQvqnOhGoUavIh5qMrpHca91/QrRPV\n\tsI25crqFlZocWN4bnW4QKChLvWPRrGu012m+87ScGZ7DOR48DxfGqcxUvLeFZHS9p6mY\n\tJ81Q==", "X-Gm-Message-State": "AHPjjUiIPuU07hCuJVrYJdkCg9qS2+xl0/pZJK2q5+XAViD8rf8IUD5H\n\tDcIwUM9qISKaX9ZJb+GMTA==", "X-Google-Smtp-Source": "ADKCNb4S7XhQ9jn9INySl5t7PFFrCW4IbZkG7YqWrkOVzuJUMoQJ6FJRIcS7D6wzFi26hHSXrDW2cQ==", "X-Received": "by 10.99.109.142 with SMTP id i136mr8071762pgc.353.1504713981117;\n\tWed, 06 Sep 2017 09:06:21 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 6 Sep 2017 09:05:45 -0700", "Message-Id": "<20170906160612.22769-6-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.13.5", "In-Reply-To": "<20170906160612.22769-1-richard.henderson@linaro.org>", "References": "<20170906160612.22769-1-richard.henderson@linaro.org>", "X-detected-operating-system": "by eggs.gnu.org: Genre and OS details not\n\trecognized.", "X-Received-From": "2607:f8b0:400e:c05::22a", "Subject": "[Qemu-devel] [PULL 05/32] target/arm: Delay check for magic kernel\n\tpage", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "peter.maydell@linaro.org, Richard Henderson <rth@twiddle.net>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Richard Henderson <rth@twiddle.net>\n\nThere's nothing magic about the exception that we generate in order\nto execute the magic kernel page. We can and should allow gdb to\nset a breakpoint at this location.\n\nReviewed-by: Emilio G. Cota <cota@braap.org>\nSigned-off-by: Richard Henderson <rth@twiddle.net>\n---\n target/arm/translate.c | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/target/arm/translate.c b/target/arm/translate.c\nindex 0c39c2b996..746193eebc 100644\n--- a/target/arm/translate.c\n+++ b/target/arm/translate.c\n@@ -11968,17 +11968,6 @@ void gen_intermediate_code(CPUState *cs, TranslationBlock *tb)\n 0);\n num_insns++;\n \n-#ifdef CONFIG_USER_ONLY\n- /* Intercept jump to the magic kernel page. */\n- if (dc->pc >= 0xffff0000) {\n- /* We always get here via a jump, so know we are not in a\n- conditional execution block. */\n- gen_exception_internal(EXCP_KERNEL_TRAP);\n- dc->is_jmp = DISAS_NORETURN;\n- break;\n- }\n-#endif\n-\n if (unlikely(!QTAILQ_EMPTY(&cs->breakpoints))) {\n CPUBreakpoint *bp;\n QTAILQ_FOREACH(bp, &cs->breakpoints, entry) {\n@@ -12010,6 +11999,17 @@ void gen_intermediate_code(CPUState *cs, TranslationBlock *tb)\n gen_io_start();\n }\n \n+#ifdef CONFIG_USER_ONLY\n+ /* Intercept jump to the magic kernel page. */\n+ if (dc->pc >= 0xffff0000) {\n+ /* We always get here via a jump, so know we are not in a\n+ conditional execution block. */\n+ gen_exception_internal(EXCP_KERNEL_TRAP);\n+ dc->is_jmp = DISAS_NORETURN;\n+ break;\n+ }\n+#endif\n+\n if (dc->ss_active && !dc->pstate_ss) {\n /* Singlestep state is Active-pending.\n * If we're in this state at the start of a TB then either\n", "prefixes": [ "PULL", "05/32" ] }