Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/810672/?format=api
{ "id": 810672, "url": "http://patchwork.ozlabs.org/api/patches/810672/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170906152111.16958-4-eblake@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170906152111.16958-4-eblake@redhat.com>", "list_archive_url": null, "date": "2017-09-06T15:21:09", "name": "[PULL,3/5] io: Yield rather than wait when already in coroutine", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "fd045d3d9bf99b04b70911b125668107c392763e", "submitter": { "id": 6591, "url": "http://patchwork.ozlabs.org/api/people/6591/?format=api", "name": "Eric Blake", "email": "eblake@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170906152111.16958-4-eblake@redhat.com/mbox/", "series": [ { "id": 1834, "url": "http://patchwork.ozlabs.org/api/series/1834/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1834", "date": "2017-09-06T15:21:06", "name": "[PULL,1/5] iotests: rewrite 192 to use _launch_qemu to fix LUKS support", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1834/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/810672/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/810672/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnS4W6M5Pz9t50\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 7 Sep 2017 01:22:19 +1000 (AEST)", "from localhost ([::1]:36693 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dpc9h-0004LH-TN\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 11:22:17 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:53872)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <eblake@redhat.com>) id 1dpc8w-0004Ax-Sg\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:21:34 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <eblake@redhat.com>) id 1dpc8q-0006xr-TS\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:21:30 -0400", "from mx1.redhat.com ([209.132.183.28]:29162)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <eblake@redhat.com>) id 1dpc8q-0006xL-N2\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:21:24 -0400", "from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C5176883D6\n\tfor <qemu-devel@nongnu.org>; Wed, 6 Sep 2017 15:21:23 +0000 (UTC)", "from red.redhat.com (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id DBD8587801;\n\tWed, 6 Sep 2017 15:21:22 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com C5176883D6", "From": "Eric Blake <eblake@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 6 Sep 2017 10:21:09 -0500", "Message-Id": "<20170906152111.16958-4-eblake@redhat.com>", "In-Reply-To": "<20170906152111.16958-1-eblake@redhat.com>", "References": "<20170906152111.16958-1-eblake@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tWed, 06 Sep 2017 15:21:23 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PULL 3/5] io: Yield rather than wait when already in\n\tcoroutine", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "The new qio_channel_{read,write}{,v}_all functions are documented\nas yielding until data is available. When used on a blocking\nchannel, this yield is done via qio_channel_wait() which spawns\na nested event loop under the hood (so it is that secondary loop\nwhich yields as needed); but if we are already in a coroutine (at\nwhich point QIO_CHANNEL_ERR_BLOCK is only possible if we are a\nnon-blocking channel), we want to yield the current coroutine\ninstead of spawning a nested event loop.\n\nSigned-off-by: Eric Blake <eblake@redhat.com>\nMessage-Id: <20170905191114.5959-2-eblake@redhat.com>\nAcked-by: Daniel P. Berrange <berrange@redhat.com>\n[commit message updated]\nSigned-off-by: Eric Blake <eblake@redhat.com>\n---\n io/channel.c | 12 ++++++++++--\n 1 file changed, 10 insertions(+), 2 deletions(-)", "diff": "diff --git a/io/channel.c b/io/channel.c\nindex 5e8c2f0a91..9e62794cab 100644\n--- a/io/channel.c\n+++ b/io/channel.c\n@@ -105,7 +105,11 @@ int qio_channel_readv_all(QIOChannel *ioc,\n ssize_t len;\n len = qio_channel_readv(ioc, local_iov, nlocal_iov, errp);\n if (len == QIO_CHANNEL_ERR_BLOCK) {\n- qio_channel_wait(ioc, G_IO_IN);\n+ if (qemu_in_coroutine()) {\n+ qio_channel_yield(ioc, G_IO_IN);\n+ } else {\n+ qio_channel_wait(ioc, G_IO_IN);\n+ }\n continue;\n } else if (len < 0) {\n goto cleanup;\n@@ -143,7 +147,11 @@ int qio_channel_writev_all(QIOChannel *ioc,\n ssize_t len;\n len = qio_channel_writev(ioc, local_iov, nlocal_iov, errp);\n if (len == QIO_CHANNEL_ERR_BLOCK) {\n- qio_channel_wait(ioc, G_IO_OUT);\n+ if (qemu_in_coroutine()) {\n+ qio_channel_yield(ioc, G_IO_OUT);\n+ } else {\n+ qio_channel_wait(ioc, G_IO_OUT);\n+ }\n continue;\n }\n if (len < 0) {\n", "prefixes": [ "PULL", "3/5" ] }