Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/810664/?format=api
{ "id": 810664, "url": "http://patchwork.ozlabs.org/api/patches/810664/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170906145908.8082-3-tuomas@tuxera.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170906145908.8082-3-tuomas@tuxera.com>", "list_archive_url": null, "date": "2017-09-06T14:59:08", "name": "[2/2] net/9p: Switch to wait_event_killable()", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "0c88231a71038b360d66471f630c36e171d02b99", "submitter": { "id": 70706, "url": "http://patchwork.ozlabs.org/api/people/70706/?format=api", "name": "Tuomas Tynkkynen", "email": "tuomas@tuxera.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170906145908.8082-3-tuomas@tuxera.com/mbox/", "series": [ { "id": 1830, "url": "http://patchwork.ozlabs.org/api/series/1830/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=1830", "date": "2017-09-06T14:59:06", "name": "9p: Fixes for hard-to-hit bugs", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1830/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/810664/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/810664/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnRqQ0D2Rz9t2R\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 7 Sep 2017 01:10:58 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932870AbdIFPKl (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 6 Sep 2017 11:10:41 -0400", "from mx1.mpynet.fi ([82.197.21.84]:42703 \"EHLO mx1.mpynet.fi\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S932263AbdIFPKe (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tWed, 6 Sep 2017 11:10:34 -0400" ], "X-Greylist": "delayed 501 seconds by postgrey-1.27 at vger.kernel.org;\n\tWed, 06 Sep 2017 11:10:32 EDT", "From": "Tuomas Tynkkynen <tuomas@tuxera.com>", "To": "Al Viro <viro@zeniv.linux.org.uk>", "CC": "<v9fs-developer@lists.sourceforge.net>,\n\tEric Van Hensbergen <ericvh@gmail.com>,\n\tRon Minnich <rminnich@sandia.gov>, Latchesar Ionkov <lucho@ionkov.net>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\t<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,\n\t<linux-fsdevel@vger.kernel.org>,\n\tTuomas Tynkkynen <tuomas@tuxera.com>, <stable@vger.kernel.org>", "Subject": "[PATCH 2/2] net/9p: Switch to wait_event_killable()", "Date": "Wed, 6 Sep 2017 17:59:08 +0300", "Message-ID": "<20170906145908.8082-3-tuomas@tuxera.com>", "X-Mailer": "git-send-email 2.13.0", "In-Reply-To": "<20170906145908.8082-1-tuomas@tuxera.com>", "References": "<20170906145908.8082-1-tuomas@tuxera.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-ClientProxiedBy": "tuxera-exch.ad.tuxera.com (10.20.48.11) To\n\ttuxera-exch.ad.tuxera.com (10.20.48.11)", "Received-SPF": "none", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Because userspace gets Very Unhappy when calls like stat() and execve()\nreturn -EINTR on 9p filesystem mounts. For instance, when bash is\nlooking in PATH for things to execute and some SIGCHLD interrupts\nstat(), bash can throw a spurious 'command not found' since it doesn't\nretry the stat().\n\nIn practice, hitting the problem is rare and needs a really\nslow/bogged down 9p server.\n\nCc: stable@vger.kernel.org\nSigned-off-by: Tuomas Tynkkynen <tuomas@tuxera.com>\n---\n net/9p/client.c | 3 +--\n net/9p/trans_virtio.c | 13 ++++++-------\n net/9p/trans_xen.c | 4 ++--\n 3 files changed, 9 insertions(+), 11 deletions(-)", "diff": "diff --git a/net/9p/client.c b/net/9p/client.c\nindex 4674235b0d9b..1beb131dd3e1 100644\n--- a/net/9p/client.c\n+++ b/net/9p/client.c\n@@ -773,8 +773,7 @@ p9_client_rpc(struct p9_client *c, int8_t type, const char *fmt, ...)\n \t}\n again:\n \t/* Wait for the response */\n-\terr = wait_event_interruptible(*req->wq,\n-\t\t\t\t req->status >= REQ_STATUS_RCVD);\n+\terr = wait_event_killable(*req->wq, req->status >= REQ_STATUS_RCVD);\n \n \t/*\n \t * Make sure our req is coherent with regard to updates in other\ndiff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c\nindex f24b25c25106..f3a4efcf1456 100644\n--- a/net/9p/trans_virtio.c\n+++ b/net/9p/trans_virtio.c\n@@ -286,8 +286,8 @@ p9_virtio_request(struct p9_client *client, struct p9_req_t *req)\n \t\tif (err == -ENOSPC) {\n \t\t\tchan->ring_bufs_avail = 0;\n \t\t\tspin_unlock_irqrestore(&chan->lock, flags);\n-\t\t\terr = wait_event_interruptible(*chan->vc_wq,\n-\t\t\t\t\t\t\tchan->ring_bufs_avail);\n+\t\t\terr = wait_event_killable(*chan->vc_wq,\n+\t\t\t\t\t\t chan->ring_bufs_avail);\n \t\t\tif (err == -ERESTARTSYS)\n \t\t\t\treturn err;\n \n@@ -327,7 +327,7 @@ static int p9_get_mapped_pages(struct virtio_chan *chan,\n \t\t * Other zc request to finish here\n \t\t */\n \t\tif (atomic_read(&vp_pinned) >= chan->p9_max_pages) {\n-\t\t\terr = wait_event_interruptible(vp_wq,\n+\t\t\terr = wait_event_killable(vp_wq,\n \t\t\t (atomic_read(&vp_pinned) < chan->p9_max_pages));\n \t\t\tif (err == -ERESTARTSYS)\n \t\t\t\treturn err;\n@@ -471,8 +471,8 @@ p9_virtio_zc_request(struct p9_client *client, struct p9_req_t *req,\n \t\tif (err == -ENOSPC) {\n \t\t\tchan->ring_bufs_avail = 0;\n \t\t\tspin_unlock_irqrestore(&chan->lock, flags);\n-\t\t\terr = wait_event_interruptible(*chan->vc_wq,\n-\t\t\t\t\t\t chan->ring_bufs_avail);\n+\t\t\terr = wait_event_killable(*chan->vc_wq,\n+\t\t\t\t\t\t chan->ring_bufs_avail);\n \t\t\tif (err == -ERESTARTSYS)\n \t\t\t\tgoto err_out;\n \n@@ -489,8 +489,7 @@ p9_virtio_zc_request(struct p9_client *client, struct p9_req_t *req,\n \tvirtqueue_kick(chan->vq);\n \tspin_unlock_irqrestore(&chan->lock, flags);\n \tp9_debug(P9_DEBUG_TRANS, \"virtio request kicked\\n\");\n-\terr = wait_event_interruptible(*req->wq,\n-\t\t\t\t req->status >= REQ_STATUS_RCVD);\n+\terr = wait_event_killable(*req->wq, req->status >= REQ_STATUS_RCVD);\n \t/*\n \t * Non kernel buffers are pinned, unpin them\n \t */\ndiff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c\nindex 6ad3e043c617..325c56043007 100644\n--- a/net/9p/trans_xen.c\n+++ b/net/9p/trans_xen.c\n@@ -156,8 +156,8 @@ static int p9_xen_request(struct p9_client *client, struct p9_req_t *p9_req)\n \tring = &priv->rings[num];\n \n again:\n-\twhile (wait_event_interruptible(ring->wq,\n-\t\t\t\t\tp9_xen_write_todo(ring, size)) != 0)\n+\twhile (wait_event_killable(ring->wq,\n+\t\t\t\t p9_xen_write_todo(ring, size)) != 0)\n \t\t;\n \n \tspin_lock_irqsave(&ring->lock, flags);\n", "prefixes": [ "2/2" ] }