Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/810573/?format=api
{ "id": 810573, "url": "http://patchwork.ozlabs.org/api/patches/810573/?format=api", "web_url": "http://patchwork.ozlabs.org/project/lede/patch/20170906125319.9710-1-toke@toke.dk/", "project": { "id": 54, "url": "http://patchwork.ozlabs.org/api/projects/54/?format=api", "name": "LEDE development", "link_name": "lede", "list_id": "lede-dev.lists.infradead.org", "list_email": "lede-dev@lists.infradead.org", "web_url": "http://lede-project.org/", "scm_url": "", "webscm_url": "http://git.lede-project.org/", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170906125319.9710-1-toke@toke.dk>", "list_archive_url": null, "date": "2017-09-06T12:53:19", "name": "[LEDE-DEV] ath10k: Re-enable intermediate softqueues for all devices", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "869ba6256b567f67775bba58c0325af09a60b069", "submitter": { "id": 63215, "url": "http://patchwork.ozlabs.org/api/people/63215/?format=api", "name": "Toke Høiland-Jørgensen", "email": "toke@toke.dk" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/lede/patch/20170906125319.9710-1-toke@toke.dk/mbox/", "series": [ { "id": 1795, "url": "http://patchwork.ozlabs.org/api/series/1795/?format=api", "web_url": "http://patchwork.ozlabs.org/project/lede/list/?series=1795", "date": "2017-09-06T12:53:19", "name": "[LEDE-DEV] ath10k: Re-enable intermediate softqueues for all devices", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1795/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/810573/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/810573/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"qh5pnCEd\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tsecure) header.d=toke.dk header.i=@toke.dk header.b=\"n9cocUmN\";\n\tdkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnNq60Kp9z9t2R\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 6 Sep 2017 22:55:30 +1000 (AEST)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dpZrR-0006mx-Pc; Wed, 06 Sep 2017 12:55:17 +0000", "from mail.toke.dk ([52.28.52.200])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dpZrH-0005LR-Lg\n\tfor lede-dev@lists.infradead.org; Wed, 06 Sep 2017 12:55:15 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Subject:MIME-Version:Message-Id:Date:To\n\t:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:\n\tList-Owner; bh=r7ulyD5bckoi6+Ormyd++16YQTWokaqXuM8jTnHSMlc=;\n\tb=qh5pnCEdFBgLHE\n\tRSGqXD0ngRF5feIR7ds9otRcdKC/63e0zssV9jhv/03DEnLOLLzCvhy0TIn/qJLkEuSZla0OCdI91\n\tT52Ud4Ic9jrxSXq9kWkEy7FGBQQMMFHla7Zpe/YzhIUGrkh8RBc7BdYXdFhiuHDnpPiCJkfhJ0XOI\n\tDzHgNFzAmAvys8qsFX/5Tn3irvzqIn3EDrJqPhdKs9UZSRou3d+b0exR7sIwQLVwEeHVELFyB+M0b\n\tN2QZpqo21HGtuOWuvyizt6WO2u9AOLOPTUHoz/cwUUJ517ikC0/6U0eQMf6ue2z3MXwKNOKM0lj7n\n\tuMXUUVotLvDD9oeyrUCA==;", "v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; \n\tt=1504702476; bh=VPPL8WeLkFAOKr+xDyo/mh9MdfKbplFmwqAiKbzBEqY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=n9cocUmNXceEjBafnamMd5lbQ3xIXfrTdiZcvuHWam6xybe3ZxWrEWu6lYv44pNGW\n\tdgMXW0j43RynEVpqOMn2DEVMIjZ97rxBqsMyElfkqqgNc0TklCTeZA8/I1RZ8uJgWr\n\t8h16v+xQS7XzRe4UtZA6KvpS0rOHIRjOvFQLjEVxXbJMBmLNlwukDvf2cxOgCYO39P\n\taB6Eo5X9jvpbluZqAG5I/nM31f2NdZb/ATFgmtLc13HzZZxJCaFMqO1TKLewUWd19Q\n\teHZaRq34AGjW1LX4Jh0CL59NEK9FhtitHntusqAaF2YlkmyjzdBLVR3psJt5nddwpF\n\tyKk6CbA32RVxg==" ], "From": "=?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>", "To": "lede-dev@lists.infradead.org", "Date": "Wed, 6 Sep 2017 14:53:19 +0200", "Message-Id": "<20170906125319.9710-1-toke@toke.dk>", "MIME-Version": "1.0", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20170906_055508_838297_0EB430F6 ", "X-CRM114-Status": "GOOD ( 10.29 )", "X-Spam-Score": "-2.0 (--)", "X-Spam-Report": "SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain", "Subject": "[LEDE-DEV] [PATCH] ath10k: Re-enable intermediate softqueues for\n\tall devices", "X-BeenThere": "lede-dev@lists.infradead.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<lede-dev.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/lede-dev/>", "List-Post": "<mailto:lede-dev@lists.infradead.org>", "List-Help": "<mailto:lede-dev-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/lede-dev>,\n\t<mailto:lede-dev-request@lists.infradead.org?subject=subscribe>", "Cc": "=?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Sender": "\"Lede-dev\" <lede-dev-bounces@lists.infradead.org>", "Errors-To": "lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "The upstream ath10k driver disables the intermediate softqueues for some\ndevices. This patch reverts that behaviour and always enables the\nsoftqueues (and associated bufferbloat fixes). We have had reports of people\nrunning this with good results:\nhttps://lists.bufferbloat.net/pipermail/make-wifi-fast/2017-September/001497.html\n\nThis also refreshes mac80211 patches.\n\nSigned-off-by: Toke Høiland-Jørgensen <toke@toke.dk>\n---\n ...t-disable-wake_tx_queue-for-older-devices.patch | 27 ++++++++++++++++++++++\n .../patches/930-ath10k_add_tpt_led_trigger.patch | 4 ++--\n 2 files changed, 29 insertions(+), 2 deletions(-)\n create mode 100644 package/kernel/mac80211/patches/332-ath10k-Revert-disable-wake_tx_queue-for-older-devices.patch", "diff": "diff --git a/package/kernel/mac80211/patches/332-ath10k-Revert-disable-wake_tx_queue-for-older-devices.patch b/package/kernel/mac80211/patches/332-ath10k-Revert-disable-wake_tx_queue-for-older-devices.patch\nnew file mode 100644\nindex 0000000000..b4e7862264\n--- /dev/null\n+++ b/package/kernel/mac80211/patches/332-ath10k-Revert-disable-wake_tx_queue-for-older-devices.patch\n@@ -0,0 +1,27 @@\n+From 59f8c22bf1749c4a2b5947bfaebc677c259a1ad6 Mon Sep 17 00:00:00 2001\n+From: dave taht <dave@taht.net>\n+Date: Wed, 5 Oct 2016 20:09:15 -0700\n+Subject: [PATCH 5/7] Revert \"ath10k: disable wake_tx_queue for older devices\"\n+\n+This reverts commit 4ca1807815aa6801aaced7fdefa9edacc2521767\n+in the hope that we've fixed all the performance problems now.\n+---\n+\n+--- a/drivers/net/wireless/ath/ath10k/mac.c\n++++ b/drivers/net/wireless/ath/ath10k/mac.c\n+@@ -8219,15 +8219,6 @@ int ath10k_mac_register(struct ath10k *a\n+ \t\t\tath10k_warn(ar, \"failed to initialise DFS pattern detector\\n\");\n+ \t}\n+ \n+-\t/* Current wake_tx_queue implementation imposes a significant\n+-\t * performance penalty in some setups. The tx scheduling code needs\n+-\t * more work anyway so disable the wake_tx_queue unless firmware\n+-\t * supports the pull-push mechanism.\n+-\t */\n+-\tif (!test_bit(ATH10K_FW_FEATURE_PEER_FLOW_CONTROL,\n+-\t\t ar->running_fw->fw_file.fw_features))\n+-\t\tar->ops->wake_tx_queue = NULL;\n+-\n+ \tret = ath10k_mac_init_rd(ar);\n+ \tif (ret) {\n+ \t\tath10k_err(ar, \"failed to derive regdom: %d\\n\", ret);\ndiff --git a/package/kernel/mac80211/patches/930-ath10k_add_tpt_led_trigger.patch b/package/kernel/mac80211/patches/930-ath10k_add_tpt_led_trigger.patch\nindex 4cf1b9f92a..6137a50bcf 100644\n--- a/package/kernel/mac80211/patches/930-ath10k_add_tpt_led_trigger.patch\n+++ b/package/kernel/mac80211/patches/930-ath10k_add_tpt_led_trigger.patch\n@@ -1,6 +1,6 @@\n --- a/drivers/net/wireless/ath/ath10k/mac.c\n +++ b/drivers/net/wireless/ath/ath10k/mac.c\n-@@ -8003,6 +8003,21 @@ static int ath10k_mac_init_rd(struct ath\n+@@ -8007,6 +8007,21 @@ static int ath10k_mac_init_rd(struct ath\n \treturn 0;\n }\n \n@@ -22,7 +22,7 @@\n int ath10k_mac_register(struct ath10k *ar)\n {\n \tstatic const u32 cipher_suites[] = {\n-@@ -8248,6 +8263,12 @@ int ath10k_mac_register(struct ath10k *a\n+@@ -8244,6 +8259,12 @@ int ath10k_mac_register(struct ath10k *a\n \tar->hw->wiphy->cipher_suites = cipher_suites;\n \tar->hw->wiphy->n_cipher_suites = ARRAY_SIZE(cipher_suites);\n \n", "prefixes": [ "LEDE-DEV" ] }