Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 810570,
    "url": "http://patchwork.ozlabs.org/api/patches/810570/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20170906124757.13934-1-fw@strlen.de/",
    "project": {
        "id": 26,
        "url": "http://patchwork.ozlabs.org/api/projects/26/?format=api",
        "name": "Netfilter Development",
        "link_name": "netfilter-devel",
        "list_id": "netfilter-devel.vger.kernel.org",
        "list_email": "netfilter-devel@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20170906124757.13934-1-fw@strlen.de>",
    "list_archive_url": null,
    "date": "2017-09-06T12:47:57",
    "name": "[nf] netfilter: core: remove erroneous warn_on",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "c656feeb1bc6cefc004cba44a81c7f7475942dcc",
    "submitter": {
        "id": 1025,
        "url": "http://patchwork.ozlabs.org/api/people/1025/?format=api",
        "name": "Florian Westphal",
        "email": "fw@strlen.de"
    },
    "delegate": {
        "id": 6139,
        "url": "http://patchwork.ozlabs.org/api/users/6139/?format=api",
        "username": "pablo",
        "first_name": "Pablo",
        "last_name": "Neira",
        "email": "pablo@netfilter.org"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20170906124757.13934-1-fw@strlen.de/mbox/",
    "series": [
        {
            "id": 1792,
            "url": "http://patchwork.ozlabs.org/api/series/1792/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=1792",
            "date": "2017-09-06T12:47:57",
            "name": "[nf] netfilter: core: remove erroneous warn_on",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/1792/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/810570/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/810570/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netfilter-devel-owner@vger.kernel.org>",
        "X-Original-To": "incoming@patchwork.ozlabs.org",
        "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnNf419xpz9sBd\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed,  6 Sep 2017 22:47:40 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753574AbdIFMrj (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 6 Sep 2017 08:47:39 -0400",
            "from Chamillionaire.breakpoint.cc ([146.0.238.67]:34952 \"EHLO\n\tChamillionaire.breakpoint.cc\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1753484AbdIFMri (ORCPT\n\t<rfc822;netfilter-devel@vger.kernel.org>);\n\tWed, 6 Sep 2017 08:47:38 -0400",
            "from fw by Chamillionaire.breakpoint.cc with local (Exim 4.84_2)\n\t(envelope-from <fw@breakpoint.cc>)\n\tid 1dpZhC-0001MN-V4; Wed, 06 Sep 2017 14:44:43 +0200"
        ],
        "From": "Florian Westphal <fw@strlen.de>",
        "To": "<netfilter-devel@vger.kernel.org>",
        "Cc": "Florian Westphal <fw@strlen.de>",
        "Subject": "[PATCH nf] netfilter: core: remove erroneous warn_on",
        "Date": "Wed,  6 Sep 2017 14:47:57 +0200",
        "Message-Id": "<20170906124757.13934-1-fw@strlen.de>",
        "X-Mailer": "git-send-email 2.13.0",
        "Sender": "netfilter-devel-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netfilter-devel.vger.kernel.org>",
        "X-Mailing-List": "netfilter-devel@vger.kernel.org"
    },
    "content": "kernel test robot reported:\n\nWARNING: CPU: 0 PID: 1244 at net/netfilter/core.c:218 __nf_hook_entries_try_shrink+0x49/0xcd\n[..]\n\nAfter allowing batching in nf_unregister_net_hooks its possible that an earlier\ncall to __nf_hook_entries_try_shrink already compacted the list.\nIf this happens we don't need to do anything.\n\nFixes: d3ad2c17b4047 (\"netfilter: core: batch nf_unregister_net_hooks synchronize_net calls\")\nReported-by: kernel test robot <xiaolong.ye@intel.com>\nSigned-off-by: Florian Westphal <fw@strlen.de>\n---\n net/netfilter/core.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/net/netfilter/core.c b/net/netfilter/core.c\nindex 04fe25abc5f6..52cd2901a097 100644\n--- a/net/netfilter/core.c\n+++ b/net/netfilter/core.c\n@@ -215,7 +215,7 @@ static void *__nf_hook_entries_try_shrink(struct nf_hook_entries __rcu **pp)\n \tif (skip == hook_entries)\n \t\tgoto out_assign;\n \n-\tif (WARN_ON(skip == 0))\n+\tif (skip == 0)\n \t\treturn NULL;\n \n \thook_entries -= skip;\n",
    "prefixes": [
        "nf"
    ]
}