Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/810545/?format=api
{ "id": 810545, "url": "http://patchwork.ozlabs.org/api/patches/810545/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170906115143.27451-11-quintela@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170906115143.27451-11-quintela@redhat.com>", "list_archive_url": null, "date": "2017-09-06T11:51:31", "name": "[v7,10/22] migration: Create x-multifd-threads parameter", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1a27eb0f76db7c8c00ee99146c0ddbe0c5919350", "submitter": { "id": 2643, "url": "http://patchwork.ozlabs.org/api/people/2643/?format=api", "name": "Juan Quintela", "email": "quintela@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170906115143.27451-11-quintela@redhat.com/mbox/", "series": [ { "id": 1773, "url": "http://patchwork.ozlabs.org/api/series/1773/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1773", "date": "2017-09-06T11:51:21", "name": "Multifd", "version": 7, "mbox": "http://patchwork.ozlabs.org/series/1773/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/810545/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/810545/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=quintela@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnMdl35JSz9s81\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 6 Sep 2017 22:02:19 +1000 (AEST)", "from localhost ([::1]:35650 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dpZ29-0007Hq-H4\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 08:02:17 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:60251)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <quintela@redhat.com>) id 1dpYsR-0007U4-WB\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 07:52:22 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <quintela@redhat.com>) id 1dpYsQ-00084B-Hv\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 07:52:16 -0400", "from mx1.redhat.com ([209.132.183.28]:33046)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <quintela@redhat.com>) id 1dpYsQ-00083p-9Y\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 07:52:14 -0400", "from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4C4A185376\n\tfor <qemu-devel@nongnu.org>; Wed, 6 Sep 2017 11:52:13 +0000 (UTC)", "from secure.mitica (ovpn-117-188.ams2.redhat.com [10.36.117.188])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id CF00A5B818;\n\tWed, 6 Sep 2017 11:52:11 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 4C4A185376", "From": "Juan Quintela <quintela@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Wed, 6 Sep 2017 13:51:31 +0200", "Message-Id": "<20170906115143.27451-11-quintela@redhat.com>", "In-Reply-To": "<20170906115143.27451-1-quintela@redhat.com>", "References": "<20170906115143.27451-1-quintela@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tWed, 06 Sep 2017 11:52:13 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v7 10/22] migration: Create x-multifd-threads\n\tparameter", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "lvivier@redhat.com, dgilbert@redhat.com, peterx@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Indicates the number of threads that we would create. By default we\ncreate 2 threads.\n\nSigned-off-by: Juan Quintela <quintela@redhat.com>\nReviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>\nReviewed-by: Peter Xu <peterx@redhat.com>\n\n--\n\nCatch inconsistent defaults (eric).\nImprove comment stating that number of threads is the same than number\nof sockets\nUse new DEFIN_PROP_*\n---\n hmp.c | 7 +++++++\n migration/migration.c | 26 ++++++++++++++++++++++++++\n migration/migration.h | 1 +\n qapi/migration.json | 24 +++++++++++++++++++++---\n 4 files changed, 55 insertions(+), 3 deletions(-)", "diff": "diff --git a/hmp.c b/hmp.c\nindex cd046c6d71..4931b2fe9f 100644\n--- a/hmp.c\n+++ b/hmp.c\n@@ -336,6 +336,9 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict)\n monitor_printf(mon, \"%s: %s\\n\",\n MigrationParameter_str(MIGRATION_PARAMETER_BLOCK_INCREMENTAL),\n params->block_incremental ? \"on\" : \"off\");\n+ monitor_printf(mon, \"%s: %\" PRId64 \"\\n\",\n+ MigrationParameter_str(MIGRATION_PARAMETER_X_MULTIFD_THREADS),\n+ params->x_multifd_threads);\n }\n \n qapi_free_MigrationParameters(params);\n@@ -1621,6 +1624,10 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)\n p->has_block_incremental = true;\n visit_type_bool(v, param, &p->block_incremental, &err);\n break;\n+ case MIGRATION_PARAMETER_X_MULTIFD_THREADS:\n+ p->has_x_multifd_threads = true;\n+ visit_type_int(v, param, &p->x_multifd_threads, &err);\n+ break;\n default:\n assert(0);\n }\ndiff --git a/migration/migration.c b/migration/migration.c\nindex 1e97b3114e..fe9788ed62 100644\n--- a/migration/migration.c\n+++ b/migration/migration.c\n@@ -77,6 +77,7 @@\n * Note: Please change this default value to 10000 when we support hybrid mode.\n */\n #define DEFAULT_MIGRATE_X_CHECKPOINT_DELAY 200\n+#define DEFAULT_MIGRATE_MULTIFD_THREADS 2\n \n static NotifierList migration_state_notifiers =\n NOTIFIER_LIST_INITIALIZER(migration_state_notifiers);\n@@ -482,6 +483,8 @@ MigrationParameters *qmp_query_migrate_parameters(Error **errp)\n params->x_checkpoint_delay = s->parameters.x_checkpoint_delay;\n params->has_block_incremental = true;\n params->block_incremental = s->parameters.block_incremental;\n+ params->has_x_multifd_threads = true;\n+ params->x_multifd_threads = s->parameters.x_multifd_threads;\n \n return params;\n }\n@@ -763,6 +766,13 @@ static bool migrate_params_check(MigrationParameters *params, Error **errp)\n \"is invalid, it should be positive\");\n return false;\n }\n+ if (params->has_x_multifd_threads &&\n+ (params->x_multifd_threads < 1 || params->x_multifd_threads > 255)) {\n+ error_setg(errp, QERR_INVALID_PARAMETER_VALUE,\n+ \"multifd_threads\",\n+ \"is invalid, it should be in the range of 1 to 255\");\n+ return false;\n+ }\n \n return true;\n }\n@@ -881,6 +891,9 @@ static void migrate_params_apply(MigrateSetParameters *params)\n if (params->has_block_incremental) {\n s->parameters.block_incremental = params->block_incremental;\n }\n+ if (params->has_x_multifd_threads) {\n+ s->parameters.x_multifd_threads = params->x_multifd_threads;\n+ }\n }\n \n void qmp_migrate_set_parameters(MigrateSetParameters *params, Error **errp)\n@@ -1467,6 +1480,15 @@ bool migrate_use_multifd(void)\n return s->enabled_capabilities[MIGRATION_CAPABILITY_X_MULTIFD];\n }\n \n+int migrate_multifd_threads(void)\n+{\n+ MigrationState *s;\n+\n+ s = migrate_get_current();\n+\n+ return s->parameters.x_multifd_threads;\n+}\n+\n int migrate_use_xbzrle(void)\n {\n MigrationState *s;\n@@ -2232,6 +2254,9 @@ static Property migration_properties[] = {\n DEFINE_PROP_INT64(\"x-checkpoint-delay\", MigrationState,\n parameters.x_checkpoint_delay,\n DEFAULT_MIGRATE_X_CHECKPOINT_DELAY),\n+ DEFINE_PROP_INT64(\"x-multifd-threads\", MigrationState,\n+ parameters.x_multifd_threads,\n+ DEFAULT_MIGRATE_MULTIFD_THREADS),\n \n /* Migration capabilities */\n DEFINE_PROP_MIG_CAP(\"x-xbzrle\", MIGRATION_CAPABILITY_XBZRLE),\n@@ -2291,6 +2316,7 @@ static void migration_instance_init(Object *obj)\n params->has_downtime_limit = true;\n params->has_x_checkpoint_delay = true;\n params->has_block_incremental = true;\n+ params->has_x_multifd_threads = true;\n }\n \n /*\ndiff --git a/migration/migration.h b/migration/migration.h\nindex 023b14aa08..8a61f460b0 100644\n--- a/migration/migration.h\n+++ b/migration/migration.h\n@@ -180,6 +180,7 @@ bool migrate_zero_blocks(void);\n \n bool migrate_auto_converge(void);\n bool migrate_use_multifd(void);\n+int migrate_multifd_threads(void);\n \n int migrate_use_xbzrle(void);\n int64_t migrate_xbzrle_cache_size(void);\ndiff --git a/qapi/migration.json b/qapi/migration.json\nindex ec4a88a43a..b5a5d694f4 100644\n--- a/qapi/migration.json\n+++ b/qapi/migration.json\n@@ -466,13 +466,19 @@\n # \tmigrated and the destination must already have access to the\n # \tsame backing chain as was used on the source. (since 2.10)\n #\n+# @x-multifd-threads: Number of threads used to migrate data in\n+# parallel. This is the same number that the\n+# number of sockets used for migration.\n+# The default value is 2 (since 2.11)\n+#\n # Since: 2.4\n ##\n { 'enum': 'MigrationParameter',\n 'data': ['compress-level', 'compress-threads', 'decompress-threads',\n 'cpu-throttle-initial', 'cpu-throttle-increment',\n 'tls-creds', 'tls-hostname', 'max-bandwidth',\n- 'downtime-limit', 'x-checkpoint-delay', 'block-incremental' ] }\n+ 'downtime-limit', 'x-checkpoint-delay', 'block-incremental',\n+ 'x-multifd-threads'] }\n \n ##\n # @MigrateSetParameters:\n@@ -528,6 +534,11 @@\n # \tmigrated and the destination must already have access to the\n # \tsame backing chain as was used on the source. (since 2.10)\n #\n+# @x-multifd-threads: Number of threads used to migrate data in\n+# parallel. This is the same number that the\n+# number of sockets used for migration.\n+# The default value is 2 (since 2.11)\n+#\n # Since: 2.4\n ##\n # TODO either fuse back into MigrationParameters, or make\n@@ -543,7 +554,8 @@\n '*max-bandwidth': 'int',\n '*downtime-limit': 'int',\n '*x-checkpoint-delay': 'int',\n- '*block-incremental': 'bool' } }\n+ '*block-incremental': 'bool',\n+ '*x-multifd-threads': 'int' } }\n \n ##\n # @migrate-set-parameters:\n@@ -614,6 +626,11 @@\n # \tmigrated and the destination must already have access to the\n # \tsame backing chain as was used on the source. (since 2.10)\n #\n+# @x-multifd-threads: Number of threads used to migrate data in\n+# parallel. This is the same number that the\n+# number of sockets used for migration.\n+# The default value is 2 (since 2.11)\n+#\n # Since: 2.4\n ##\n { 'struct': 'MigrationParameters',\n@@ -627,7 +644,8 @@\n '*max-bandwidth': 'int',\n '*downtime-limit': 'int',\n '*x-checkpoint-delay': 'int',\n- '*block-incremental': 'bool' } }\n+ '*block-incremental': 'bool' ,\n+ '*x-multifd-threads': 'int' } }\n \n ##\n # @query-migrate-parameters:\n", "prefixes": [ "v7", "10/22" ] }