Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 810509,
    "url": "http://patchwork.ozlabs.org/api/patches/810509/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/CE371C1263339941885964188A0225FA333391@CHN-SV-EXMX03.mchp-main.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<CE371C1263339941885964188A0225FA333391@CHN-SV-EXMX03.mchp-main.com>",
    "list_archive_url": null,
    "date": "2017-09-06T10:51:53",
    "name": "[net,3/4] lan78xx: Fix for eeprom read/write when device autosuspend",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "a1330cc0ca9fe63a8525998f11ca5a5f58dc880b",
    "submitter": {
        "id": 71648,
        "url": "http://patchwork.ozlabs.org/api/people/71648/?format=api",
        "name": "Nisar Sayed",
        "email": "Nisar.Sayed@microchip.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/CE371C1263339941885964188A0225FA333391@CHN-SV-EXMX03.mchp-main.com/mbox/",
    "series": [
        {
            "id": 1761,
            "url": "http://patchwork.ozlabs.org/api/series/1761/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=1761",
            "date": "2017-09-06T10:49:39",
            "name": "lan78xx: Fixes and Enhancements to lan78xx driver",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/1761/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/810509/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/810509/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnL9d1TjSz9s0g\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed,  6 Sep 2017 20:56:21 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753526AbdIFKyF convert rfc822-to-8bit (ORCPT\n\t<rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 6 Sep 2017 06:54:05 -0400",
            "from esa3.microchip.iphmx.com ([68.232.153.233]:3082 \"EHLO\n\tesa3.microchip.iphmx.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753378AbdIFKw4 (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 6 Sep 2017 06:52:56 -0400",
            "from exsmtp02.microchip.com (HELO email.microchip.com)\n\t([198.175.253.38])\n\tby esa3.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t06 Sep 2017 03:51:54 -0700",
            "from CHN-SV-EXMX03.mchp-main.com ([fe80::58f5:b949:4b1:3df4]) by\n\tCHN-SV-EXCH02.mchp-main.com ([::1]) with mapi id 14.03.0352.000;\n\tWed, 6 Sep 2017 03:51:54 -0700"
        ],
        "X-IronPort-AV": "E=Sophos;i=\"5.41,483,1498546800\"; d=\"scan'208\";a=\"6798046\"",
        "From": "<Nisar.Sayed@microchip.com>",
        "To": "<davem@davemloft.net>, <UNGLinuxDriver@microchip.com>",
        "CC": "<netdev@vger.kernel.org>",
        "Subject": "[PATCH net 3/4] lan78xx: Fix for eeprom read/write when device\n\tautosuspend",
        "Thread-Topic": "[PATCH net 3/4] lan78xx: Fix for eeprom read/write when device\n\tautosuspend",
        "Thread-Index": "AdMm/NwKvobPZ4jbS72W8IMpSqVwUQ==",
        "Date": "Wed, 6 Sep 2017 10:51:53 +0000",
        "Message-ID": "<CE371C1263339941885964188A0225FA333391@CHN-SV-EXMX03.mchp-main.com>",
        "Accept-Language": "en-US",
        "Content-Language": "en-US",
        "X-MS-Has-Attach": "",
        "X-MS-TNEF-Correlator": "",
        "x-originating-ip": "[10.10.215.90]",
        "Content-Type": "text/plain; charset=\"us-ascii\"",
        "Content-Transfer-Encoding": "8BIT",
        "MIME-Version": "1.0",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "From: Nisar Sayed <Nisar.Sayed@microchip.com>\n\nFix for eeprom read/write when device autosuspend\n\nSigned-off-by: Nisar Sayed <Nisar.Sayed@microchip.com>\n---\n drivers/net/usb/lan78xx.c | 26 ++++++++++++++++++++++----\n 1 file changed, 22 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c\nindex 6242cb7..e04ec23 100644\n--- a/drivers/net/usb/lan78xx.c\n+++ b/drivers/net/usb/lan78xx.c\n@@ -1278,30 +1278,48 @@ static int lan78xx_ethtool_get_eeprom(struct net_device *netdev,\n \t\t\t\t      struct ethtool_eeprom *ee, u8 *data)\n {\n \tstruct lan78xx_net *dev = netdev_priv(netdev);\n+\tint ret = -EINVAL;\n+\n+\tif (usb_autopm_get_interface(dev->intf) < 0)\n+\t\treturn ret;\n \n \tee->magic = LAN78XX_EEPROM_MAGIC;\n \n-\treturn lan78xx_read_raw_eeprom(dev, ee->offset, ee->len, data);\n+\tret = lan78xx_read_raw_eeprom(dev, ee->offset, ee->len, data);\n+\n+\tusb_autopm_put_interface(dev->intf);\n+\n+\treturn ret;\n }\n \n static int lan78xx_ethtool_set_eeprom(struct net_device *netdev,\n \t\t\t\t      struct ethtool_eeprom *ee, u8 *data)\n {\n \tstruct lan78xx_net *dev = netdev_priv(netdev);\n+\tint ret = -EINVAL;\n+\n+\tif (usb_autopm_get_interface(dev->intf) < 0)\n+\t\treturn ret;\n \n \t/* Allow entire eeprom update only */\n \tif ((ee->magic == LAN78XX_EEPROM_MAGIC) &&\n \t    (ee->offset == 0) &&\n \t    (ee->len == 512) &&\n \t    (data[0] == EEPROM_INDICATOR))\n-\t\treturn lan78xx_write_raw_eeprom(dev, ee->offset, ee->len, data);\n+\t\tret = lan78xx_write_raw_eeprom(dev, ee->offset, ee->len, data);\n \telse if ((ee->magic == LAN78XX_OTP_MAGIC) &&\n \t\t (ee->offset == 0) &&\n \t\t (ee->len == 512) &&\n \t\t (data[0] == OTP_INDICATOR_1))\n-\t\treturn lan78xx_write_raw_otp(dev, ee->offset, ee->len, data);\n+\t\tret = lan78xx_write_raw_otp(dev, ee->offset, ee->len, data);\n+\telse if ((ee->magic == LAN78XX_EEPROM_MAGIC) &&\n+\t\t (ee->offset >= 0 && ee->offset < MAX_EEPROM_SIZE) &&\n+\t\t (ee->len > 0 && (ee->offset + ee->len) <= MAX_EEPROM_SIZE))\n+\t\tret = lan78xx_write_raw_eeprom(dev, ee->offset, ee->len, data);\n \n-\treturn -EINVAL;\n+\tusb_autopm_put_interface(dev->intf);\n+\n+\treturn ret;\n }\n \n static void lan78xx_get_strings(struct net_device *netdev, u32 stringset,\n",
    "prefixes": [
        "net",
        "3/4"
    ]
}