Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/810493/?format=api
{ "id": 810493, "url": "http://patchwork.ozlabs.org/api/patches/810493/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20170906100935.GA55016@adacore.com/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170906100935.GA55016@adacore.com>", "list_archive_url": null, "date": "2017-09-06T10:09:35", "name": "[Ada] No_Return procedures in renaming declarations.", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "754588ecc0e8b1b582c336fc7176124c4e5fff99", "submitter": { "id": 4418, "url": "http://patchwork.ozlabs.org/api/people/4418/?format=api", "name": "Arnaud Charlet", "email": "charlet@adacore.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20170906100935.GA55016@adacore.com/mbox/", "series": [ { "id": 1754, "url": "http://patchwork.ozlabs.org/api/series/1754/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=1754", "date": "2017-09-06T10:09:35", "name": "[Ada] No_Return procedures in renaming declarations.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1754/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/810493/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/810493/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-return-461579-incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "mailing list gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461579-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"Yz6bPhSu\"; dkim-atps=neutral", "sourceware.org; auth=none" ], "Received": [ "from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnK8543tVz9s0Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 6 Sep 2017 20:09:57 +1000 (AEST)", "(qmail 62181 invoked by alias); 6 Sep 2017 10:09:39 -0000", "(qmail 62136 invoked by uid 89); 6 Sep 2017 10:09:39 -0000", "from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tWed, 06 Sep 2017 10:09:37 +0000", "from localhost (localhost.localdomain [127.0.0.1])\tby\n\tfiltered-rock.gnat.com (Postfix) with ESMTP id 0867456137;\n\tWed, 6 Sep 2017 06:09:36 -0400 (EDT)", "from rock.gnat.com ([127.0.0.1])\tby localhost (rock.gnat.com\n\t[127.0.0.1]) (amavisd-new, port 10024)\twith LMTP id\n\twMoFFyzFZkEs; Wed, 6 Sep 2017 06:09:35 -0400 (EDT)", "from tron.gnat.com (tron.gnat.com\n\t[IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294])\tby rock.gnat.com\n\t(Postfix) with ESMTP id EC6F25606C;\n\tWed, 6 Sep 2017 06:09:35 -0400 (EDT)", "by tron.gnat.com (Postfix, from userid 4192)\tid EB4B44FC;\n\tWed, 6 Sep 2017 06:09:35 -0400 (EDT)" ], "DomainKey-Signature": "a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:mime-version:content-type; q=dns;\n\ts=default; b=p1uQHcqtafBz6vBfq0+v9bFcKRCHtkoUVF5uPNaYpmbvUtFIpN\n\tN7Keaq3Rz75C58PXaiJBSz+ZZv5R1O1nWVAM2ii8rGEbgMDKrHlnW3e6C+/E9cxz\n\tgTKQtbmS+KOUX0N9dYOUrZO2zvKKiCnz17bTLPid8KbGxyEibAIPNNzd4=", "DKIM-Signature": "v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:mime-version:content-type; s=\n\tdefault; bh=GZFm2/NXV3DDWN8M+HDe+7filWw=; b=Yz6bPhSuC2y8G+OuAy7K\n\tBWsgvdnzz8iddN3VMZcOJKjfKeYSDcIy9M2wa1aSc+FmKNqe7eIHogKBXCMv9/z2\n\tGpTPHG/YWiRrS9t6QOfR+FSmAikI0Zx3PtM3aj9hJq6RXOv2RePa+lhf5XET3MdG\n\tLQvjst/fbsagnXnKSTNQdh8=", "Mailing-List": "contact gcc-patches-help@gcc.gnu.org; run by ezmlm", "Precedence": "bulk", "List-Id": "<gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org>", "List-Archive": "<http://gcc.gnu.org/ml/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-help@gcc.gnu.org>", "Sender": "gcc-patches-owner@gcc.gnu.org", "X-Virus-Found": "No", "X-Spam-SWARE-Status": "No, score=-11.1 required=5.0 tests=BAYES_00, GIT_PATCH_2,\n\tGIT_PATCH_3, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=", "X-HELO": "rock.gnat.com", "Date": "Wed, 6 Sep 2017 06:09:35 -0400", "From": "Arnaud Charlet <charlet@adacore.com>", "To": "gcc-patches@gcc.gnu.org", "Cc": "Ed Schonberg <schonberg@adacore.com>", "Subject": "[Ada] No_Return procedures in renaming declarations.", "Message-ID": "<20170906100935.GA55016@adacore.com>", "MIME-Version": "1.0", "Content-Type": "multipart/mixed; boundary=\"Nq2Wo0NMKNjxTN9z\"", "Content-Disposition": "inline", "User-Agent": "Mutt/1.5.23 (2014-03-12)" }, "content": "This patch implements legality rule in 6.5.1 (7/2): if a renaming as body\ncompletes a nonreturning procedure declaration, the renamed procedure must\nbe nonreturning as well. Previously GNAT only produced a warning in such\ncases.\n\nTested in ACATS test B651002.\n\nTested on x86_64-pc-linux-gnu, committed on trunk\n\n2017-09-06 Ed Schonberg <schonberg@adacore.com>\n\n\t* sem_ch6.adb (Check_Returns): Clean up warnings coming from\n\tgenerated bodies for renamings that are completions, when renamed\n\tprocedure is No_Return.\n\t* sem_ch8.adb (Analyze_Subprogram_Renaming): Implement legality\n\trule in 6.5.1 (7/2): if a renaming is a completion of a subprogram\n\twith No_Return, the renamed entity must be No_Return as well.", "diff": "Index: sem_ch6.adb\n===================================================================\n--- sem_ch6.adb\t(revision 251762)\n+++ sem_ch6.adb\t(working copy)\n@@ -6693,7 +6693,11 @@\n Error_Msg_N\n (\"implied return after this statement \"\n & \"would have raised Program_Error\", Last_Stm);\n- else\n+\n+ -- In normal compilation mode, do not warn on a generated\n+ -- call (e.g. in the body of a renaming as completion).\n+\n+ elsif Comes_From_Source (Last_Stm) then\n Error_Msg_N\n (\"implied return after this statement \"\n & \"will raise Program_Error??\", Last_Stm);\nIndex: sem_ch8.adb\n===================================================================\n--- sem_ch8.adb\t(revision 251762)\n+++ sem_ch8.adb\t(working copy)\n@@ -2946,6 +2946,14 @@\n Check_Fully_Conformant (New_S, Rename_Spec);\n Set_Public_Status (New_S);\n \n+ if No_Return (Rename_Spec)\n+ and then not No_Return (Entity (Nam))\n+ then\n+ Error_Msg_N (\"renaming completes a No_Return procedure\", N);\n+ Error_Msg_N\n+ (\"\\renamed procedure must be nonreturning (RM 6.5.1 (7/2))\", N);\n+ end if;\n+\n -- The specification does not introduce new formals, but only\n -- repeats the formals of the original subprogram declaration.\n -- For cross-reference purposes, and for refactoring tools, we\n", "prefixes": [ "Ada" ] }