Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/810492/?format=api
{ "id": 810492, "url": "http://patchwork.ozlabs.org/api/patches/810492/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20170906100930.GA54943@adacore.com/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170906100930.GA54943@adacore.com>", "list_archive_url": null, "date": "2017-09-06T10:09:30", "name": "[Ada] Improve error message when function is used in a call statement", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6a6662615eef9b7e521eb9fe45065104100d38c0", "submitter": { "id": 4418, "url": "http://patchwork.ozlabs.org/api/people/4418/?format=api", "name": "Arnaud Charlet", "email": "charlet@adacore.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20170906100930.GA54943@adacore.com/mbox/", "series": [ { "id": 1753, "url": "http://patchwork.ozlabs.org/api/series/1753/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=1753", "date": "2017-09-06T10:09:30", "name": "[Ada] Improve error message when function is used in a call statement", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1753/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/810492/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/810492/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-return-461578-incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "mailing list gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461578-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"rWyyQ0+c\"; dkim-atps=neutral", "sourceware.org; auth=none" ], "Received": [ "from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnK7q4btDz9sBd\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 6 Sep 2017 20:09:42 +1000 (AEST)", "(qmail 61532 invoked by alias); 6 Sep 2017 10:09:33 -0000", "(qmail 61521 invoked by uid 89); 6 Sep 2017 10:09:33 -0000", "from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tWed, 06 Sep 2017 10:09:32 +0000", "from localhost (localhost.localdomain [127.0.0.1])\tby\n\tfiltered-rock.gnat.com (Postfix) with ESMTP id 95EEC56137;\n\tWed, 6 Sep 2017 06:09:30 -0400 (EDT)", "from rock.gnat.com ([127.0.0.1])\tby localhost (rock.gnat.com\n\t[127.0.0.1]) (amavisd-new, port 10024)\twith LMTP id\n\taqplbgUEFvmr; Wed, 6 Sep 2017 06:09:30 -0400 (EDT)", "from tron.gnat.com (tron.gnat.com [205.232.38.10])\tby\n\trock.gnat.com (Postfix) with ESMTP id 83A085606C;\n\tWed, 6 Sep 2017 06:09:30 -0400 (EDT)", "by tron.gnat.com (Postfix, from userid 4192)\tid 7FE1D4FC;\n\tWed, 6 Sep 2017 06:09:30 -0400 (EDT)" ], "DomainKey-Signature": "a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:mime-version:content-type; q=dns;\n\ts=default; b=eGEVV8gkNBNpKrJ33nzVQZh36Tybm7gwttRCsStiXrKiMRgZpp\n\tv7mv/rX1PRS4aHHu+9aNoMUTp5Glschb48Mh3T8d87RUPpB/eZCqvfgMfU1pHnwJ\n\tgvPhcbAUFBivX/y1uU8vHR04BmxQcifIS8y822aO1cuRMbMBrZbGsQ3Lw=", "DKIM-Signature": "v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:mime-version:content-type; s=\n\tdefault; bh=yDrQYdGxHufskYaMC1RbWktKWbM=; b=rWyyQ0+cTmAn0eFQiHp1\n\tNdmTLrG0FrjQOvjiTjaOuXWPj5gKjcURHC05ZZcRrIqnkPbERZT8BACWLXN9NcaB\n\td4vuTCgOtQb3co1ecu08W2EqPdxJr8iM9g8ngi5caZTZvpAT9/NaTebZ1LF/T24m\n\tfmIWQysfw/LAvOex3jYHHZU=", "Mailing-List": "contact gcc-patches-help@gcc.gnu.org; run by ezmlm", "Precedence": "bulk", "List-Id": "<gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org>", "List-Archive": "<http://gcc.gnu.org/ml/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-help@gcc.gnu.org>", "Sender": "gcc-patches-owner@gcc.gnu.org", "X-Virus-Found": "No", "X-Spam-SWARE-Status": "No, score=-11.1 required=5.0 tests=AWL, BAYES_00,\n\tGIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=harm", "X-HELO": "rock.gnat.com", "Date": "Wed, 6 Sep 2017 06:09:30 -0400", "From": "Arnaud Charlet <charlet@adacore.com>", "To": "gcc-patches@gcc.gnu.org", "Cc": "Yannick Moy <moy@adacore.com>", "Subject": "[Ada] Improve error message when function is used in a call\n\tstatement", "Message-ID": "<20170906100930.GA54943@adacore.com>", "MIME-Version": "1.0", "Content-Type": "multipart/mixed; boundary=\"GvXjxJ+pjyke8COw\"", "Content-Disposition": "inline", "User-Agent": "Mutt/1.5.23 (2014-03-12)" }, "content": "A typical error for new users of Ada is to call functions in a call\nstatement. Improve the error message for these users, to better indicate\nwhat the error is in that case.\n\nThe following compilation raises the new message.\n\n $ gcc -c main.adb\n\n 1. procedure Main is\n 2. function Lol return Integer is (0);\n 3. begin\n 4. Lol;\n |\n >>> cannot use call to function \"Lol\" as a statement\n >>> return value of a function call cannot be ignored\n\n 5. end Main;\n\nTested on x86_64-pc-linux-gnu, committed on trunk\n\n2017-09-06 Yannick Moy <moy@adacore.com>\n\n\t* sem_res.adb (Resolve): Update message for function call as statement.", "diff": "Index: sem_res.adb\n===================================================================\n--- sem_res.adb\t(revision 251755)\n+++ sem_res.adb\t(working copy)\n@@ -2533,8 +2533,11 @@\n and then Ekind (Entity (Name (N))) = E_Function\n then\n Error_Msg_NE\n- (\"cannot use function & in a procedure call\",\n+ (\"cannot use call to function & as a statement\",\n Name (N), Entity (Name (N)));\n+ Error_Msg_N\n+ (\"\\return value of a function call cannot be ignored\",\n+ Name (N));\n \n -- Otherwise give general message (not clear what cases this\n -- covers, but no harm in providing for them).\n", "prefixes": [ "Ada" ] }