Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/810456/?format=api
{ "id": 810456, "url": "http://patchwork.ozlabs.org/api/patches/810456/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170906090857.14846-2-romain.perier@collabora.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170906090857.14846-2-romain.perier@collabora.com>", "list_archive_url": null, "date": "2017-09-06T09:08:53", "name": "[v13,1/5] block: DAC960: Replace PCI pool old API", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "324d6d95ae6896328dd3ceb896dce026d6a438d6", "submitter": { "id": 70720, "url": "http://patchwork.ozlabs.org/api/people/70720/?format=api", "name": "Romain Perier", "email": "romain.perier@collabora.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170906090857.14846-2-romain.perier@collabora.com/mbox/", "series": [ { "id": 1729, "url": "http://patchwork.ozlabs.org/api/series/1729/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=1729", "date": "2017-09-06T09:08:56", "name": "Replace PCI pool by DMA pool API", "version": 13, "mbox": "http://patchwork.ozlabs.org/series/1729/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/810456/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/810456/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnHrQ2nMrz9s82\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 6 Sep 2017 19:11:18 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752681AbdIFJLF (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 6 Sep 2017 05:11:05 -0400", "from bhuna.collabora.co.uk ([46.235.227.227]:50668 \"EHLO\n\tbhuna.collabora.co.uk\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752386AbdIFJJZ (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 6 Sep 2017 05:09:25 -0400", "from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: rperier) with ESMTPSA id 69D4A26869F" ], "From": "Romain Perier <romain.perier@collabora.com>", "To": "Dan Williams <dan.j.williams@intel.com>,\n\tDoug Ledford <dledford@redhat.com>, Sean Hefty <sean.hefty@intel.com>,\n\tHal Rosenstock <hal.rosenstock@gmail.com>, jeffrey.t.kirsher@intel.com,\n\t\"David S. Miller\" <davem@davemloft.net>, stas.yakovlev@gmail.com,\n\tAviad Krawczyk <aviad.krawczyk@huawei.com>", "Cc": "linux-rdma@vger.kernel.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tGreg Kroah-Hartman <gregkh@linuxfoundation.org>,\n\tRomain Perier <romain.perier@collabora.com>", "Subject": "[PATCH v13 1/5] block: DAC960: Replace PCI pool old API", "Date": "Wed, 6 Sep 2017 11:08:53 +0200", "Message-Id": "<20170906090857.14846-2-romain.perier@collabora.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20170906090857.14846-1-romain.perier@collabora.com>", "References": "<20170906090857.14846-1-romain.perier@collabora.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "The PCI pool API is deprecated. This commit replaces the PCI pool old\nAPI by the appropriate function with the DMA pool API.\n\nSigned-off-by: Romain Perier <romain.perier@collabora.com>\nAcked-by: Peter Senna Tschudin <peter.senna@collabora.com>\nTested-by: Peter Senna Tschudin <peter.senna@collabora.com>\n---\n drivers/block/DAC960.c | 38 ++++++++++++++++++--------------------\n drivers/block/DAC960.h | 4 ++--\n 2 files changed, 20 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c\nindex 255591ab3716..2a8950ee382c 100644\n--- a/drivers/block/DAC960.c\n+++ b/drivers/block/DAC960.c\n@@ -268,17 +268,17 @@ static bool DAC960_CreateAuxiliaryStructures(DAC960_Controller_T *Controller)\n void *AllocationPointer = NULL;\n void *ScatterGatherCPU = NULL;\n dma_addr_t ScatterGatherDMA;\n- struct pci_pool *ScatterGatherPool;\n+ struct dma_pool *ScatterGatherPool;\n void *RequestSenseCPU = NULL;\n dma_addr_t RequestSenseDMA;\n- struct pci_pool *RequestSensePool = NULL;\n+ struct dma_pool *RequestSensePool = NULL;\n \n if (Controller->FirmwareType == DAC960_V1_Controller)\n {\n CommandAllocationLength = offsetof(DAC960_Command_T, V1.EndMarker);\n CommandAllocationGroupSize = DAC960_V1_CommandAllocationGroupSize;\n- ScatterGatherPool = pci_pool_create(\"DAC960_V1_ScatterGather\",\n-\t\tController->PCIDevice,\n+ ScatterGatherPool = dma_pool_create(\"DAC960_V1_ScatterGather\",\n+\t\t&Controller->PCIDevice->dev,\n \tDAC960_V1_ScatterGatherLimit * sizeof(DAC960_V1_ScatterGatherSegment_T),\n \tsizeof(DAC960_V1_ScatterGatherSegment_T), 0);\n if (ScatterGatherPool == NULL)\n@@ -290,18 +290,18 @@ static bool DAC960_CreateAuxiliaryStructures(DAC960_Controller_T *Controller)\n {\n CommandAllocationLength = offsetof(DAC960_Command_T, V2.EndMarker);\n CommandAllocationGroupSize = DAC960_V2_CommandAllocationGroupSize;\n- ScatterGatherPool = pci_pool_create(\"DAC960_V2_ScatterGather\",\n-\t\tController->PCIDevice,\n+ ScatterGatherPool = dma_pool_create(\"DAC960_V2_ScatterGather\",\n+\t\t&Controller->PCIDevice->dev,\n \tDAC960_V2_ScatterGatherLimit * sizeof(DAC960_V2_ScatterGatherSegment_T),\n \tsizeof(DAC960_V2_ScatterGatherSegment_T), 0);\n if (ScatterGatherPool == NULL)\n \t return DAC960_Failure(Controller,\n \t\t\t\"AUXILIARY STRUCTURE CREATION (SG)\");\n- RequestSensePool = pci_pool_create(\"DAC960_V2_RequestSense\",\n-\t\tController->PCIDevice, sizeof(DAC960_SCSI_RequestSense_T),\n+ RequestSensePool = dma_pool_create(\"DAC960_V2_RequestSense\",\n+\t\t&Controller->PCIDevice->dev, sizeof(DAC960_SCSI_RequestSense_T),\n \t\tsizeof(int), 0);\n if (RequestSensePool == NULL) {\n-\t pci_pool_destroy(ScatterGatherPool);\n+\t dma_pool_destroy(ScatterGatherPool);\n \t return DAC960_Failure(Controller,\n \t\t\t\"AUXILIARY STRUCTURE CREATION (SG)\");\n }\n@@ -335,16 +335,16 @@ static bool DAC960_CreateAuxiliaryStructures(DAC960_Controller_T *Controller)\n Command->Next = Controller->FreeCommands;\n Controller->FreeCommands = Command;\n Controller->Commands[CommandIdentifier-1] = Command;\n- ScatterGatherCPU = pci_pool_alloc(ScatterGatherPool, GFP_ATOMIC,\n+ ScatterGatherCPU = dma_pool_alloc(ScatterGatherPool, GFP_ATOMIC,\n \t\t\t\t\t\t\t&ScatterGatherDMA);\n if (ScatterGatherCPU == NULL)\n \t return DAC960_Failure(Controller, \"AUXILIARY STRUCTURE CREATION\");\n \n if (RequestSensePool != NULL) {\n- \t RequestSenseCPU = pci_pool_alloc(RequestSensePool, GFP_ATOMIC,\n+ \t RequestSenseCPU = dma_pool_alloc(RequestSensePool, GFP_ATOMIC,\n \t\t\t\t\t\t&RequestSenseDMA);\n \t if (RequestSenseCPU == NULL) {\n- pci_pool_free(ScatterGatherPool, ScatterGatherCPU,\n+ dma_pool_free(ScatterGatherPool, ScatterGatherCPU,\n ScatterGatherDMA);\n \t\treturn DAC960_Failure(Controller,\n \t\t\t\t\t\"AUXILIARY STRUCTURE CREATION\");\n@@ -379,8 +379,8 @@ static bool DAC960_CreateAuxiliaryStructures(DAC960_Controller_T *Controller)\n static void DAC960_DestroyAuxiliaryStructures(DAC960_Controller_T *Controller)\n {\n int i;\n- struct pci_pool *ScatterGatherPool = Controller->ScatterGatherPool;\n- struct pci_pool *RequestSensePool = NULL;\n+ struct dma_pool *ScatterGatherPool = Controller->ScatterGatherPool;\n+ struct dma_pool *RequestSensePool = NULL;\n void *ScatterGatherCPU;\n dma_addr_t ScatterGatherDMA;\n void *RequestSenseCPU;\n@@ -411,9 +411,9 @@ static void DAC960_DestroyAuxiliaryStructures(DAC960_Controller_T *Controller)\n \t RequestSenseDMA = Command->V2.RequestSenseDMA;\n }\n if (ScatterGatherCPU != NULL)\n- pci_pool_free(ScatterGatherPool, ScatterGatherCPU, ScatterGatherDMA);\n+ dma_pool_free(ScatterGatherPool, ScatterGatherCPU, ScatterGatherDMA);\n if (RequestSenseCPU != NULL)\n- pci_pool_free(RequestSensePool, RequestSenseCPU, RequestSenseDMA);\n+ dma_pool_free(RequestSensePool, RequestSenseCPU, RequestSenseDMA);\n \n if ((Command->CommandIdentifier\n \t % Controller->CommandAllocationGroupSize) == 1) {\n@@ -437,13 +437,11 @@ static void DAC960_DestroyAuxiliaryStructures(DAC960_Controller_T *Controller)\n Controller->CurrentStatusBuffer = NULL;\n }\n \n- if (ScatterGatherPool != NULL)\n- \tpci_pool_destroy(ScatterGatherPool);\n+ dma_pool_destroy(ScatterGatherPool);\n if (Controller->FirmwareType == DAC960_V1_Controller)\n \treturn;\n \n- if (RequestSensePool != NULL)\n-\tpci_pool_destroy(RequestSensePool);\n+ dma_pool_destroy(RequestSensePool);\n \n for (i = 0; i < DAC960_MaxLogicalDrives; i++) {\n \tkfree(Controller->V2.LogicalDeviceInformation[i]);\ndiff --git a/drivers/block/DAC960.h b/drivers/block/DAC960.h\nindex 85fa9bb63759..47d7d698ece2 100644\n--- a/drivers/block/DAC960.h\n+++ b/drivers/block/DAC960.h\n@@ -2316,7 +2316,7 @@ typedef struct DAC960_Controller\n bool SuppressEnclosureMessages;\n struct timer_list MonitoringTimer;\n struct gendisk *disks[DAC960_MaxLogicalDrives];\n- struct pci_pool *ScatterGatherPool;\n+ struct dma_pool *ScatterGatherPool;\n DAC960_Command_T *FreeCommands;\n unsigned char *CombinedStatusBuffer;\n unsigned char *CurrentStatusBuffer;\n@@ -2429,7 +2429,7 @@ typedef struct DAC960_Controller\n bool NeedDeviceSerialNumberInformation;\n bool StartLogicalDeviceInformationScan;\n bool StartPhysicalDeviceInformationScan;\n- struct pci_pool *RequestSensePool;\n+ struct dma_pool *RequestSensePool;\n \n dma_addr_t\tFirstCommandMailboxDMA;\n DAC960_V2_CommandMailbox_T *FirstCommandMailbox;\n", "prefixes": [ "v13", "1/5" ] }