Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/810140/?format=api
{ "id": 810140, "url": "http://patchwork.ozlabs.org/api/patches/810140/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170905123935.26645-6-berrange@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170905123935.26645-6-berrange@redhat.com>", "list_archive_url": null, "date": "2017-09-05T12:39:35", "name": "[PULL,v2,5/5] io: fix check for handshake completion in TLS test", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "59fb7180fa137f5d9dac1d36f44fed058cb981d0", "submitter": { "id": 2694, "url": "http://patchwork.ozlabs.org/api/people/2694/?format=api", "name": "Daniel P. Berrangé", "email": "berrange@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170905123935.26645-6-berrange@redhat.com/mbox/", "series": [ { "id": 1575, "url": "http://patchwork.ozlabs.org/api/series/1575/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1575", "date": "2017-09-05T12:39:30", "name": "[PULL,v2,1/5] io: fix temp directory used by test-io-channel-tls test", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/1575/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/810140/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/810140/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmmg54wxVz9s0g\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 5 Sep 2017 22:46:25 +1000 (AEST)", "from localhost ([::1]:58742 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dpDFH-0001KF-Qm\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 08:46:23 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:58308)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <berrange@redhat.com>) id 1dpD91-0004Wt-Gu\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:40:00 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <berrange@redhat.com>) id 1dpD8s-0000AQ-0C\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:39:55 -0400", "from mx1.redhat.com ([209.132.183.28]:59492)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <berrange@redhat.com>) id 1dpD8r-00009E-R5\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 08:39:45 -0400", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D94D8C053FC9;\n\tTue, 5 Sep 2017 12:39:44 +0000 (UTC)", "from t460.redhat.com (unknown [10.33.36.63])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 1E3F57B256;\n\tTue, 5 Sep 2017 12:39:43 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com D94D8C053FC9", "From": "\"Daniel P. Berrange\" <berrange@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Tue, 5 Sep 2017 13:39:35 +0100", "Message-Id": "<20170905123935.26645-6-berrange@redhat.com>", "In-Reply-To": "<20170905123935.26645-1-berrange@redhat.com>", "References": "<20170905123935.26645-1-berrange@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.12", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tTue, 05 Sep 2017 12:39:45 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PULL v2 5/5] io: fix check for handshake completion\n\tin TLS test", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Peter Maydell <peter.maydell@linaro.org>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "The TLS I/O channel test had mistakenly used && instead\nof || when checking for handshake completion. As a\nresult it could terminate the handshake process before\nit had actually completed. This was harmless before but\nchanges in GNUTLS 3.6.0 exposed this bug and caused the\ntest suite to fail.\n\nReviewed-by: Eric Blake <eblake@redhat.com>\nSigned-off-by: Daniel P. Berrange <berrange@redhat.com>\n---\n tests/test-io-channel-tls.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/tests/test-io-channel-tls.c b/tests/test-io-channel-tls.c\nindex ff96877323..a210d01ba5 100644\n--- a/tests/test-io-channel-tls.c\n+++ b/tests/test-io-channel-tls.c\n@@ -218,7 +218,7 @@ static void test_io_channel_tls(const void *opaque)\n mainloop = g_main_context_default();\n do {\n g_main_context_iteration(mainloop, TRUE);\n- } while (!clientHandshake.finished &&\n+ } while (!clientHandshake.finished ||\n !serverHandshake.finished);\n \n g_assert(clientHandshake.failed == data->expectClientFail);\n", "prefixes": [ "PULL", "v2", "5/5" ] }