Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/810130/?format=api
{ "id": 810130, "url": "http://patchwork.ozlabs.org/api/patches/810130/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/1504615144-29770-20-git-send-email-gilad@benyossef.com/", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504615144-29770-20-git-send-email-gilad@benyossef.com>", "list_archive_url": null, "date": "2017-09-05T12:38:58", "name": "[v8,19/20] crypto: mediatek: move to generic async completion", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "a6e636a7523ffbff03c29af86fd60882c34fa00a", "submitter": { "id": 11198, "url": "http://patchwork.ozlabs.org/api/people/11198/?format=api", "name": "Gilad Ben-Yossef", "email": "gilad@benyossef.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/1504615144-29770-20-git-send-email-gilad@benyossef.com/mbox/", "series": [ { "id": 1572, "url": "http://patchwork.ozlabs.org/api/series/1572/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=1572", "date": "2017-09-05T12:38:39", "name": "simplify crypto wait for async op", "version": 8, "mbox": "http://patchwork.ozlabs.org/series/1572/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/810130/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/810130/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-cifs-owner@vger.kernel.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmmcP3XhKz9sRm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 5 Sep 2017 22:44:05 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752334AbdIEMoD (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tTue, 5 Sep 2017 08:44:03 -0400", "from foss.arm.com ([217.140.101.70]:39976 \"EHLO foss.arm.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752121AbdIEMn7 (ORCPT <rfc822;linux-cifs@vger.kernel.org>);\n\tTue, 5 Sep 2017 08:43:59 -0400", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 795D2165C;\n\tTue, 5 Sep 2017 05:43:58 -0700 (PDT)", "from gby.kfn.arm.com (unknown [10.45.48.140])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\t406FF3F3E1; Tue, 5 Sep 2017 05:43:48 -0700 (PDT)" ], "From": "Gilad Ben-Yossef <gilad@benyossef.com>", "To": "Herbert Xu <herbert@gondor.apana.org.au>,\n\t\"David S. Miller\" <davem@davemloft.net>,\n\tJonathan Corbet <corbet@lwn.net>, David Howells <dhowells@redhat.com>,\n\tTom Lendacky <thomas.lendacky@amd.com>, Gary Hook <gary.hook@amd.com>,\n\tBoris Brezillon <boris.brezillon@free-electrons.com>,\n\tArnaud Ebalard <arno@natisbad.org>,\n\tMatthias Brugger <matthias.bgg@gmail.com>,\n\tAlasdair Kergon <agk@redhat.com>,\n\tMike Snitzer <snitzer@redhat.com>, dm-devel@redhat.com,\n\tShaohua Li <shli@kernel.org>, Steve French <sfrench@samba.org>,\n\t\"Theodore Y. Ts'o\" <tytso@mit.edu>, Jaegeuk Kim <jaegeuk@kernel.org>,\n\tSteffen Klassert <steffen.klassert@secunet.com>,\n\tAlexey Kuznetsov <kuznet@ms2.inr.ac.ru>,\n\tHideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,\n\tMimi Zohar <zohar@linux.vnet.ibm.com>,\n\tDmitry Kasatkin <dmitry.kasatkin@gmail.com>,\n\tJames Morris <james.l.morris@oracle.com>,\n\t\"Serge E. Hallyn\" <serge@hallyn.com>, linux-crypto@vger.kernel.org,\n\tlinux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tkeyrings@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-mediatek@lists.infradead.org, linux-raid@vger.kernel.org,\n\tlinux-cifs@vger.kernel.org, samba-technical@lists.samba.org,\n\tlinux-fscrypt@vger.kernel.org, netdev@vger.kernel.org,\n\tlinux-ima-devel@lists.sourceforge.net,\n\tlinux-ima-user@lists.sourceforge.net,\n\tlinux-security-module@vger.kernel.org", "Cc": "Ofir Drang <ofir.drang@arm.com>", "Subject": "[PATCH v8 19/20] crypto: mediatek: move to generic async completion", "Date": "Tue, 5 Sep 2017 15:38:58 +0300", "Message-Id": "<1504615144-29770-20-git-send-email-gilad@benyossef.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1504615144-29770-1-git-send-email-gilad@benyossef.com>", "References": "<1504615144-29770-1-git-send-email-gilad@benyossef.com>", "Sender": "linux-cifs-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-cifs.vger.kernel.org>", "X-Mailing-List": "linux-cifs@vger.kernel.org" }, "content": "The mediatek driver starts several async crypto ops and waits for their\ncompletions. Move it over to generic code doing the same.\n\nSigned-off-by: Gilad Ben-Yossef <gilad@benyossef.com>\nAcked-by: Ryder Lee <ryder.lee@mediatek.com>\n---\n drivers/crypto/mediatek/mtk-aes.c | 31 +++++--------------------------\n 1 file changed, 5 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/crypto/mediatek/mtk-aes.c b/drivers/crypto/mediatek/mtk-aes.c\nindex 9e845e8..e2c7c95 100644\n--- a/drivers/crypto/mediatek/mtk-aes.c\n+++ b/drivers/crypto/mediatek/mtk-aes.c\n@@ -137,11 +137,6 @@ struct mtk_aes_gcm_ctx {\n \tstruct crypto_skcipher *ctr;\n };\n \n-struct mtk_aes_gcm_setkey_result {\n-\tint err;\n-\tstruct completion completion;\n-};\n-\n struct mtk_aes_drv {\n \tstruct list_head dev_list;\n \t/* Device list lock */\n@@ -936,17 +931,6 @@ static int mtk_aes_gcm_crypt(struct aead_request *req, u64 mode)\n \t\t\t\t &req->base);\n }\n \n-static void mtk_gcm_setkey_done(struct crypto_async_request *req, int err)\n-{\n-\tstruct mtk_aes_gcm_setkey_result *result = req->data;\n-\n-\tif (err == -EINPROGRESS)\n-\t\treturn;\n-\n-\tresult->err = err;\n-\tcomplete(&result->completion);\n-}\n-\n /*\n * Because of the hardware limitation, we need to pre-calculate key(H)\n * for the GHASH operation. The result of the encryption operation\n@@ -962,7 +946,7 @@ static int mtk_aes_gcm_setkey(struct crypto_aead *aead, const u8 *key,\n \t\tu32 hash[4];\n \t\tu8 iv[8];\n \n-\t\tstruct mtk_aes_gcm_setkey_result result;\n+\t\tstruct crypto_wait wait;\n \n \t\tstruct scatterlist sg[1];\n \t\tstruct skcipher_request req;\n@@ -1002,22 +986,17 @@ static int mtk_aes_gcm_setkey(struct crypto_aead *aead, const u8 *key,\n \tif (!data)\n \t\treturn -ENOMEM;\n \n-\tinit_completion(&data->result.completion);\n+\tcrypto_init_wait(&data->wait);\n \tsg_init_one(data->sg, &data->hash, AES_BLOCK_SIZE);\n \tskcipher_request_set_tfm(&data->req, ctr);\n \tskcipher_request_set_callback(&data->req, CRYPTO_TFM_REQ_MAY_SLEEP |\n \t\t\t\t CRYPTO_TFM_REQ_MAY_BACKLOG,\n-\t\t\t\t mtk_gcm_setkey_done, &data->result);\n+\t\t\t\t crypto_req_done, &data->wait);\n \tskcipher_request_set_crypt(&data->req, data->sg, data->sg,\n \t\t\t\t AES_BLOCK_SIZE, data->iv);\n \n-\terr = crypto_skcipher_encrypt(&data->req);\n-\tif (err == -EINPROGRESS || err == -EBUSY) {\n-\t\terr = wait_for_completion_interruptible(\n-\t\t\t&data->result.completion);\n-\t\tif (!err)\n-\t\t\terr = data->result.err;\n-\t}\n+\terr = crypto_wait_req(crypto_skcipher_encrypt(&data->req),\n+\t\t\t &data->wait);\n \tif (err)\n \t\tgoto out;\n \n", "prefixes": [ "v8", "19/20" ] }