Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/810044/?format=api
{ "id": 810044, "url": "http://patchwork.ozlabs.org/api/patches/810044/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/patch/1504603381-30071-6-git-send-email-yliu@fridaylinux.org/", "project": { "id": 47, "url": "http://patchwork.ozlabs.org/api/projects/47/?format=api", "name": "Open vSwitch", "link_name": "openvswitch", "list_id": "ovs-dev.openvswitch.org", "list_email": "ovs-dev@openvswitch.org", "web_url": "http://openvswitch.org/", "scm_url": "git@github.com:openvswitch/ovs.git", "webscm_url": "https://github.com/openvswitch/ovs", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504603381-30071-6-git-send-email-yliu@fridaylinux.org>", "list_archive_url": null, "date": "2017-09-05T09:22:58", "name": "[ovs-dev,v2,5/8] dpif-netdev: record rx queue id for the upcall", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "518b1faf2b307510bc144ca5e45bec03ee0009d5", "submitter": { "id": 72215, "url": "http://patchwork.ozlabs.org/api/people/72215/?format=api", "name": "Yuanhan Liu", "email": "yliu@fridaylinux.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/openvswitch/patch/1504603381-30071-6-git-send-email-yliu@fridaylinux.org/mbox/", "series": [ { "id": 1528, "url": "http://patchwork.ozlabs.org/api/series/1528/?format=api", "web_url": "http://patchwork.ozlabs.org/project/openvswitch/list/?series=1528", "date": "2017-09-05T09:22:53", "name": "OVS-DPDK flow offload with rte_flow", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/1528/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/810044/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/810044/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<ovs-dev-bounces@openvswitch.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "dev@openvswitch.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "ovs-dev@mail.linuxfoundation.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=fridaylinux-org.20150623.gappssmtp.com\n\theader.i=@fridaylinux-org.20150623.gappssmtp.com\n\theader.b=\"Hl5lUSHS\"; dkim-atps=neutral" ], "Received": [ "from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmhF66PYcz9s0g\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 5 Sep 2017 19:27:06 +1000 (AEST)", "from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id AD6B4B0C;\n\tTue, 5 Sep 2017 09:23:55 +0000 (UTC)", "from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 5B208B09\n\tfor <dev@openvswitch.org>; Tue, 5 Sep 2017 09:23:54 +0000 (UTC)", "from mail-pg0-f43.google.com (mail-pg0-f43.google.com\n\t[74.125.83.43])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id D0A4FE5\n\tfor <dev@openvswitch.org>; Tue, 5 Sep 2017 09:23:53 +0000 (UTC)", "by mail-pg0-f43.google.com with SMTP id t3so8163575pgt.0\n\tfor <dev@openvswitch.org>; Tue, 05 Sep 2017 02:23:53 -0700 (PDT)", "from localhost.localdomain ([101.228.204.163])\n\tby smtp.gmail.com with ESMTPSA id\n\ti187sm295921pfe.71.2017.09.05.02.23.48\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 05 Sep 2017 02:23:50 -0700 (PDT)" ], "X-Greylist": "whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=fridaylinux-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=HLU0tSQ9DxomrVsarSG+ny84LxBvcGdJ6aHShwgNGt4=;\n\tb=Hl5lUSHSZnZYjmuCk5ComUiK/o/pIDGx0X8LU/kO6aGSvl7gK+OvyxOfyMCVUHSf8t\n\tAAQL00+PJsWvDTTuKcmADYJGKAx9vr9Erb1PEGco6vuPtsn0enI/3AMTt6NX8OWlWdpW\n\taB12+KoUjsUbX9uJ6RxECOHl3hV57npG6mYTZqaUAG+cKAH/x3OBVRRVhRckhQ7QiCh6\n\tnVVwWFE4yeQ3E1i0sFy9Y9/Jttxfyk9jnYBdeSgrbXu1HISm+gF3XrJgl1CaA9C2H8Ub\n\tjRatUPRQGEFA9d5X0BKudsowX+ptacoPkOqOBZqLuFdM/V2sA7pJP1DIrx+vyXjLhMDt\n\tk4pA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=HLU0tSQ9DxomrVsarSG+ny84LxBvcGdJ6aHShwgNGt4=;\n\tb=IzYFmm06lK2EFkZd6Vs1jJyGQE+sF5AnK2mLdoXhm6udSn90MvcDEyPz+OBeWcsPy3\n\trnfZ+KU0zEK3N2ayfS4nR4y57IAK3GrGQPZ1MzNaT8gD7CnYs/q7beYGMSK4TcWp3OD1\n\tF4jNCXLbuSvor6c1iiEOHp8xUtBTUN5fthA4Bdx5HlMBMzObIi23hIzY9KMfAlYXRabI\n\teG4GoQnTvY5mo9L3ZYhlIPXgO/trQOK99rZYZoZA9yFz//jBxhES0sDwHa0Z1PiqyRAD\n\tDvlg1r62bG/4vOlDwWL5BCoFjy/5TWn+qDBQfL/KK/mkLOA5hkFb14DUsr+CsP5Ej2oz\n\tlarQ==", "X-Gm-Message-State": "AHPjjUhk99kqaErDKjHT6OH21QOtVxER2te3DEqxTCZlSCH1gmaH00pS\n\t1ZeYvm3QggKJXmapmTSwNHkx", "X-Google-Smtp-Source": "ADKCNb6EoYsgLnX9FXPUSbDVCFJ92Nj6qvXoxkPfe21T5ivAmiDFWwcflRAkTpNJDIibn6DKRGPJWw==", "X-Received": "by 10.84.240.140 with SMTP id z12mr3676233plk.18.1504603431325; \n\tTue, 05 Sep 2017 02:23:51 -0700 (PDT)", "From": "Yuanhan Liu <yliu@fridaylinux.org>", "To": "dev@openvswitch.org", "Date": "Tue, 5 Sep 2017 17:22:58 +0800", "Message-Id": "<1504603381-30071-6-git-send-email-yliu@fridaylinux.org>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1504603381-30071-1-git-send-email-yliu@fridaylinux.org>", "References": "<1504603381-30071-1-git-send-email-yliu@fridaylinux.org>", "X-Spam-Status": "No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1", "X-Spam-Checker-Version": "SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org", "Subject": "[ovs-dev] [PATCH v2 5/8] dpif-netdev: record rx queue id for the\n\tupcall", "X-BeenThere": "ovs-dev@openvswitch.org", "X-Mailman-Version": "2.1.12", "Precedence": "list", "List-Id": "<ovs-dev.openvswitch.org>", "List-Unsubscribe": "<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>", "List-Archive": "<http://mail.openvswitch.org/pipermail/ovs-dev/>", "List-Post": "<mailto:ovs-dev@openvswitch.org>", "List-Help": "<mailto:ovs-dev-request@openvswitch.org?subject=help>", "List-Subscribe": "<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "ovs-dev-bounces@openvswitch.org", "Errors-To": "ovs-dev-bounces@openvswitch.org" }, "content": "From: Shachar Beiser <shacharbe@mellanox.com>\n\nFor the DPDK flow offload, which basically just binds a MARK action to\na flow, the MARK is required to be used together with a QUEUE action for\nthe most NICs I'm aware of. The QUEUE action then needs a queue index,\nwhich is not given in the flow content.\n\nHere we record the rx queue while recieving the pkts to solve above issue.\n\nCo-authored-by: Yuanhan Liu <yliu@fridaylinux.org>\nSigned-off-by: Shachar Beiser <shacharbe@mellanox.com>\nSigned-off-by: Yuanhan Liu <yliu@fridaylinux.org>\n---\n lib/dp-packet.h | 1 +\n lib/dpif-netdev.c | 14 +++++++++-----\n lib/netdev.c | 1 +\n lib/netdev.h | 1 +\n 4 files changed, 12 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/dp-packet.h b/lib/dp-packet.h\nindex a7a062f..479a734 100644\n--- a/lib/dp-packet.h\n+++ b/lib/dp-packet.h\n@@ -709,6 +709,7 @@ enum { NETDEV_MAX_BURST = 32 }; /* Maximum number packets in a batch. */\n struct dp_packet_batch {\n size_t count;\n bool trunc; /* true if the batch needs truncate. */\n+ int rxq;\n struct dp_packet *packets[NETDEV_MAX_BURST];\n };\n \ndiff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c\nindex a95b8d4..3099c73 100644\n--- a/lib/dpif-netdev.c\n+++ b/lib/dpif-netdev.c\n@@ -2474,7 +2474,8 @@ out:\n static struct dp_netdev_flow *\n dp_netdev_flow_add(struct dp_netdev_pmd_thread *pmd,\n struct match *match, const ovs_u128 *ufid,\n- const struct nlattr *actions, size_t actions_len)\n+ const struct nlattr *actions, size_t actions_len,\n+ int rxq)\n OVS_REQUIRES(pmd->flow_mutex)\n {\n struct dp_netdev_flow *flow;\n@@ -2527,6 +2528,7 @@ dp_netdev_flow_add(struct dp_netdev_pmd_thread *pmd,\n dp_netdev_alloc_flow_mark(pmd, &info.flow_mark)) {\n struct dp_netdev_port *port;\n port = dp_netdev_lookup_port(pmd->dp, in_port);\n+ info.rxq = rxq;\n if (netdev_flow_put(port->netdev, match,\n CONST_CAST(struct nlattr *, actions),\n actions_len, ufid, &info, NULL) == 0) {\n@@ -2607,7 +2609,7 @@ flow_put_on_pmd(struct dp_netdev_pmd_thread *pmd,\n if (put->flags & DPIF_FP_CREATE) {\n if (cmap_count(&pmd->flow_table) < MAX_FLOWS) {\n dp_netdev_flow_add(pmd, match, ufid, put->actions,\n- put->actions_len);\n+ put->actions_len, -1);\n error = 0;\n } else {\n error = EFBIG;\n@@ -2635,6 +2637,7 @@ flow_put_on_pmd(struct dp_netdev_pmd_thread *pmd,\n in_port = netdev_flow->flow.in_port.odp_port;\n port = dp_netdev_lookup_port(pmd->dp, in_port);\n info.flow_mark = netdev_flow->mark;\n+ info.rxq = -1;\n ret = netdev_flow_put(port->netdev, match,\n CONST_CAST(struct nlattr *,\n put->actions),\n@@ -5026,7 +5029,7 @@ handle_packet_upcall(struct dp_netdev_pmd_thread *pmd,\n struct dp_packet *packet,\n const struct netdev_flow_key *key,\n struct ofpbuf *actions, struct ofpbuf *put_actions,\n- int *lost_cnt, long long now)\n+ int *lost_cnt, long long now, int rxq)\n {\n struct ofpbuf *add_actions;\n struct dp_packet_batch b;\n@@ -5082,7 +5085,8 @@ handle_packet_upcall(struct dp_netdev_pmd_thread *pmd,\n if (OVS_LIKELY(!netdev_flow)) {\n netdev_flow = dp_netdev_flow_add(pmd, &match, &ufid,\n add_actions->data,\n- add_actions->size);\n+ add_actions->size,\n+ rxq);\n }\n ovs_mutex_unlock(&pmd->flow_mutex);\n emc_probabilistic_insert(pmd, key, netdev_flow);\n@@ -5152,7 +5156,7 @@ fast_path_processing(struct dp_netdev_pmd_thread *pmd,\n \n miss_cnt++;\n handle_packet_upcall(pmd, packets[i], &keys[i], &actions,\n- &put_actions, &lost_cnt, now);\n+ &put_actions, &lost_cnt, now, packets_->rxq);\n }\n \n ofpbuf_uninit(&actions);\ndiff --git a/lib/netdev.c b/lib/netdev.c\nindex b4e570b..c9b7019 100644\n--- a/lib/netdev.c\n+++ b/lib/netdev.c\n@@ -700,6 +700,7 @@ netdev_rxq_recv(struct netdev_rxq *rx, struct dp_packet_batch *batch)\n \n retval = rx->netdev->netdev_class->rxq_recv(rx, batch);\n if (!retval) {\n+ batch->rxq = rx->queue_id;\n COVERAGE_INC(netdev_received);\n } else {\n batch->count = 0;\ndiff --git a/lib/netdev.h b/lib/netdev.h\nindex 2003165..28ad39d 100644\n--- a/lib/netdev.h\n+++ b/lib/netdev.h\n@@ -194,6 +194,7 @@ struct offload_info {\n * it will be in the pkt meta data.\n */\n uint32_t flow_mark;\n+ int rxq;\n };\n struct dpif_class;\n struct netdev_flow_dump;\n", "prefixes": [ "ovs-dev", "v2", "5/8" ] }