Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/809963/?format=api
{ "id": 809963, "url": "http://patchwork.ozlabs.org/api/patches/809963/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1504593066-14023-4-git-send-email-zhangchen.fnst@cn.fujitsu.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504593066-14023-4-git-send-email-zhangchen.fnst@cn.fujitsu.com>", "list_archive_url": null, "date": "2017-09-05T06:31:06", "name": "[V6,3/3] net/colo-compare.c: Fix comments and scheme", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ae322d293a565e4996825acb500cd40cf2948b41", "submitter": { "id": 67759, "url": "http://patchwork.ozlabs.org/api/people/67759/?format=api", "name": "Zhang Chen", "email": "zhangchen.fnst@cn.fujitsu.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1504593066-14023-4-git-send-email-zhangchen.fnst@cn.fujitsu.com/mbox/", "series": [ { "id": 1494, "url": "http://patchwork.ozlabs.org/api/series/1494/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1494", "date": "2017-09-05T06:31:03", "name": "Optimize COLO-compare performance", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/1494/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809963/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809963/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmcKb6j57z9sP3\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 5 Sep 2017 16:30:43 +1000 (AEST)", "from localhost ([::1]:57087 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dp7Ni-0003Fu-1v\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 02:30:42 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:57515)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <zhangchen.fnst@cn.fujitsu.com>) id 1dp7N7-00039L-Hd\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 02:30:10 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <zhangchen.fnst@cn.fujitsu.com>) id 1dp7N2-0006Ao-Oc\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 02:30:05 -0400", "from mail.cn.fujitsu.com ([183.91.158.132]:33561\n\thelo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <zhangchen.fnst@cn.fujitsu.com>) id 1dp7N1-00069o-UV\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 02:30:00 -0400", "from localhost (HELO cn.fujitsu.com) ([10.167.33.5])\n\tby heian.cn.fujitsu.com with ESMTP; 05 Sep 2017 14:29:58 +0800", "from G08CNEXCHPEKD02.g08.fujitsu.local (unknown [10.167.33.83])\n\tby cn.fujitsu.com (Postfix) with ESMTP id F18C1472554C;\n\tTue, 5 Sep 2017 14:29:57 +0800 (CST)", "from localhost.localdomain (10.167.226.56) by\n\tG08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP\n\tServer (TLS) id 14.3.361.1; Tue, 5 Sep 2017 14:29:56 +0800" ], "X-IronPort-AV": "E=Sophos;i=\"5.41,478,1498492800\"; d=\"scan'208\";a=\"25224697\"", "From": "Zhang Chen <zhangchen.fnst@cn.fujitsu.com>", "To": "qemu devel <qemu-devel@nongnu.org>, Jason Wang <jasowang@redhat.com>", "Date": "Tue, 5 Sep 2017 14:31:06 +0800", "Message-ID": "<1504593066-14023-4-git-send-email-zhangchen.fnst@cn.fujitsu.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1504593066-14023-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>", "References": "<1504593066-14023-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.167.226.56]", "X-yoursite-MailScanner-ID": "F18C1472554C.AD4DD", "X-yoursite-MailScanner": "Found to be clean", "X-yoursite-MailScanner-From": "zhangchen.fnst@cn.fujitsu.com", "X-detected-operating-system": "by eggs.gnu.org: Genre and OS details not\n\trecognized.", "X-Received-From": "183.91.158.132", "Subject": "[Qemu-devel] [PATCH V6 3/3] net/colo-compare.c: Fix comments and\n\tscheme", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Li Zhijian <lizhijian@cn.fujitsu.com>,\n\tZhang Chen <zhangchen.fnst@cn.fujitsu.com>,\n\tZhang Chen <zhangckid@gmail.com>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>\n---\n net/colo-compare.c | 59 ++++++++++++++++++++++++++++--------------------------\n 1 file changed, 31 insertions(+), 28 deletions(-)", "diff": "diff --git a/net/colo-compare.c b/net/colo-compare.c\nindex c31adc6..d5fcfea 100644\n--- a/net/colo-compare.c\n+++ b/net/colo-compare.c\n@@ -41,27 +41,27 @@\n #define REGULAR_PACKET_CHECK_MS 3000\n \n /*\n- + CompareState ++\n- | |\n- +---------------+ +---------------+ +---------------+\n- |conn list +--->conn +--------->conn |\n- +---------------+ +---------------+ +---------------+\n- | | | | | |\n- +---------------+ +---v----+ +---v----+ +---v----+ +---v----+\n- |primary | |secondary |primary | |secondary\n- |packet | |packet + |packet | |packet +\n- +--------+ +--------+ +--------+ +--------+\n- | | | |\n- +---v----+ +---v----+ +---v----+ +---v----+\n- |primary | |secondary |primary | |secondary\n- |packet | |packet + |packet | |packet +\n- +--------+ +--------+ +--------+ +--------+\n- | | | |\n- +---v----+ +---v----+ +---v----+ +---v----+\n- |primary | |secondary |primary | |secondary\n- |packet | |packet + |packet | |packet +\n- +--------+ +--------+ +--------+ +--------+\n-*/\n+ * + CompareState ++\n+ * | |\n+ * +---------------+ +---------------+ +---------------+\n+ * | conn list + - > conn + ------- > conn + -- > ......\n+ * +---------------+ +---------------+ +---------------+\n+ * | | | | | |\n+ * +---------------+ +---v----+ +---v----+ +---v----+ +---v----+\n+ * |primary | |secondary |primary | |secondary\n+ * |packet | |packet + |packet | |packet +\n+ * +--------+ +--------+ +--------+ +--------+\n+ * | | | |\n+ * +---v----+ +---v----+ +---v----+ +---v----+\n+ * |primary | |secondary |primary | |secondary\n+ * |packet | |packet + |packet | |packet +\n+ * +--------+ +--------+ +--------+ +--------+\n+ * | | | |\n+ * +---v----+ +---v----+ +---v----+ +---v----+\n+ * |primary | |secondary |primary | |secondary\n+ * |packet | |packet + |packet | |packet +\n+ * +--------+ +--------+ +--------+ +--------+\n+ */\n typedef struct CompareState {\n Object parent;\n \n@@ -75,14 +75,14 @@ typedef struct CompareState {\n SocketReadState sec_rs;\n bool vnet_hdr;\n \n- /* connection list: the connections belonged to this NIC could be found\n- * in this list.\n- * element type: Connection\n+ /*\n+ * Record the connection that through the NIC\n+ * Element type: Connection\n */\n GQueue conn_list;\n- /* hashtable to save connection */\n+ /* Record the connection without repetition */\n GHashTable *connection_track_table;\n- /* compare thread, a thread for each NIC */\n+ /* This thread just do packet compare job */\n QemuThread thread;\n \n GMainContext *worker_context;\n@@ -444,8 +444,11 @@ static int colo_old_packet_check_one_conn(Connection *conn,\n (GCompareFunc)colo_old_packet_check_one);\n \n if (result) {\n- /* do checkpoint will flush old packet */\n- /* TODO: colo_notify_checkpoint();*/\n+ /* Do checkpoint will flush old packet */\n+ /*\n+ * TODO: Notify colo frame to do checkpoint.\n+ * colo_compare_inconsistent_notify();\n+ */\n return 0;\n }\n \n", "prefixes": [ "V6", "3/3" ] }