Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/809952/?format=api
{ "id": 809952, "url": "http://patchwork.ozlabs.org/api/patches/809952/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/patch/20170905055202.8216-18-joel@jms.id.au/", "project": { "id": 44, "url": "http://patchwork.ozlabs.org/api/projects/44/?format=api", "name": "skiboot firmware development", "link_name": "skiboot", "list_id": "skiboot.lists.ozlabs.org", "list_email": "skiboot@lists.ozlabs.org", "web_url": "http://github.com/open-power/skiboot", "scm_url": "http://github.com/open-power/skiboot", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170905055202.8216-18-joel@jms.id.au>", "list_archive_url": null, "date": "2017-09-05T05:51:54", "name": "[17/25] hw/fsi-master: Fix whitespace before mfsi_opb_write calls", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "63a8c9086c24dd7dc38dec7fed7c8850d399f310", "submitter": { "id": 48628, "url": "http://patchwork.ozlabs.org/api/people/48628/?format=api", "name": "Joel Stanley", "email": "joel@jms.id.au" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/skiboot/patch/20170905055202.8216-18-joel@jms.id.au/mbox/", "series": [ { "id": 1492, "url": "http://patchwork.ozlabs.org/api/series/1492/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/list/?series=1492", "date": "2017-09-05T05:51:37", "name": "Checkpatch fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1492/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809952/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809952/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmbYv4l2Qz9ryv\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 5 Sep 2017 15:56:19 +1000 (AEST)", "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xmbYv3cwvzDrJl\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 5 Sep 2017 15:56:19 +1000 (AEST)", "from mail-pf0-x244.google.com (mail-pf0-x244.google.com\n\t[IPv6:2607:f8b0:400e:c00::244])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xmbWP4HpgzDrJq\n\tfor <skiboot@lists.ozlabs.org>; Tue, 5 Sep 2017 15:54:09 +1000 (AEST)", "by mail-pf0-x244.google.com with SMTP id a2so1206543pfj.4\n\tfor <skiboot@lists.ozlabs.org>; Mon, 04 Sep 2017 22:54:09 -0700 (PDT)", "from aurora.jms.id.au ([122.99.82.10])\n\tby smtp.gmail.com with ESMTPSA id\n\th27sm13073215pgn.18.2017.09.04.22.54.03\n\tfor <skiboot@lists.ozlabs.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 04 Sep 2017 22:54:05 -0700 (PDT)", "by aurora.jms.id.au (sSMTP sendmail emulation);\n\tTue, 05 Sep 2017 15:54:01 +1000" ], "Authentication-Results": [ "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"E6y3v10q\"; dkim-atps=neutral", "lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"E6y3v10q\"; dkim-atps=neutral", "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400e:c00::244; helo=mail-pf0-x244.google.com;\n\tenvelope-from=joel.stan@gmail.com; receiver=<UNKNOWN>)", "lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"E6y3v10q\"; dkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:subject:date:message-id:in-reply-to:references;\n\tbh=rdz6Dgbd6vrGE4sTVaA5O7/E47ZXJhnFebcrfEVFWw4=;\n\tb=E6y3v10q2J/7IpntrVHqOyHwPfSyMBoGlUZ+OB5nv/j22YpN5SKlr5qrQdODsP1HZk\n\tTI70WnsrbJ1AiCDEsKtlMlTI6lqFtgFik2+LwYFbmM39XajcT7DfHL4eGa///t7zlvm4\n\tnryPPSTGHzoX8nOlIw6ge/D0nAKYCKHb/M3oLxJWWWn9iwvRo9fzYDMKgm09y/nwZvHT\n\tzuBqtbJZalTa0ENQeKxc2JNnKwHuPpcVYMS1D5i2fqfjqxXiMeLmPXnvmFRkYn9hI7yI\n\tF6HWB3ZlBp8kZSkztmWOUnoJOf3AqGhIYGGNI7tlPgTZsgAwmBxm6k0RWbGvJN80/uNY\n\tcRmQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:subject:date:message-id\n\t:in-reply-to:references;\n\tbh=rdz6Dgbd6vrGE4sTVaA5O7/E47ZXJhnFebcrfEVFWw4=;\n\tb=uOE8WH8wOYsLVyPJc7HAdhHyXTzEMnf/FOoimO3S5ekWr020Li67xSaL0/3cJPqfMS\n\tXboifQ7+QEjWZUde7uOoCMRUz1hp28YbP0SqzjnCWvqa3r5ZEC9H81320AMXhWeVN7di\n\tbtx6EqORbRYH7BwHz324NPO0M6qa14yCMKamkv6X0fpZIozMbwCneLpm00esL4K5iZ79\n\tuM5wIqKvAY0bMkfTLIITHbMA/6Q2AWWE8ptsEDxhCZB/xWRJXoxbTYHZlx5/qosxcaeS\n\tSm/xwUn/axxhg/2haJ4HxyD5VMoSKivd5F4KnXyQsR1X2sU6tMl05M+tCMLogRo5ci38\n\t+tJw==", "X-Gm-Message-State": "AHPjjUhhQd5ANV1Y41f1F5NXmN+o3B2I4a9nG5gRq09wAiKDLQbYfM/2\n\tx+pvEesUe1uhHbtpuIY=", "X-Google-Smtp-Source": "ADKCNb5z3C8Y7RU+ECCYz5MYtFcawkYUYnRJwvZrGWXxidrd2g7P437+A9pN8sZLzuO1IqRC/o4B/A==", "X-Received": "by 10.99.144.68 with SMTP id a65mr2909150pge.429.1504590847267; \n\tMon, 04 Sep 2017 22:54:07 -0700 (PDT)", "From": "Joel Stanley <joel@jms.id.au>", "To": "skiboot@lists.ozlabs.org", "Date": "Tue, 5 Sep 2017 15:51:54 +1000", "Message-Id": "<20170905055202.8216-18-joel@jms.id.au>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20170905055202.8216-1-joel@jms.id.au>", "References": "<20170905055202.8216-1-joel@jms.id.au>", "Subject": "[Skiboot] [PATCH 17/25] hw/fsi-master: Fix whitespace before\n\tmfsi_opb_write calls", "X-BeenThere": "skiboot@lists.ozlabs.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "Mailing list for skiboot development <skiboot.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/skiboot/>", "List-Post": "<mailto:skiboot@lists.ozlabs.org>", "List-Help": "<mailto:skiboot-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "Signed-off-by: Joel Stanley <joel@jms.id.au>\n---\n hw/fsi-master.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/hw/fsi-master.c b/hw/fsi-master.c\nindex 4a16debd53f0..dadc7776d3be 100644\n--- a/hw/fsi-master.c\n+++ b/hw/fsi-master.c\n@@ -368,7 +368,7 @@ static int64_t mfsi_master_cleanup(struct mfsi *mfsi, uint32_t port)\n \n \t/* Perform error reset on Centaur fsi slave: */\n \t/* write 0x4000000 to addr=834 */\n- \topb_stat = mfsi_opb_write(mfsi, port_base + FSI_SLRES, 0x04000000);\n+\topb_stat = mfsi_opb_write(mfsi, port_base + FSI_SLRES, 0x04000000);\n \tif (opb_stat) {\n \t\tmfsi_log(PR_ERR, mfsi,\n \t\t\t \" OPB stat 0x%016llx writing reset to FSI slave\\n\",\n@@ -383,7 +383,7 @@ static int64_t mfsi_master_cleanup(struct mfsi *mfsi, uint32_t port)\n \t *\n \t * XXX BenH: Should that be done by the upper FSI XSCOM layer ?\n \t */\n- \topb_stat = mfsi_opb_write(mfsi, port_base + FSI2PIB_STATUS, 0xFFFFFFFF);\n+\topb_stat = mfsi_opb_write(mfsi, port_base + FSI2PIB_STATUS, 0xFFFFFFFF);\n \tif (opb_stat) {\n \t\tmfsi_log(PR_ERR, mfsi,\n \t\t\t \" OPB stat 0x%016llx clearing FSI2PIB_STATUS\\n\",\n@@ -394,14 +394,14 @@ static int64_t mfsi_master_cleanup(struct mfsi *mfsi, uint32_t port)\n \t/* Need to save/restore the true/comp masks or the FSP (PRD ?) will\n \t * get annoyed\n \t */\n- \topb_stat = mfsi_opb_read(mfsi, port_base + FSI2PIB_COMPMASK, &compmask);\n+\topb_stat = mfsi_opb_read(mfsi, port_base + FSI2PIB_COMPMASK, &compmask);\n \tif (opb_stat) {\n \t\tmfsi_log(PR_ERR, mfsi,\n \t\t\t \" OPB stat 0x%016llx reading FSI2PIB_COMPMASK\\n\",\n \t\t\t opb_stat);\n \t\treturn OPAL_HARDWARE;\n \t}\n- \topb_stat = mfsi_opb_read(mfsi, port_base + FSI2PIB_TRUEMASK, &truemask);\n+\topb_stat = mfsi_opb_read(mfsi, port_base + FSI2PIB_TRUEMASK, &truemask);\n \tif (opb_stat) {\n \t\tmfsi_log(PR_ERR, mfsi,\n \t\t\t \" OPB stat 0x%016llx reading FSI2PIB_TRUEMASK\\n\",\n@@ -412,7 +412,7 @@ static int64_t mfsi_master_cleanup(struct mfsi *mfsi, uint32_t port)\n \t/* Then, write arbitrary data to 1018 (putcfam 1006) to\n * reset any pending FSI2PIB errors.\n \t */\n- \topb_stat = mfsi_opb_write(mfsi, port_base + FSI2PIB_RESET, 0xFFFFFFFF);\n+\topb_stat = mfsi_opb_write(mfsi, port_base + FSI2PIB_RESET, 0xFFFFFFFF);\n \tif (opb_stat) {\n \t\tmfsi_log(PR_ERR, mfsi,\n \t\t\t \" OPB stat 0x%016llx writing FSI2PIB_RESET\\n\",\n@@ -421,14 +421,14 @@ static int64_t mfsi_master_cleanup(struct mfsi *mfsi, uint32_t port)\n \t}\n \n \t/* Restore the true/comp masks */\n- \topb_stat = mfsi_opb_write(mfsi, port_base + FSI2PIB_COMPMASK, compmask);\n+\topb_stat = mfsi_opb_write(mfsi, port_base + FSI2PIB_COMPMASK, compmask);\n \tif (opb_stat) {\n \t\tmfsi_log(PR_ERR, mfsi,\n \t\t\t \" OPB stat 0x%016llx writing FSI2PIB_COMPMASK\\n\",\n \t\t\t opb_stat);\n \t\treturn OPAL_HARDWARE;\n \t}\n- \topb_stat = mfsi_opb_write(mfsi, port_base + FSI2PIB_TRUEMASK, truemask);\n+\topb_stat = mfsi_opb_write(mfsi, port_base + FSI2PIB_TRUEMASK, truemask);\n \tif (opb_stat) {\n \t\tmfsi_log(PR_ERR, mfsi,\n \t\t\t \" OPB stat 0x%016llx writing FSI2PIB_TRUEMASK\\n\",\n", "prefixes": [ "17/25" ] }