Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/809885/?format=api
{ "id": 809885, "url": "http://patchwork.ozlabs.org/api/patches/809885/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20170905011939.5794-2-xypron.glpk@gmx.de/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170905011939.5794-2-xypron.glpk@gmx.de>", "list_archive_url": null, "date": "2017-09-05T01:19:37", "name": "[U-Boot,1/3] efi_loader: rename __efi_hello_world_*", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7147fa5e57a0666fd55a767ffcd86228cc85a3dd", "submitter": { "id": 61270, "url": "http://patchwork.ozlabs.org/api/people/61270/?format=api", "name": "Heinrich Schuchardt", "email": "xypron.glpk@gmx.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20170905011939.5794-2-xypron.glpk@gmx.de/mbox/", "series": [ { "id": 1475, "url": "http://patchwork.ozlabs.org/api/series/1475/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=1475", "date": "2017-09-05T01:19:36", "name": "Clean up make process for EFI payload", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1475/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809885/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809885/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmTSZ43DRz9s7f\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 5 Sep 2017 11:21:18 +1000 (AEST)", "by lists.denx.de (Postfix, from userid 105)\n\tid 0F285C21F2F; Tue, 5 Sep 2017 01:20:56 +0000 (UTC)", "from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 30917C21F4E;\n\tTue, 5 Sep 2017 01:20:54 +0000 (UTC)", "by lists.denx.de (Postfix, from userid 105)\n\tid 62215C21F4A; Tue, 5 Sep 2017 01:20:43 +0000 (UTC)", "from mout.gmx.net (mout.gmx.net [212.227.15.19])\n\tby lists.denx.de (Postfix) with ESMTPS id 53796C21DA0\n\tfor <u-boot@lists.denx.de>; Tue, 5 Sep 2017 01:20:40 +0000 (UTC)", "from laptop1.fritz.box ([94.197.121.125]) by mail.gmx.com (mrgmx001\n\t[212.227.17.184]) with ESMTPSA (Nemesis) id 0LiTm8-1dCOrj1aCS-00cesU;\n\tTue, 05 Sep 2017 03:20:31 +0200" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-0.7 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no\n\tversion=3.4.0", "From": "Heinrich Schuchardt <xypron.glpk@gmx.de>", "To": "Alexander Graf <agraf@suse.de>", "Date": "Tue, 5 Sep 2017 03:19:37 +0200", "Message-Id": "<20170905011939.5794-2-xypron.glpk@gmx.de>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20170905011939.5794-1-xypron.glpk@gmx.de>", "References": "<20170905011939.5794-1-xypron.glpk@gmx.de>", "X-Provags-ID": "V03:K0:DSrBC8PJkz2cgzGndRFWk5tULb1RNY7++TLAVZvu5yEMH8yFjW8\n\t+FEKb8IsdqSS41F7mNrJxGCQY2iALCeGCT2+qzJOBg3H7JetEwvpttONz6KvmfjntRq8TOI\n\tuyj0ZumuCOLoj4HQxvwMZP9x3geMla+tTQtm0AAia0uh1pkfgNGOQ2426HmAAkP38yQdpc2\n\tjnDMTe1/NSDMBhmOkzStQ==", "X-UI-Out-Filterresults": "notjunk:1; V01:K0:nHSIx4zoGd0=:8kvqA2NZXArpichC59No5x\n\tCNgCB29mMg2yxt3ha15KXsZJ2wMXVnChur+MNyr+yKRbCSEapXNDzzSWPoMAErfcVp4ktny0/\n\tvW92GjppsgLKydpoRwF1EN01t6SOVuCoI+1ZKqjUboTXordPh8IpvKn5KxI1LKVbdZJkmYwbF\n\t5gFBzej6gofGaKi+9B4/p8+gP84QX9aouLKJOMSCl68oZjgddX0lbtBCPb2XcBVwBMEmZs5iM\n\tzSt82VM0Ag7ug0V9WLsy5SSTQ3ifm8F9qVY+kHPQm/ziSd/5+gja476/RPUqP3ccUzUpu+Nd8\n\t9ec1FqnckQdDRfL2zdeFokJcvH1C8V2kZSPSuFw5BNDaOKwVlPDsZliTb4mDMyKB4bpYmv206\n\t5CTdxZoF/Ye4LYdcdPdML7CbY1vL+bOHvwU1kVoZCJ9d4GRneFpr3exBY6TjLlY5zsuYHAegt\n\tKnZ+cLeAyEYoNYBDXxW6lmjvahmp7WL1XspvyLk31N2L0trHZDmRcox4f7PQlWRkbW5ecYDkS\n\tyV0YcJyB1PoDaaIzBPij5U947X+JTUlum3r3jW5ro4T51LXpOPfHxa9R1EDdzDAifYS1MzhmH\n\t+ENrKoysp1vPHyZV0Xg2j3YbkMebehJ2plu1z42xmPJX+qsXXCmzAtvoycXpWN5GDPTUcUKM9\n\t1fCC8wja0vIvS24smdNXv5HVID7ub/NbID97dPmVLPPaDJmDLBtsRPWqEUh6m/g0Nr8XheXa0\n\tfTCG8/fzhZR97iyYqiX+Y4cD3sR7PBEq7QJjpn/YpW1Ab8cs3BVGmGkSPhqpbBHSZ7lnGP4Zn\n\tu8Aj8Le6N0Sk+9v8kFRcuUkQNNRXxaFSzC3ok6bqtg8rWI6e0w=", "Cc": "Mark Kettenis <kettenis@openbsd.org>,\n\tHeinrich Schuchardt <xypron.glpk@gmx.de>,\n\tAndy Shevchenko <andriy.shevchenko@linux.intel.com>, u-boot@lists.denx.de", "Subject": "[U-Boot] [PATCH 1/3] efi_loader: rename __efi_hello_world_*", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.18", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<http://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>" }, "content": "In scripts/Makefile.lib we build section including helloworld.efi.\nThis allows to load the EFI binary with command 'bootefi hello'.\n\nscripts/Makefile.lib contains explicit references to strings\ncontaining helloworld and hello_world. This makes it impossible\nto generalize the coding to accomodate additional built in\nEFI binaries.\n\nLet us rename the variables __efi_hello_world_* to\n__efi_helloworld_*.\n\nSigned-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>\n---\n cmd/bootefi.c | 4 ++--\n include/asm-generic/sections.h | 4 ++--\n scripts/Makefile.lib | 8 ++++----\n 3 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/cmd/bootefi.c b/cmd/bootefi.c\nindex a3768158a2..c5bfab1147 100644\n--- a/cmd/bootefi.c\n+++ b/cmd/bootefi.c\n@@ -298,14 +298,14 @@ static int do_bootefi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])\n \t\treturn CMD_RET_USAGE;\n #ifdef CONFIG_CMD_BOOTEFI_HELLO\n \tif (!strcmp(argv[1], \"hello\")) {\n-\t\tulong size = __efi_hello_world_end - __efi_hello_world_begin;\n+\t\tulong size = __efi_helloworld_end - __efi_helloworld_begin;\n \n \t\tsaddr = env_get(\"loadaddr\");\n \t\tif (saddr)\n \t\t\taddr = simple_strtoul(saddr, NULL, 16);\n \t\telse\n \t\t\taddr = CONFIG_SYS_LOAD_ADDR;\n-\t\tmemcpy((char *)addr, __efi_hello_world_begin, size);\n+\t\tmemcpy((char *)addr, __efi_helloworld_begin, size);\n \t} else\n #endif\n \t{\ndiff --git a/include/asm-generic/sections.h b/include/asm-generic/sections.h\nindex daf021b647..b6535705a5 100644\n--- a/include/asm-generic/sections.h\n+++ b/include/asm-generic/sections.h\n@@ -22,8 +22,8 @@ extern char __kprobes_text_start[], __kprobes_text_end[];\n extern char __entry_text_start[], __entry_text_end[];\n extern char __initdata_begin[], __initdata_end[];\n extern char __start_rodata[], __end_rodata[];\n-extern char __efi_hello_world_begin[];\n-extern char __efi_hello_world_end[];\n+extern char __efi_helloworld_begin[];\n+extern char __efi_helloworld_end[];\n \n /* Start and end of .ctors section - used for constructor calls. */\n extern char __ctors_start[], __ctors_end[];\ndiff --git a/scripts/Makefile.lib b/scripts/Makefile.lib\nindex 7f97e8ebf3..164c234b4c 100644\n--- a/scripts/Makefile.lib\n+++ b/scripts/Makefile.lib\n@@ -350,11 +350,11 @@ cmd_S_efi=\t\t\t\t\t\t\\\n (\t\t\t\t\t\t\t\\\n \techo '.section .rodata.efi.init,\"a\"';\t\t\\\n \techo '.balign 16';\t\t\t\t\\\n-\techo '.global __efi_hello_world_begin';\t\t\\\n-\techo '__efi_hello_world_begin:';\t\t\\\n+\techo '.global __efi_helloworld_begin';\t\t\\\n+\techo '__efi_helloworld_begin:';\t\t\\\n \techo '.incbin \"$<\" ';\t\t\t\t\\\n-\techo '__efi_hello_world_end:';\t\t\t\\\n-\techo '.global __efi_hello_world_end';\t\t\\\n+\techo '__efi_helloworld_end:';\t\t\t\\\n+\techo '.global __efi_helloworld_end';\t\t\\\n \techo '.balign 16';\t\t\t\t\\\n ) > $@\n \n", "prefixes": [ "U-Boot", "1/3" ] }