Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/809741/?format=api
{ "id": 809741, "url": "http://patchwork.ozlabs.org/api/patches/809741/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170904154316.4148-8-david@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170904154316.4148-8-david@redhat.com>", "list_archive_url": null, "date": "2017-09-04T15:43:04", "name": "[v2,07/19] s390x: move two function declarations to s390-virtio-ccw.h", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "783e3af9c79e3bb0375b36fd03ff490a0a114964", "submitter": { "id": 70402, "url": "http://patchwork.ozlabs.org/api/people/70402/?format=api", "name": "David Hildenbrand", "email": "david@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170904154316.4148-8-david@redhat.com/mbox/", "series": [ { "id": 1412, "url": "http://patchwork.ozlabs.org/api/series/1412/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1412", "date": "2017-09-04T15:42:57", "name": "s390x cleanups and CPU hotplug via device_add", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/1412/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809741/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809741/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmDqS6vnsz9sNq\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 5 Sep 2017 01:51:48 +1000 (AEST)", "from localhost ([::1]:54531 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dotf9-0002L2-2o\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 11:51:47 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:37589)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dotXN-0004TJ-Mr\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:43:50 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dotXJ-00010D-2N\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:43:45 -0400", "from mx1.redhat.com ([209.132.183.28]:54088)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <david@redhat.com>) id 1dotXI-0000zU-Sg\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 11:43:40 -0400", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E1B87404304;\n\tMon, 4 Sep 2017 15:43:39 +0000 (UTC)", "from t460s.redhat.com (ovpn-116-139.ams2.redhat.com\n\t[10.36.116.139])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id D64BFBF672;\n\tMon, 4 Sep 2017 15:43:35 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com E1B87404304", "From": "David Hildenbrand <david@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 4 Sep 2017 17:43:04 +0200", "Message-Id": "<20170904154316.4148-8-david@redhat.com>", "In-Reply-To": "<20170904154316.4148-1-david@redhat.com>", "References": "<20170904154316.4148-1-david@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tMon, 04 Sep 2017 15:43:40 +0000 (UTC)", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v2 07/19] s390x: move two function declarations\n\tto s390-virtio-ccw.h", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "thuth@redhat.com, Eduardo Habkost <ehabkost@redhat.com>, david@redhat.com,\n\tcohuck@redhat.com, Richard Henderson <richard.henderson@linaro.org>, \n\tAlexander Graf <agraf@suse.de>, borntraeger@de.ibm.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "We can also drop the extern. Fix up includes.\n\nSigned-off-by: David Hildenbrand <david@redhat.com>\n---\n include/hw/s390x/s390-virtio-ccw.h | 3 +++\n target/s390x/cpu.h | 2 --\n target/s390x/diag.c | 1 +\n target/s390x/interrupt.c | 3 +++\n 4 files changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/hw/s390x/s390-virtio-ccw.h b/include/hw/s390x/s390-virtio-ccw.h\nindex 41a9d2862b..42f2ccdb43 100644\n--- a/include/hw/s390x/s390-virtio-ccw.h\n+++ b/include/hw/s390x/s390-virtio-ccw.h\n@@ -56,4 +56,7 @@ bool gs_allowed(void);\n */\n bool css_migration_enabled(void);\n \n+S390CPU *s390_cpu_addr2state(uint16_t cpu_addr);\n+void subsystem_reset(void);\n+\n #endif\ndiff --git a/target/s390x/cpu.h b/target/s390x/cpu.h\nindex 2343f2f1f7..6c0abb9894 100644\n--- a/target/s390x/cpu.h\n+++ b/target/s390x/cpu.h\n@@ -720,8 +720,6 @@ int s390_cpu_virt_mem_rw(S390CPU *cpu, vaddr laddr, uint8_t ar, void *hostbuf,\n \n \n /* outside of target/s390x/ */\n-S390CPU *s390_cpu_addr2state(uint16_t cpu_addr);\n-extern void subsystem_reset(void);\n int sclp_service_call(CPUS390XState *env, uint64_t sccb, uint32_t code);\n \n #endif\ndiff --git a/target/s390x/diag.c b/target/s390x/diag.c\nindex e6b5e6de37..82a623948d 100644\n--- a/target/s390x/diag.c\n+++ b/target/s390x/diag.c\n@@ -20,6 +20,7 @@\n #include \"hw/watchdog/wdt_diag288.h\"\n #include \"sysemu/cpus.h\"\n #include \"hw/s390x/ipl.h\"\n+#include \"hw/s390x/s390-virtio-ccw.h\"\n \n static int modified_clear_reset(S390CPU *cpu)\n {\ndiff --git a/target/s390x/interrupt.c b/target/s390x/interrupt.c\nindex 058e219fe5..9aa6b89301 100644\n--- a/target/s390x/interrupt.c\n+++ b/target/s390x/interrupt.c\n@@ -15,6 +15,9 @@\n #include \"exec/exec-all.h\"\n #include \"sysemu/kvm.h\"\n #include \"hw/s390x/ioinst.h\"\n+#if !defined(CONFIG_USER_ONLY)\n+#include \"hw/s390x/s390-virtio-ccw.h\"\n+#endif\n \n /* Ensure to exit the TB after this call! */\n void trigger_pgm_exception(CPUS390XState *env, uint32_t code, uint32_t ilen)\n", "prefixes": [ "v2", "07/19" ] }