Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/809637/?format=api
{ "id": 809637, "url": "http://patchwork.ozlabs.org/api/patches/809637/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1504527967-29248-13-git-send-email-peter.maydell@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504527967-29248-13-git-send-email-peter.maydell@linaro.org>", "list_archive_url": null, "date": "2017-09-04T12:25:43", "name": "[PULL,12/36] target/arm: Don't calculate lr in arm_v7m_cpu_do_interrupt() until needed", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f63d3841117cfc0e8d56001b92d81b7021b8e04b", "submitter": { "id": 5111, "url": "http://patchwork.ozlabs.org/api/people/5111/?format=api", "name": "Peter Maydell", "email": "peter.maydell@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1504527967-29248-13-git-send-email-peter.maydell@linaro.org/mbox/", "series": [ { "id": 1366, "url": "http://patchwork.ozlabs.org/api/series/1366/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1366", "date": "2017-09-04T12:25:36", "name": "[PULL,01/36] target/arm: Use MMUAccessType enum rather than int", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1366/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809637/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809637/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm8Qk0XZcz9t32\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 4 Sep 2017 22:33:34 +1000 (AEST)", "from localhost ([::1]:59566 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1doqZI-0001aR-2y\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 08:33:32 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:52439)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <pm215@archaic.org.uk>) id 1doqSK-0004uN-93\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 08:26:34 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <pm215@archaic.org.uk>) id 1doqS9-0004jD-1N\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 08:26:20 -0400", "from orth.archaic.org.uk ([2001:8b0:1d0::2]:37112)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <pm215@archaic.org.uk>)\n\tid 1doqS8-0004ia-QO\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 08:26:08 -0400", "from pm215 by orth.archaic.org.uk with local (Exim 4.89)\n\t(envelope-from <pm215@archaic.org.uk>) id 1doqS7-0005UZ-RO\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 13:26:07 +0100" ], "From": "Peter Maydell <peter.maydell@linaro.org>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 4 Sep 2017 13:25:43 +0100", "Message-Id": "<1504527967-29248-13-git-send-email-peter.maydell@linaro.org>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1504527967-29248-1-git-send-email-peter.maydell@linaro.org>", "References": "<1504527967-29248-1-git-send-email-peter.maydell@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-detected-operating-system": "by eggs.gnu.org: Genre and OS details not\n\trecognized.", "X-Received-From": "2001:8b0:1d0::2", "Subject": "[Qemu-devel] [PULL 12/36] target/arm: Don't calculate lr in\n\tarm_v7m_cpu_do_interrupt() until needed", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Move the code in arm_v7m_cpu_do_interrupt() that calculates the\nmagic LR value down to when we're actually going to use it.\nHaving the calculation and use so far apart makes the code\na little harder to understand than it needs to be.\n\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\nReviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\nReviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nMessage-id: 1501692241-23310-13-git-send-email-peter.maydell@linaro.org\n---\n target/arm/helper.c | 15 ++++++++-------\n 1 file changed, 8 insertions(+), 7 deletions(-)", "diff": "diff --git a/target/arm/helper.c b/target/arm/helper.c\nindex 9410856..267a170 100644\n--- a/target/arm/helper.c\n+++ b/target/arm/helper.c\n@@ -6306,13 +6306,6 @@ void arm_v7m_cpu_do_interrupt(CPUState *cs)\n \n arm_log_exception(cs->exception_index);\n \n- lr = 0xfffffff1;\n- if (env->v7m.control & R_V7M_CONTROL_SPSEL_MASK) {\n- lr |= 4;\n- }\n- if (env->v7m.exception == 0)\n- lr |= 8;\n-\n /* For exceptions we just mark as pending on the NVIC, and let that\n handle it. */\n switch (cs->exception_index) {\n@@ -6403,6 +6396,14 @@ void arm_v7m_cpu_do_interrupt(CPUState *cs)\n return; /* Never happens. Keep compiler happy. */\n }\n \n+ lr = 0xfffffff1;\n+ if (env->v7m.control & R_V7M_CONTROL_SPSEL_MASK) {\n+ lr |= 4;\n+ }\n+ if (env->v7m.exception == 0) {\n+ lr |= 8;\n+ }\n+\n v7m_push_stack(cpu);\n v7m_exception_taken(cpu, lr);\n qemu_log_mask(CPU_LOG_INT, \"... as %d\\n\", env->v7m.exception);\n", "prefixes": [ "PULL", "12/36" ] }