Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/809634/?format=api
{ "id": 809634, "url": "http://patchwork.ozlabs.org/api/patches/809634/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1504527967-29248-3-git-send-email-peter.maydell@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504527967-29248-3-git-send-email-peter.maydell@linaro.org>", "list_archive_url": null, "date": "2017-09-04T12:25:33", "name": "[PULL,02/36] target/arm: Don't trap WFI/WFE for M profile", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9c02dc763c718919a99fcaad4f590bb6595a5770", "submitter": { "id": 5111, "url": "http://patchwork.ozlabs.org/api/people/5111/?format=api", "name": "Peter Maydell", "email": "peter.maydell@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/1504527967-29248-3-git-send-email-peter.maydell@linaro.org/mbox/", "series": [ { "id": 1366, "url": "http://patchwork.ozlabs.org/api/series/1366/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1366", "date": "2017-09-04T12:25:36", "name": "[PULL,01/36] target/arm: Use MMUAccessType enum rather than int", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1366/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809634/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809634/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm8QT6T2lz9t32\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 4 Sep 2017 22:33:21 +1000 (AEST)", "from localhost ([::1]:59563 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1doqZ5-0001Pg-Tr\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 08:33:20 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:52301)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <pm215@archaic.org.uk>) id 1doqSD-0004qS-CC\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 08:26:29 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <pm215@archaic.org.uk>) id 1doqS3-0004cb-IL\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 08:26:13 -0400", "from orth.archaic.org.uk ([2001:8b0:1d0::2]:37106)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <pm215@archaic.org.uk>)\n\tid 1doqS3-0004Yp-BM\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 08:26:03 -0400", "from pm215 by orth.archaic.org.uk with local (Exim 4.89)\n\t(envelope-from <pm215@archaic.org.uk>) id 1doqRt-0005Pu-Rz\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 13:25:53 +0100" ], "From": "Peter Maydell <peter.maydell@linaro.org>", "To": "qemu-devel@nongnu.org", "Date": "Mon, 4 Sep 2017 13:25:33 +0100", "Message-Id": "<1504527967-29248-3-git-send-email-peter.maydell@linaro.org>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1504527967-29248-1-git-send-email-peter.maydell@linaro.org>", "References": "<1504527967-29248-1-git-send-email-peter.maydell@linaro.org>", "X-detected-operating-system": "by eggs.gnu.org: Genre and OS details not\n\trecognized.", "X-Received-From": "2001:8b0:1d0::2", "Subject": "[Qemu-devel] [PULL 02/36] target/arm: Don't trap WFI/WFE for M\n\tprofile", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "M profile cores can never trap on WFI or WFE instructions. Check for\nM profile in check_wfx_trap() to ensure this.\n\nThe existing code will do the right thing for v7M cores because\nthe hcr_el2 and scr_el3 registers will be all-zeroes and so we\nwon't attempt to trap, but when we start setting ARM_FEATURE_V8\nfor v8M cores the v8A handling of SCTLR.nTWE and .nTWI will not\ngive the right results.\n\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\nReviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nMessage-id: 1501692241-23310-3-git-send-email-peter.maydell@linaro.org\n---\n target/arm/op_helper.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/target/arm/op_helper.c b/target/arm/op_helper.c\nindex 2a85666..5a94a5f 100644\n--- a/target/arm/op_helper.c\n+++ b/target/arm/op_helper.c\n@@ -370,6 +370,11 @@ static inline int check_wfx_trap(CPUARMState *env, bool is_wfe)\n int cur_el = arm_current_el(env);\n uint64_t mask;\n \n+ if (arm_feature(env, ARM_FEATURE_M)) {\n+ /* M profile cores can never trap WFI/WFE. */\n+ return 0;\n+ }\n+\n /* If we are currently in EL0 then we need to check if SCTLR is set up for\n * WFx instructions being trapped to EL1. These trap bits don't exist in v7.\n */\n", "prefixes": [ "PULL", "02/36" ] }