Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/809622/?format=api
{ "id": 809622, "url": "http://patchwork.ozlabs.org/api/patches/809622/?format=api", "web_url": "http://patchwork.ozlabs.org/project/fwts/patch/20170904121421.12537-1-colin.king@canonical.com/", "project": { "id": 24, "url": "http://patchwork.ozlabs.org/api/projects/24/?format=api", "name": "Firmware Test Suite development", "link_name": "fwts", "list_id": "fwts-devel.lists.ubuntu.com", "list_email": "fwts-devel@lists.ubuntu.com", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170904121421.12537-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2017-09-04T12:14:21", "name": "src/acpi/brightness: constify sys_path and return of brightness_get_path", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0892de6337b91c88bede0b91c28bff31359bf547", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/fwts/patch/20170904121421.12537-1-colin.king@canonical.com/mbox/", "series": [ { "id": 1364, "url": "http://patchwork.ozlabs.org/api/series/1364/?format=api", "web_url": "http://patchwork.ozlabs.org/project/fwts/list/?series=1364", "date": "2017-09-04T12:14:21", "name": "src/acpi/brightness: constify sys_path and return of brightness_get_path", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1364/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809622/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809622/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<fwts-devel-bounces@lists.ubuntu.com>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=<UNKNOWN>)", "Received": [ "from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xm80d52m4z9sNq;\n\tMon, 4 Sep 2017 22:14:25 +1000 (AEST)", "from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from <fwts-devel-bounces@lists.ubuntu.com>)\n\tid 1doqGm-0004IT-Ay; Mon, 04 Sep 2017 12:14:24 +0000", "from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from <colin.king@canonical.com>)\n\tid 1doqGk-0004IE-J8\n\tfor fwts-devel@lists.ubuntu.com; Mon, 04 Sep 2017 12:14:22 +0000", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1doqGk-00062j-9R; Mon, 04 Sep 2017 12:14:22 +0000" ], "From": "Colin King <colin.king@canonical.com>", "To": "fwts-devel@lists.ubuntu.com", "Subject": "[PATCH] src/acpi/brightness: constify sys_path and return of\n\tbrightness_get_path", "Date": "Mon, 4 Sep 2017 13:14:21 +0100", "Message-Id": "<20170904121421.12537-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.14.1", "MIME-Version": "1.0", "X-BeenThere": "fwts-devel@lists.ubuntu.com", "X-Mailman-Version": "2.1.20", "Precedence": "list", "List-Id": "Firmware Test Suite Development <fwts-devel.lists.ubuntu.com>", "List-Unsubscribe": "<https://lists.ubuntu.com/mailman/options/fwts-devel>,\n\t<mailto:fwts-devel-request@lists.ubuntu.com?subject=unsubscribe>", "List-Archive": "<https://lists.ubuntu.com/archives/fwts-devel>", "List-Post": "<mailto:fwts-devel@lists.ubuntu.com>", "List-Help": "<mailto:fwts-devel-request@lists.ubuntu.com?subject=help>", "List-Subscribe": "<https://lists.ubuntu.com/mailman/listinfo/fwts-devel>,\n\t<mailto:fwts-devel-request@lists.ubuntu.com?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "fwts-devel-bounces@lists.ubuntu.com", "Sender": "\"fwts-devel\" <fwts-devel-bounces@lists.ubuntu.com>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nAdd in a couple of constifications to some static data\n\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n src/acpi/brightness/brightness-helper.c | 6 +++---\n src/acpi/brightness/brightness-helper.h | 2 +-\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/acpi/brightness/brightness-helper.c b/src/acpi/brightness/brightness-helper.c\nindex bfadd22c..58a55538 100644\n--- a/src/acpi/brightness/brightness-helper.c\n+++ b/src/acpi/brightness/brightness-helper.c\n@@ -32,7 +32,7 @@\n */\n \n static DIR *brightness_dir;\n-static char *brightness_path;\n+static const char *brightness_path;\n \n /*\n * brightness_get_dir()\n@@ -47,7 +47,7 @@ DIR *brightness_get_dir(void)\n * brightness_get_path()\n *\n */\n-char *brightness_get_path(void)\n+const char *brightness_get_path(void)\n {\n \treturn brightness_path;\n }\n@@ -60,7 +60,7 @@ char *brightness_get_path(void)\n int brightness_init(fwts_framework *fw)\n {\n \tint i;\n-\tstatic char *sys_path[] = {\n+\tstatic const char *sys_path[] = {\n \t\t\"/sys/class/backlight\",\n \t\t\"/sys/devices/virtual/backlight\",\n \t\tNULL\ndiff --git a/src/acpi/brightness/brightness-helper.h b/src/acpi/brightness/brightness-helper.h\nindex fb60204e..9d12ba8b 100644\n--- a/src/acpi/brightness/brightness-helper.h\n+++ b/src/acpi/brightness/brightness-helper.h\n@@ -24,7 +24,7 @@\n #include <dirent.h>\n \n DIR *brightness_get_dir(void);\n-char *brightness_get_path(void);\n+const char *brightness_get_path(void);\n int brightness_init(fwts_framework *fw);\n int brightness_deinit(fwts_framework *fw);\n int brightness_get_setting(const char *entry_name, const char *setting, int *value);\n", "prefixes": [] }