Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 809411,
    "url": "http://patchwork.ozlabs.org/api/patches/809411/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1504477763-12205-2-git-send-email-pablo@netfilter.org/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<1504477763-12205-2-git-send-email-pablo@netfilter.org>",
    "list_archive_url": null,
    "date": "2017-09-03T22:28:57",
    "name": "[21/47] netfilter: xtables: Remove unused variable in compat_copy_entry_from_user()",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "03efe73bbce14aea95ac10f4deff6c13d71201cf",
    "submitter": {
        "id": 1315,
        "url": "http://patchwork.ozlabs.org/api/people/1315/?format=api",
        "name": "Pablo Neira Ayuso",
        "email": "pablo@netfilter.org"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1504477763-12205-2-git-send-email-pablo@netfilter.org/mbox/",
    "series": [
        {
            "id": 1281,
            "url": "http://patchwork.ozlabs.org/api/series/1281/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=1281",
            "date": "2017-09-03T22:25:42",
            "name": "[01/47] netfilter: expect: add to hash table after expect init",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/1281/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/809411/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/809411/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlnj13wfYz9s06\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon,  4 Sep 2017 08:29:41 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753184AbdICW3j (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSun, 3 Sep 2017 18:29:39 -0400",
            "from mail.us.es ([193.147.175.20]:51460 \"EHLO mail.us.es\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1753111AbdICW3h (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tSun, 3 Sep 2017 18:29:37 -0400",
            "from antivirus1-rhel7.int (unknown [192.168.2.11])\n\tby mail.us.es (Postfix) with ESMTP id 77A86190F62\n\tfor <netdev@vger.kernel.org>; Mon,  4 Sep 2017 00:29:10 +0200 (CEST)",
            "from antivirus1-rhel7.int (localhost [127.0.0.1])\n\tby antivirus1-rhel7.int (Postfix) with ESMTP id 67D21CE372\n\tfor <netdev@vger.kernel.org>; Mon,  4 Sep 2017 00:29:10 +0200 (CEST)",
            "by antivirus1-rhel7.int (Postfix, from userid 99)\n\tid 5D96A2DC84; Mon,  4 Sep 2017 00:29:10 +0200 (CEST)",
            "from antivirus1-rhel7.int (localhost [127.0.0.1])\n\tby antivirus1-rhel7.int (Postfix) with ESMTP id 5540BB5028;\n\tMon,  4 Sep 2017 00:29:08 +0200 (CEST)",
            "from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int\n\t(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); \n\tMon, 04 Sep 2017 00:29:08 +0200 (CEST)",
            "from salvia.here (unknown [31.4.193.113])\n\t(Authenticated sender: pneira@us.es)\n\tby entrada.int (Postfix) with ESMTPA id 02E9F4265A20;\n\tMon,  4 Sep 2017 00:29:07 +0200 (CEST)"
        ],
        "X-Spam-Checker-Version": "SpamAssassin 3.4.1 (2015-04-28) on\n\tantivirus1-rhel7.int",
        "X-Spam-Level": "",
        "X-Spam-Status": "No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50,\n\tSMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1",
        "X-Virus-Status": "clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int)",
        "X-SMTPAUTHUS": "auth mail.us.es",
        "From": "Pablo Neira Ayuso <pablo@netfilter.org>",
        "To": "netfilter-devel@vger.kernel.org",
        "Cc": "davem@davemloft.net, netdev@vger.kernel.org",
        "Subject": "[PATCH 21/47] netfilter: xtables: Remove unused variable in\n\tcompat_copy_entry_from_user()",
        "Date": "Mon,  4 Sep 2017 00:28:57 +0200",
        "Message-Id": "<1504477763-12205-2-git-send-email-pablo@netfilter.org>",
        "X-Mailer": "git-send-email 2.1.4",
        "In-Reply-To": "<1504477763-12205-1-git-send-email-pablo@netfilter.org>",
        "References": "<1504477763-12205-1-git-send-email-pablo@netfilter.org>",
        "X-Virus-Scanned": "ClamAV using ClamSMTP",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "From: Taehee Yoo <ap420073@gmail.com>\n\nThe target variable is not used in the compat_copy_entry_from_user().\nSo It can be removed.\n\nSigned-off-by: Taehee Yoo <ap420073@gmail.com>\nSigned-off-by: Pablo Neira Ayuso <pablo@netfilter.org>\n---\n net/ipv4/netfilter/arp_tables.c | 2 --\n net/ipv4/netfilter/ip_tables.c  | 2 --\n 2 files changed, 4 deletions(-)",
    "diff": "diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c\nindex 0bc3c3d73e61..cf520d30cb94 100644\n--- a/net/ipv4/netfilter/arp_tables.c\n+++ b/net/ipv4/netfilter/arp_tables.c\n@@ -1117,7 +1117,6 @@ compat_copy_entry_from_user(struct compat_arpt_entry *e, void **dstptr,\n \t\t\t    struct xt_table_info *newinfo, unsigned char *base)\n {\n \tstruct xt_entry_target *t;\n-\tstruct xt_target *target;\n \tstruct arpt_entry *de;\n \tunsigned int origsize;\n \tint h;\n@@ -1132,7 +1131,6 @@ compat_copy_entry_from_user(struct compat_arpt_entry *e, void **dstptr,\n \n \tde->target_offset = e->target_offset - (origsize - *size);\n \tt = compat_arpt_get_target(e);\n-\ttarget = t->u.kernel.target;\n \txt_compat_target_from_user(t, dstptr, size);\n \n \tde->next_offset = e->next_offset - (origsize - *size);\ndiff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/netfilter/ip_tables.c\nindex 2a55a40211cb..f47e8dad5e95 100644\n--- a/net/ipv4/netfilter/ip_tables.c\n+++ b/net/ipv4/netfilter/ip_tables.c\n@@ -1355,7 +1355,6 @@ compat_copy_entry_from_user(struct compat_ipt_entry *e, void **dstptr,\n \t\t\t    struct xt_table_info *newinfo, unsigned char *base)\n {\n \tstruct xt_entry_target *t;\n-\tstruct xt_target *target;\n \tstruct ipt_entry *de;\n \tunsigned int origsize;\n \tint h;\n@@ -1374,7 +1373,6 @@ compat_copy_entry_from_user(struct compat_ipt_entry *e, void **dstptr,\n \n \tde->target_offset = e->target_offset - (origsize - *size);\n \tt = compat_ipt_get_target(e);\n-\ttarget = t->u.kernel.target;\n \txt_compat_target_from_user(t, dstptr, size);\n \n \tde->next_offset = e->next_offset - (origsize - *size);\n",
    "prefixes": [
        "21/47"
    ]
}