Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 809391,
    "url": "http://patchwork.ozlabs.org/api/patches/809391/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1504477667-12130-1-git-send-email-pablo@netfilter.org/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<1504477667-12130-1-git-send-email-pablo@netfilter.org>",
    "list_archive_url": null,
    "date": "2017-09-03T22:27:10",
    "name": "[10/47] netfilter: conntrack: destroy functions need to free queued packets",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "4679097ee424dce22070a07bf8d1ad3fa8e81558",
    "submitter": {
        "id": 1315,
        "url": "http://patchwork.ozlabs.org/api/people/1315/?format=api",
        "name": "Pablo Neira Ayuso",
        "email": "pablo@netfilter.org"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1504477667-12130-1-git-send-email-pablo@netfilter.org/mbox/",
    "series": [
        {
            "id": 1281,
            "url": "http://patchwork.ozlabs.org/api/series/1281/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=1281",
            "date": "2017-09-03T22:25:42",
            "name": "[01/47] netfilter: expect: add to hash table after expect init",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/1281/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/809391/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/809391/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlng65tLSz9s8J\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon,  4 Sep 2017 08:28:02 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753231AbdICW2B (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSun, 3 Sep 2017 18:28:01 -0400",
            "from mail.us.es ([193.147.175.20]:51100 \"EHLO mail.us.es\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1753037AbdICW17 (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tSun, 3 Sep 2017 18:27:59 -0400",
            "from antivirus1-rhel7.int (unknown [192.168.2.11])\n\tby mail.us.es (Postfix) with ESMTP id E1FE6190F62\n\tfor <netdev@vger.kernel.org>; Mon,  4 Sep 2017 00:27:32 +0200 (CEST)",
            "from antivirus1-rhel7.int (localhost [127.0.0.1])\n\tby antivirus1-rhel7.int (Postfix) with ESMTP id D4B35B502E\n\tfor <netdev@vger.kernel.org>; Mon,  4 Sep 2017 00:27:32 +0200 (CEST)",
            "by antivirus1-rhel7.int (Postfix, from userid 99)\n\tid C9F73B502C; Mon,  4 Sep 2017 00:27:32 +0200 (CEST)",
            "from antivirus1-rhel7.int (localhost [127.0.0.1])\n\tby antivirus1-rhel7.int (Postfix) with ESMTP id C7B75CE372;\n\tMon,  4 Sep 2017 00:27:30 +0200 (CEST)",
            "from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int\n\t(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); \n\tMon, 04 Sep 2017 00:27:30 +0200 (CEST)",
            "from salvia.here (unknown [31.4.193.113])\n\t(Authenticated sender: pneira@us.es)\n\tby entrada.int (Postfix) with ESMTPA id 9FFBB4265A20;\n\tMon,  4 Sep 2017 00:27:28 +0200 (CEST)"
        ],
        "X-Spam-Checker-Version": "SpamAssassin 3.4.1 (2015-04-28) on\n\tantivirus1-rhel7.int",
        "X-Spam-Level": "",
        "X-Spam-Status": "No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50,\n\tSMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1",
        "X-Virus-Status": "clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int)",
        "X-SMTPAUTHUS": "auth mail.us.es",
        "From": "Pablo Neira Ayuso <pablo@netfilter.org>",
        "To": "netfilter-devel@vger.kernel.org",
        "Cc": "davem@davemloft.net, netdev@vger.kernel.org",
        "Subject": "[PATCH 10/47] netfilter: conntrack: destroy functions need to free\n\tqueued packets",
        "Date": "Mon,  4 Sep 2017 00:27:10 +0200",
        "Message-Id": "<1504477667-12130-1-git-send-email-pablo@netfilter.org>",
        "X-Mailer": "git-send-email 2.1.4",
        "X-Virus-Scanned": "ClamAV using ClamSMTP",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "From: Florian Westphal <fw@strlen.de>\n\nqueued skbs might be using conntrack extensions that are being removed,\nsuch as timeout.  This happens for skbs that have a skb->nfct in\nunconfirmed state (i.e., not in hash table yet).\n\nThis is destructive, but there are only two use cases:\n - module removal (rare)\n - netns cleanup (most likely no conntracks exist, and if they do,\n   they are removed anyway later on).\n\nSigned-off-by: Florian Westphal <fw@strlen.de>\nSigned-off-by: Pablo Neira Ayuso <pablo@netfilter.org>\n---\n net/netfilter/nf_conntrack_core.c | 4 ++++\n net/netfilter/nf_queue.c          | 1 +\n 2 files changed, 5 insertions(+)",
    "diff": "diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c\nindex 80ab4e937765..2bc499186186 100644\n--- a/net/netfilter/nf_conntrack_core.c\n+++ b/net/netfilter/nf_conntrack_core.c\n@@ -56,6 +56,8 @@\n #include <net/netfilter/nf_nat_helper.h>\n #include <net/netns/hash.h>\n \n+#include \"nf_internals.h\"\n+\n #define NF_CONNTRACK_VERSION\t\"0.5.0\"\n \n int (*nfnetlink_parse_nat_setup_hook)(struct nf_conn *ct,\n@@ -1692,6 +1694,7 @@ void nf_ct_unconfirmed_destroy(struct net *net)\n \n \tif (atomic_read(&net->ct.count) > 0) {\n \t\t__nf_ct_unconfirmed_destroy(net);\n+\t\tnf_queue_nf_hook_drop(net);\n \t\tsynchronize_net();\n \t}\n }\n@@ -1737,6 +1740,7 @@ nf_ct_iterate_destroy(int (*iter)(struct nf_conn *i, void *data), void *data)\n \t\tif (atomic_read(&net->ct.count) == 0)\n \t\t\tcontinue;\n \t\t__nf_ct_unconfirmed_destroy(net);\n+\t\tnf_queue_nf_hook_drop(net);\n \t}\n \trtnl_unlock();\n \ndiff --git a/net/netfilter/nf_queue.c b/net/netfilter/nf_queue.c\nindex 043850c9d154..4f4d80a58fb5 100644\n--- a/net/netfilter/nf_queue.c\n+++ b/net/netfilter/nf_queue.c\n@@ -109,6 +109,7 @@ unsigned int nf_queue_nf_hook_drop(struct net *net)\n \n \treturn count;\n }\n+EXPORT_SYMBOL_GPL(nf_queue_nf_hook_drop);\n \n static int __nf_queue(struct sk_buff *skb, const struct nf_hook_state *state,\n \t\t      struct nf_hook_entry *hook_entry, unsigned int queuenum)\n",
    "prefixes": [
        "10/47"
    ]
}