Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/809261/?format=api
{ "id": 809261, "url": "http://patchwork.ozlabs.org/api/patches/809261/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/patch/20170903120835.16190-1-camh@xdna.net/", "project": { "id": 27, "url": "http://patchwork.ozlabs.org/api/projects/27/?format=api", "name": "Buildroot development", "link_name": "buildroot", "list_id": "buildroot.buildroot.org", "list_email": "buildroot@buildroot.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170903120835.16190-1-camh@xdna.net>", "list_archive_url": null, "date": "2017-09-03T12:08:35", "name": "[1/1] toolchain: detect external glibc in symlinked /lib", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "735710399e542ec06fe4560901083820bceb7b72", "submitter": { "id": 20727, "url": "http://patchwork.ozlabs.org/api/people/20727/?format=api", "name": "Cam Hutchison", "email": "camh@xdna.net" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/buildroot/patch/20170903120835.16190-1-camh@xdna.net/mbox/", "series": [ { "id": 1218, "url": "http://patchwork.ozlabs.org/api/series/1218/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/list/?series=1218", "date": "2017-09-03T12:08:35", "name": "[1/1] toolchain: detect external glibc in symlinked /lib", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1218/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809261/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809261/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<buildroot-bounces@busybox.net>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "buildroot@lists.busybox.net" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "buildroot@osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=xdna.net header.i=@xdna.net header.b=\"LCJYw3iG\";\n\tdkim-atps=neutral" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xlX4k3kYFz9s7v\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 3 Sep 2017 22:15:50 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8908586180;\n\tSun, 3 Sep 2017 12:15:48 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lt7dqA2ErFGc; Sun, 3 Sep 2017 12:15:48 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id CE83886282;\n\tSun, 3 Sep 2017 12:15:47 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 611961C01F1\n\tfor <buildroot@lists.busybox.net>;\n\tSun, 3 Sep 2017 12:15:46 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 57B1C8877D\n\tfor <buildroot@lists.busybox.net>;\n\tSun, 3 Sep 2017 12:15:46 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PqEk-vGaKZfW for <buildroot@lists.busybox.net>;\n\tSun, 3 Sep 2017 12:15:45 +0000 (UTC)", "from mail-lf0-f47.google.com (mail-lf0-f47.google.com\n\t[209.85.215.47])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 73F3F88773\n\tfor <buildroot@buildroot.org>; Sun, 3 Sep 2017 12:15:45 +0000 (UTC)", "by mail-lf0-f47.google.com with SMTP id y128so12268118lfd.4\n\tfor <buildroot@buildroot.org>; Sun, 03 Sep 2017 05:15:45 -0700 (PDT)", "from xdna.net (107-220-181-180.cpe.skymesh.net.au.\n\t[180.181.220.107]) by smtp.gmail.com with ESMTPSA id\n\t20sm726560ljv.77.2017.09.03.05.08.46\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 03 Sep 2017 05:08:49 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:06:53 by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=xdna.net; s=google; \n\th=from:to:cc:subject:date:message-id;\n\tbh=s7kxiR5+Kwq9RWwc7dcsikAFGdYl6ivodZsCkYfeItE=;\n\tb=LCJYw3iG0o272HSOL0uZtZWu5qDwIAaRgCFxoSJN50msn4oJWXJyTvF6eq156jZF51\n\tepXPxSMhlNN5pUZHXdxjpEvTSfSkkb0cbwDf6aOqvUtBYn88n5fzOku/kq7GIR41mynI\n\tIlOeyJCvblhv/ZmFxa7C0/S4K+c3eu6mgkZIM=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=s7kxiR5+Kwq9RWwc7dcsikAFGdYl6ivodZsCkYfeItE=;\n\tb=Zim2cwMHjudDmHEffEevXHADK2DeAQef7E8eXUFd8oQUXvE5IPbglrGIK1jqejpEgZ\n\tF6aolrJWNp32Q0+VSTPzAMVZu9NYiQrKZkACyHMsP/D6WUIADNrOl3AiKvsfP46mzRKH\n\tJQ3IhFzo7Vs9DLD/tHdL7TQ1WPtIlzGMnjsW7dM7Lm6ABm+IsKuiA9qxFbviU45HhFj/\n\tsJ+02D6miJ7H7uLo5c2CUBnrCQV252MbxCjOje+RpgjOmMwmEF8aq2f+CzErzk1uxjII\n\tGvUHalZNdT7MdSW0f1UGR4TE3lWhOC/7LEdcvkK7FUQkFrISiLF/vN/61a1CofHSMb6A\n\tcqLg==", "X-Gm-Message-State": "AHPjjUinv3ucZwG4wSKrArtgSaP8tMsnSiTFhniJfclnRvUY/z3eOIm/\n\tRZJI0lRQrhh1QMraqOJkLA==", "X-Google-Smtp-Source": "ADKCNb7d9BVZQRXclL+ulEMJ5u/u3qEG8JEDpc7dpMOzSjmv0Efi6y2HCP3THXoWJxz3EsU42JiNsw==", "X-Received": "by 10.25.38.141 with SMTP id m135mr2257071lfm.230.1504440530516; \n\tSun, 03 Sep 2017 05:08:50 -0700 (PDT)", "From": "Cam Hutchison <camh@xdna.net>", "To": "buildroot@buildroot.org", "Date": "Sun, 3 Sep 2017 22:08:35 +1000", "Message-Id": "<20170903120835.16190-1-camh@xdna.net>", "X-Mailer": "git-send-email 2.11.0", "Cc": "Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,\n\tCam Hutchison <camh@xdna.net>,\n\t\"Yann E . MORIN\" <yann.morin.1998@free.fr>, \n\tThomas De Schampheleire <thomas.de_schampheleire@nokia.com>", "Subject": "[Buildroot] [PATCH 1/1] toolchain: detect external glibc in\n\tsymlinked /lib", "X-BeenThere": "buildroot@busybox.net", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Discussion and development of buildroot <buildroot.busybox.net>", "List-Unsubscribe": "<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>", "List-Archive": "<http://lists.busybox.net/pipermail/buildroot/>", "List-Post": "<mailto:buildroot@busybox.net>", "List-Help": "<mailto:buildroot-request@busybox.net?subject=help>", "List-Subscribe": "<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "buildroot-bounces@busybox.net", "Sender": "\"buildroot\" <buildroot-bounces@busybox.net>" }, "content": "check_glibc checks for a valid glibc in an external toolchain, but\nassumes that the files indicating the presence of glibc (ld-linux*.so.*,\nld.so.* or ld64.so.*) are in a top-level directory of the sysroot.\n\nWhen building a toolchain with buildroot and a merged /usr, /lib is\na symlink to usr/lib. This is copied from the target to the staging\ndirectory, and then to the sysroot, and the ultimate location of the\nrequired files is in /usr/lib in the sysroot.\n\ncheck_glibc fails to find the necessary files in this layout due to it\nusing find(1) with -maxdepth 2 and not following symlinks. This causes\nthe error 'Incorrect selection of the C library' when trying to use a\nbuildroot toolchain as an external toolchain that was built with a\nmerged /usr.\n\nTell find(1) to follow symlinks so that it can find the required files\nto determine glibc availability in the external toolchain.\n\nSigned-off-by: Cam Hutchison <camh@xdna.net>\n---\n toolchain/helpers.mk | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk\nindex e9e36d2069..63ef6fb4b0 100644\n--- a/toolchain/helpers.mk\n+++ b/toolchain/helpers.mk\n@@ -227,7 +227,7 @@ check_glibc_rpc_feature = \\\n #\n check_glibc = \\\n \tSYSROOT_DIR=\"$(strip $1)\"; \\\n-\tif test `find $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' -o -name 'ld64.so.*' | wc -l` -eq 0 ; then \\\n+\tif test `find -L $${SYSROOT_DIR}/ -maxdepth 2 -name 'ld-linux*.so.*' -o -name 'ld.so.*' -o -name 'ld64.so.*' | wc -l` -eq 0 ; then \\\n \t\techo \"Incorrect selection of the C library\"; \\\n \t\texit -1; \\\n \tfi; \\\n", "prefixes": [ "1/1" ] }