Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/809258/?format=api
{ "id": 809258, "url": "http://patchwork.ozlabs.org/api/patches/809258/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20170903115831.1326-1-christophe.jaillet@wanadoo.fr/", "project": { "id": 3, "url": "http://patchwork.ozlabs.org/api/projects/3/?format=api", "name": "Linux MTD development", "link_name": "linux-mtd", "list_id": "linux-mtd.lists.infradead.org", "list_email": "linux-mtd@lists.infradead.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170903115831.1326-1-christophe.jaillet@wanadoo.fr>", "list_archive_url": null, "date": "2017-09-03T11:58:31", "name": "mtd: nand: lpc32xx_mlc: Fix an error handling path in lpc32xx_nand_probe()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "087be1da9ea78065ef0d9b62e750bef6454307a6", "submitter": { "id": 66309, "url": "http://patchwork.ozlabs.org/api/people/66309/?format=api", "name": "Christophe JAILLET", "email": "christophe.jaillet@wanadoo.fr" }, "delegate": { "id": 58324, "url": "http://patchwork.ozlabs.org/api/users/58324/?format=api", "username": "bbrezillon", "first_name": "Boris", "last_name": "Brezillon", "email": "boris.brezillon@free-electrons.com" }, "mbox": "http://patchwork.ozlabs.org/project/linux-mtd/patch/20170903115831.1326-1-christophe.jaillet@wanadoo.fr/mbox/", "series": [ { "id": 1215, "url": "http://patchwork.ozlabs.org/api/series/1215/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-mtd/list/?series=1215", "date": "2017-09-03T11:58:31", "name": "mtd: nand: lpc32xx_mlc: Fix an error handling path in lpc32xx_nand_probe()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1215/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809258/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809258/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"DyWWL5sX\"; \n\tdkim-atps=neutral" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xlWmS3LpQz9s7v\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 3 Sep 2017 22:01:44 +1000 (AEST)", "from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1doTas-0007kU-EL; Sun, 03 Sep 2017 12:01:38 +0000", "from smtp10.smtpout.orange.fr ([80.12.242.132]\n\thelo=smtp.smtpout.orange.fr)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1doTZu-0007SU-L4\n\tfor linux-mtd@lists.infradead.org; Sun, 03 Sep 2017 12:00:40 +0000", "from localhost.localdomain ([86.196.182.67]) by mwinf5d87 with ME\n\tid 500A1w0031TfVo60300AfZ; Sun, 03 Sep 2017 14:00:12 +0200" ], "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:\n\tSubject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:\n\tReferences:List-Owner; bh=uz4TMABsOcurM2kXGRJjsctnLHvBxO+D1Ad8BYT2Vkk=;\n\tb=DyW\n\tWL5sX4mgs0x+dREETiBMWVMHk2x9OushlzzCGFoPmZ2HavXph6Ar8vbkK94O0aEa2rsoKt+WT875l\n\t0A78ywZL6aY3aDKjfzkIb/JLDbyCf4Cj5cWfS9j32F6onyYZwDTiLJ7JHbf5tXgt0g3NZweUdD9Wm\n\tan3oxwEkBYuix8kLYnsZTawjoczh2rYogpmzNiZPGGOpXNZ7KrLKjWVm8cREcHF6ij/umEvoOIZje\n\t3mH5yvVuKe7DgJqZ/y4ZBtmtYVNCspcgCsh6cA58dFy0Z1+fFCXL3481pE79cUMHtKW7fK3/Yu6ss\n\tYOPixxA61rihmxAWEG0Ah4c88yp9P/g==;", "X-ME-Helo": "localhost.localdomain", "X-ME-Auth": "Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI=", "X-ME-Date": "Sun, 03 Sep 2017 14:00:12 +0200", "X-ME-IP": "86.196.182.67", "From": "Christophe JAILLET <christophe.jaillet@wanadoo.fr>", "To": "boris.brezillon@free-electrons.com, richard@nod.at, dwmw2@infradead.org, \n\tcomputersforpeace@gmail.com, marek.vasut@gmail.com,\n\tcyrille.pitchen@wedev4u.fr, vz@mleia.com, slemieux.tyco@gmail.com", "Subject": "[PATCH] mtd: nand: lpc32xx_mlc: Fix an error handling path in\n\tlpc32xx_nand_probe()", "Date": "Sun, 3 Sep 2017 13:58:31 +0200", "Message-Id": "<20170903115831.1326-1-christophe.jaillet@wanadoo.fr>", "X-Mailer": "git-send-email 2.11.0", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20170903_050039_024768_BD665680 ", "X-CRM114-Status": "UNSURE ( 8.81 )", "X-CRM114-Notice": "Please train this message.", "X-Spam-Score": "-4.7 (----)", "X-Spam-Report": "SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-4.7 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-2.8 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)\n\t[80.12.242.132 listed in wl.mailspike.net]\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [80.12.242.132 listed in list.dnswl.org]\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (christophe.jaillet[at]wanadoo.fr)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]", "X-BeenThere": "linux-mtd@lists.infradead.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-mtd/>", "List-Post": "<mailto:linux-mtd@lists.infradead.org>", "List-Help": "<mailto:linux-mtd-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>", "Cc": "kernel-janitors@vger.kernel.org,\n\tChristophe JAILLET <christophe.jaillet@wanadoo.fr>,\n\tlinux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>", "Errors-To": "linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "If 'clk_prepare_enable()' fails, we must 'put' the corresponding clock.\n\nFixes: 4d26f012ab59 (\"mtd: nand: lpc32xx_mlc: Handle return value of clk_prepare_enable.\")\nSigned-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>\n---\nLabels in the error handling path could be renamed, but it does not worth\nthe effort, IMHO.\n---\n drivers/mtd/nand/lpc32xx_mlc.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/mtd/nand/lpc32xx_mlc.c b/drivers/mtd/nand/lpc32xx_mlc.c\nindex c3bb358ef01e..5f72a824e67d 100644\n--- a/drivers/mtd/nand/lpc32xx_mlc.c\n+++ b/drivers/mtd/nand/lpc32xx_mlc.c\n@@ -707,7 +707,7 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)\n \t}\n \tres = clk_prepare_enable(host->clk);\n \tif (res)\n-\t\tgoto err_exit1;\n+\t\tgoto err_put_clk;\n \n \tnand_chip->cmd_ctrl = lpc32xx_nand_cmd_ctrl;\n \tnand_chip->dev_ready = lpc32xx_nand_device_ready;\n@@ -814,6 +814,7 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)\n \t\tdma_release_channel(host->dma_chan);\n err_exit2:\n \tclk_disable_unprepare(host->clk);\n+err_put_clk:\n \tclk_put(host->clk);\n err_exit1:\n \tlpc32xx_wp_enable(host);\n", "prefixes": [] }