Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/809219/?format=api
{ "id": 809219, "url": "http://patchwork.ozlabs.org/api/patches/809219/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1504416646-9527-2-git-send-email-subashab@codeaurora.org/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504416646-9527-2-git-send-email-subashab@codeaurora.org>", "list_archive_url": null, "date": "2017-09-03T05:30:41", "name": "[net-next,1/6] net: qualcomm: rmnet: Fix memory corruption if mux_id is greater than 32", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "662d8a897b644893da5cff24c1ad9ada61ee36cd", "submitter": { "id": 65547, "url": "http://patchwork.ozlabs.org/api/people/65547/?format=api", "name": "Subash Abhinov Kasiviswanathan", "email": "subashab@codeaurora.org" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1504416646-9527-2-git-send-email-subashab@codeaurora.org/mbox/", "series": [ { "id": 1198, "url": "http://patchwork.ozlabs.org/api/series/1198/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=1198", "date": "2017-09-03T05:30:40", "name": "net: qualcomm: rmnet: Fix comments on initial patchset", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1198/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809219/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809219/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=codeaurora.org header.i=@codeaurora.org\n\theader.b=\"MTcOj76v\"; \n\tdkim=pass (1024-bit key) header.d=codeaurora.org\n\theader.i=@codeaurora.org header.b=\"cKqkLMHU\"; \n\tdkim-atps=neutral", "pdx-caf-mail.web.codeaurora.org;\n\tdmarc=none (p=none dis=none)\n\theader.from=codeaurora.org", "pdx-caf-mail.web.codeaurora.org;\n\tspf=none smtp.mailfrom=subashab@codeaurora.org" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlM6s4yrRz9sPk\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSun, 3 Sep 2017 15:32:05 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751224AbdICFbw (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSun, 3 Sep 2017 01:31:52 -0400", "from smtp.codeaurora.org ([198.145.29.96]:42600 \"EHLO\n\tsmtp.codeaurora.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751129AbdICFbv (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Sun, 3 Sep 2017 01:31:51 -0400", "by smtp.codeaurora.org (Postfix, from userid 1000)\n\tid 1591A60584; Sun, 3 Sep 2017 05:31:51 +0000 (UTC)", "from subashab-lnx.qualcomm.com (unknown [129.46.15.92])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\t(Authenticated sender: subashab@codeaurora.org)\n\tby smtp.codeaurora.org (Postfix) with ESMTPSA id 02C0260584;\n\tSun, 3 Sep 2017 05:31:49 +0000 (UTC)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1504416711;\n\tbh=hljaf+zn5fN3U/citF9ioM7vWq3yJRDQij5wBkUs5oM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MTcOj76v+h/xj0uTxcbsj8McxyTOIg1bhw3s7k6zyaT+IUrWEMbh5wTRTjhueBAeL\n\tAJFY/nKkqVsbipkwC7+m3kE4e6g+44ehaIrveJa9xA983XcvWngKIk9MWxnFLqaBnW\n\tp/2ZrqPFpeKzYrlKl5R1Xvd8GVc8QzyjxozE3UOs=", "v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;\n\ts=default; t=1504416710;\n\tbh=hljaf+zn5fN3U/citF9ioM7vWq3yJRDQij5wBkUs5oM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=cKqkLMHUb0msioEaFozVvqmIrDZcfdWlmOYFHNrAySqjhiUhjvoBqGDp9/O1H4LGG\n\tKS8rY6VRVCCQxK4NC8wizUL+Oqo5UfbX9JbOaOjKttbnlIl8WNGCmZt27UWbYKa65m\n\t0Z9eJxNIh0K907u0QLspO9OXG6ZpZdkXKeTwbNic=" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on\n\tpdx-caf-mail.web.codeaurora.org", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00,\n\tDKIM_SIGNED,\n\tT_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0", "DMARC-Filter": "OpenDMARC Filter v1.3.2 smtp.codeaurora.org 02C0260584", "From": "Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>", "To": "netdev@vger.kernel.org, davem@davemloft.net", "Cc": "Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>,\n\tDan Williams <dcbw@redhat.com>", "Subject": "[PATCH net-next 1/6] net: qualcomm: rmnet: Fix memory corruption if\n\tmux_id is greater than 32", "Date": "Sat, 2 Sep 2017 23:30:41 -0600", "Message-Id": "<1504416646-9527-2-git-send-email-subashab@codeaurora.org>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1504416646-9527-1-git-send-email-subashab@codeaurora.org>", "References": "<1504416646-9527-1-git-send-email-subashab@codeaurora.org>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "rmnet_rtnl_validate() was checking for upto mux_id 254, however the\nrmnet_devices devices could hold upto 32 entries only. Fix this by\nincreasing the size of the rmnet_devices.\n\nFixes: ceed73a2cf4a (\"drivers: net: ethernet: qualcomm: rmnet: Initial implementation\")\nSigned-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>\nCc: Dan Williams <dcbw@redhat.com>\n---\n drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h | 3 +--\n drivers/net/ethernet/qualcomm/rmnet/rmnet_private.h | 1 -\n drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 2 +-\n 3 files changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h\nindex 985d372..40b6b32 100644\n--- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h\n+++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h\n@@ -19,7 +19,6 @@\n #define _RMNET_CONFIG_H_\n \n #define RMNET_MAX_LOGICAL_EP 255\n-#define RMNET_MAX_VND 32\n \n /* Information about the next device to deliver the packet to.\n * Exact usage of this parameter depends on the rmnet_mode.\n@@ -39,7 +38,7 @@ struct rmnet_real_dev_info {\n \tstruct rmnet_endpoint muxed_ep[RMNET_MAX_LOGICAL_EP];\n \tu32 ingress_data_format;\n \tu32 egress_data_format;\n-\tstruct net_device *rmnet_devices[RMNET_MAX_VND];\n+\tstruct net_device *rmnet_devices[RMNET_MAX_LOGICAL_EP];\n \tu8 nr_rmnet_devs;\n };\n \ndiff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_private.h b/drivers/net/ethernet/qualcomm/rmnet/rmnet_private.h\nindex ed820b5..7967198 100644\n--- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_private.h\n+++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_private.h\n@@ -13,7 +13,6 @@\n #ifndef _RMNET_PRIVATE_H_\n #define _RMNET_PRIVATE_H_\n \n-#define RMNET_MAX_VND 32\n #define RMNET_MAX_PACKET_SIZE 16384\n #define RMNET_DFLT_PACKET_SIZE 1500\n #define RMNET_NEEDED_HEADROOM 16\ndiff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c\nindex bf7455f..0e0001b 100644\n--- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c\n+++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c\n@@ -112,7 +112,7 @@ int rmnet_vnd_newlink(u8 id, struct net_device *rmnet_dev,\n \n int rmnet_vnd_dellink(u8 id, struct rmnet_real_dev_info *r)\n {\n-\tif (id >= RMNET_MAX_VND || !r->rmnet_devices[id])\n+\tif (id >= RMNET_MAX_LOGICAL_EP || !r->rmnet_devices[id])\n \t\treturn -EINVAL;\n \n \tr->rmnet_devices[id] = NULL;\n", "prefixes": [ "net-next", "1/6" ] }