Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 809202,
    "url": "http://patchwork.ozlabs.org/api/patches/809202/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170903042117.28923-4-saeedm@mellanox.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20170903042117.28923-4-saeedm@mellanox.com>",
    "list_archive_url": null,
    "date": "2017-09-03T04:21:03",
    "name": "[net-next,03/17] net/mlx5e: Remove unnecessary wqe_sz field from RQ buffer",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "98f4c74120fdbebdd64c4d2e4b22c97d03c3f201",
    "submitter": {
        "id": 65299,
        "url": "http://patchwork.ozlabs.org/api/people/65299/?format=api",
        "name": "Saeed Mahameed",
        "email": "saeedm@mellanox.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170903042117.28923-4-saeedm@mellanox.com/mbox/",
    "series": [
        {
            "id": 1196,
            "url": "http://patchwork.ozlabs.org/api/series/1196/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=1196",
            "date": "2017-09-03T04:21:09",
            "name": "[net-next,01/17] net/mlx5e: Reorganize struct mlx5e_rq",
            "version": 1,
            "mbox": "http://patchwork.ozlabs.org/series/1196/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/809202/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/809202/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlKZr69Z1z9sPk\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSun,  3 Sep 2017 14:22:44 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751497AbdICEWP (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSun, 3 Sep 2017 00:22:15 -0400",
            "from mail-il-dmz.mellanox.com ([193.47.165.129]:59980 \"EHLO\n\tmellanox.co.il\" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org\n\twith ESMTP id S1750904AbdICEWL (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Sun, 3 Sep 2017 00:22:11 -0400",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tsaeedm@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 3 Sep 2017 07:22:05 +0300",
            "from sws.mtl.labs.mlnx (reg-l-vrt-045-015.mtl.labs.mlnx\n\t[10.135.45.15])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v834M5l4017672;\n\tSun, 3 Sep 2017 07:22:05 +0300"
        ],
        "From": "Saeed Mahameed <saeedm@mellanox.com>",
        "To": "\"David S. Miller\" <davem@davemloft.net>",
        "Cc": "netdev@vger.kernel.org, kernel-team@fb.com,\n\tTariq Toukan <tariqt@mellanox.com>, Saeed Mahameed <saeedm@mellanox.com>",
        "Subject": "[net-next 03/17] net/mlx5e: Remove unnecessary wqe_sz field from RQ\n\tbuffer",
        "Date": "Sun,  3 Sep 2017 07:21:03 +0300",
        "Message-Id": "<20170903042117.28923-4-saeedm@mellanox.com>",
        "X-Mailer": "git-send-email 2.13.0",
        "In-Reply-To": "<20170903042117.28923-1-saeedm@mellanox.com>",
        "References": "<20170903042117.28923-1-saeedm@mellanox.com>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "From: Tariq Toukan <tariqt@mellanox.com>\n\nField is used only locally within the RQ create function.\nThe use of a local variable is sufficient.\n\nSigned-off-by: Tariq Toukan <tariqt@mellanox.com>\nSigned-off-by: Saeed Mahameed <saeedm@mellanox.com>\n---\n drivers/net/ethernet/mellanox/mlx5/core/en.h      | 1 -\n drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 8 +++-----\n 2 files changed, 3 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h b/drivers/net/ethernet/mellanox/mlx5/core/en.h\nindex 44bd8df905ca..ce8b4f648757 100644\n--- a/drivers/net/ethernet/mellanox/mlx5/core/en.h\n+++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h\n@@ -540,7 +540,6 @@ struct mlx5e_rq {\n \t\t} mpwqe;\n \t};\n \tstruct {\n-\t\tu32            wqe_sz;    /* wqe data buffer size */\n \t\tu16            headroom;\n \t\tu8             page_order;\n \t\tu8             map_dir;   /* dma map direction */\ndiff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c\nindex 7a25d952c922..591e0dca9671 100644\n--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c\n+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c\n@@ -618,8 +618,7 @@ static int mlx5e_alloc_rq(struct mlx5e_channel *c,\n \t\trq->mpwqe.log_stride_sz = params->mpwqe_log_stride_sz;\n \t\trq->mpwqe.num_strides = BIT(params->mpwqe_log_num_strides);\n \n-\t\trq->buff.wqe_sz = rq->mpwqe.num_strides << rq->mpwqe.log_stride_sz;\n-\t\tbyte_count = rq->buff.wqe_sz;\n+\t\tbyte_count = rq->mpwqe.num_strides << rq->mpwqe.log_stride_sz;\n \n \t\terr = mlx5e_create_rq_umr_mkey(mdev, rq);\n \t\tif (err)\n@@ -654,15 +653,14 @@ static int mlx5e_alloc_rq(struct mlx5e_channel *c,\n \t\t\tgoto err_rq_wq_destroy;\n \t\t}\n \n-\t\trq->buff.wqe_sz = params->lro_en  ?\n+\t\tbyte_count = params->lro_en  ?\n \t\t\t\tparams->lro_wqe_sz :\n \t\t\t\tMLX5E_SW2HW_MTU(c->priv, c->netdev->mtu);\n #ifdef CONFIG_MLX5_EN_IPSEC\n \t\tif (MLX5_IPSEC_DEV(mdev))\n-\t\t\trq->buff.wqe_sz += MLX5E_METADATA_ETHER_LEN;\n+\t\t\tbyte_count += MLX5E_METADATA_ETHER_LEN;\n #endif\n \t\trq->wqe.page_reuse = !params->xdp_prog && !params->lro_en;\n-\t\tbyte_count = rq->buff.wqe_sz;\n \n \t\t/* calc the required page order */\n \t\trq->wqe.frag_sz = MLX5_SKB_FRAG_SZ(rq->buff.headroom + byte_count);\n",
    "prefixes": [
        "net-next",
        "03/17"
    ]
}