Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/809199/?format=api
{ "id": 809199, "url": "http://patchwork.ozlabs.org/api/patches/809199/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170903042117.28923-14-saeedm@mellanox.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170903042117.28923-14-saeedm@mellanox.com>", "list_archive_url": null, "date": "2017-09-03T04:21:13", "name": "[net-next,13/17] net/mlx5e: Don't recycle page if moved to far NUMA", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "432211e0a37a4e9068a2810167a5da6c95df0b09", "submitter": { "id": 65299, "url": "http://patchwork.ozlabs.org/api/people/65299/?format=api", "name": "Saeed Mahameed", "email": "saeedm@mellanox.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170903042117.28923-14-saeedm@mellanox.com/mbox/", "series": [ { "id": 1196, "url": "http://patchwork.ozlabs.org/api/series/1196/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=1196", "date": "2017-09-03T04:21:09", "name": "[net-next,01/17] net/mlx5e: Reorganize struct mlx5e_rq", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1196/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809199/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809199/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlKZV02jZz9sRm\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSun, 3 Sep 2017 14:22:26 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751604AbdICEWT (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSun, 3 Sep 2017 00:22:19 -0400", "from mail-il-dmz.mellanox.com ([193.47.165.129]:60182 \"EHLO\n\tmellanox.co.il\" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org\n\twith ESMTP id S1751530AbdICEWS (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Sun, 3 Sep 2017 00:22:18 -0400", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tsaeedm@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 3 Sep 2017 07:22:06 +0300", "from sws.mtl.labs.mlnx (reg-l-vrt-045-015.mtl.labs.mlnx\n\t[10.135.45.15])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v834M5lE017672;\n\tSun, 3 Sep 2017 07:22:06 +0300" ], "From": "Saeed Mahameed <saeedm@mellanox.com>", "To": "\"David S. Miller\" <davem@davemloft.net>", "Cc": "netdev@vger.kernel.org, kernel-team@fb.com,\n\tTariq Toukan <tariqt@mellanox.com>, Saeed Mahameed <saeedm@mellanox.com>", "Subject": "[net-next 13/17] net/mlx5e: Don't recycle page if moved to far NUMA", "Date": "Sun, 3 Sep 2017 07:21:13 +0300", "Message-Id": "<20170903042117.28923-14-saeedm@mellanox.com>", "X-Mailer": "git-send-email 2.13.0", "In-Reply-To": "<20170903042117.28923-1-saeedm@mellanox.com>", "References": "<20170903042117.28923-1-saeedm@mellanox.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: Tariq Toukan <tariqt@mellanox.com>\n\nAvoid recycling an RX page if it moved to another NUMA node.\nAdd an ethtool counter to count such events.\n\nSigned-off-by: Tariq Toukan <tariqt@mellanox.com>\nSigned-off-by: Saeed Mahameed <saeedm@mellanox.com>\n---\n drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 1 +\n drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 6 ++++--\n drivers/net/ethernet/mellanox/mlx5/core/en_stats.h | 4 ++++\n 3 files changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c\nindex a4c9a0a2c408..2da2ea222aaa 100644\n--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c\n+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c\n@@ -208,6 +208,7 @@ static void mlx5e_update_sw_counters(struct mlx5e_priv *priv)\n \t\ts->rx_cache_full += rq_stats->cache_full;\n \t\ts->rx_cache_empty += rq_stats->cache_empty;\n \t\ts->rx_cache_busy += rq_stats->cache_busy;\n+\t\ts->rx_cache_waive += rq_stats->cache_waive;\n \n \t\tfor (j = 0; j < priv->channels.params.num_tc; j++) {\n \t\t\tsq_stats = &c->sq[j].stats;\ndiff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c\nindex 88a8749c67d6..f1dd638384d3 100644\n--- a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c\n+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c\n@@ -163,7 +163,7 @@ static inline u32 mlx5e_decompress_cqes_start(struct mlx5e_rq *rq,\n \n static inline bool mlx5e_page_is_reserved(struct page *page)\n {\n-\treturn page_is_pfmemalloc(page) || page_to_nid(page) != numa_node_id();\n+\treturn page_is_pfmemalloc(page) || page_to_nid(page) != numa_mem_id();\n }\n \n static inline bool mlx5e_rx_cache_put(struct mlx5e_rq *rq,\n@@ -177,8 +177,10 @@ static inline bool mlx5e_rx_cache_put(struct mlx5e_rq *rq,\n \t\treturn false;\n \t}\n \n-\tif (unlikely(page_is_pfmemalloc(dma_info->page)))\n+\tif (unlikely(mlx5e_page_is_reserved(dma_info->page))) {\n+\t\trq->stats.cache_waive++;\n \t\treturn false;\n+\t}\n \n \tcache->page_cache[cache->tail] = *dma_info;\n \tcache->tail = tail_next;\ndiff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h\nindex 6761796e803c..6d199ffb1c0b 100644\n--- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h\n+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.h\n@@ -84,6 +84,7 @@ struct mlx5e_sw_stats {\n \tu64 rx_cache_full;\n \tu64 rx_cache_empty;\n \tu64 rx_cache_busy;\n+\tu64 rx_cache_waive;\n \n \t/* Special handling counters */\n \tu64 link_down_events_phy;\n@@ -123,6 +124,7 @@ static const struct counter_desc sw_stats_desc[] = {\n \t{ MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_cache_full) },\n \t{ MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_cache_empty) },\n \t{ MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_cache_busy) },\n+\t{ MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_cache_waive) },\n \t{ MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, link_down_events_phy) },\n };\n \n@@ -354,6 +356,7 @@ struct mlx5e_rq_stats {\n \tu64 cache_full;\n \tu64 cache_empty;\n \tu64 cache_busy;\n+\tu64 cache_waive;\n };\n \n static const struct counter_desc rq_stats_desc[] = {\n@@ -377,6 +380,7 @@ static const struct counter_desc rq_stats_desc[] = {\n \t{ MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, cache_full) },\n \t{ MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, cache_empty) },\n \t{ MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, cache_busy) },\n+\t{ MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, cache_waive) },\n };\n \n struct mlx5e_sq_stats {\n", "prefixes": [ "net-next", "13/17" ] }