Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/809196/?format=api
{ "id": 809196, "url": "http://patchwork.ozlabs.org/api/patches/809196/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170903042117.28923-18-saeedm@mellanox.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170903042117.28923-18-saeedm@mellanox.com>", "list_archive_url": null, "date": "2017-09-03T04:21:17", "name": "[net-next,17/17] net/mlx5e: Distribute RSS table among all RX rings", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e46f403b1248e642650ab92917270ea6c9f629c7", "submitter": { "id": 65299, "url": "http://patchwork.ozlabs.org/api/people/65299/?format=api", "name": "Saeed Mahameed", "email": "saeedm@mellanox.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170903042117.28923-18-saeedm@mellanox.com/mbox/", "series": [ { "id": 1196, "url": "http://patchwork.ozlabs.org/api/series/1196/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=1196", "date": "2017-09-03T04:21:09", "name": "[net-next,01/17] net/mlx5e: Reorganize struct mlx5e_rq", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1196/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809196/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809196/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlKZS3xSnz9sPk\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSun, 3 Sep 2017 14:22:24 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751548AbdICEWQ (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSun, 3 Sep 2017 00:22:16 -0400", "from mail-il-dmz.mellanox.com ([193.47.165.129]:60128 \"EHLO\n\tmellanox.co.il\" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org\n\twith ESMTP id S1750904AbdICEWQ (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Sun, 3 Sep 2017 00:22:16 -0400", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tsaeedm@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 3 Sep 2017 07:22:06 +0300", "from sws.mtl.labs.mlnx (reg-l-vrt-045-015.mtl.labs.mlnx\n\t[10.135.45.15])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v834M5lI017672;\n\tSun, 3 Sep 2017 07:22:06 +0300" ], "From": "Saeed Mahameed <saeedm@mellanox.com>", "To": "\"David S. Miller\" <davem@davemloft.net>", "Cc": "netdev@vger.kernel.org, kernel-team@fb.com,\n\tTariq Toukan <tariqt@mellanox.com>, Saeed Mahameed <saeedm@mellanox.com>", "Subject": "[net-next 17/17] net/mlx5e: Distribute RSS table among all RX rings", "Date": "Sun, 3 Sep 2017 07:21:17 +0300", "Message-Id": "<20170903042117.28923-18-saeedm@mellanox.com>", "X-Mailer": "git-send-email 2.13.0", "In-Reply-To": "<20170903042117.28923-1-saeedm@mellanox.com>", "References": "<20170903042117.28923-1-saeedm@mellanox.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: Tariq Toukan <tariqt@mellanox.com>\n\nIn default, uniformly distribute the RSS indirection table entries\namong all RX rings, rather than restricting this only to the rings\non the close NUMA node. irqbalancer would anyway dynamically override\nthe default affinities set to the RX rings.\nThis gives better multi-stream performance and CPU util.\n\nSigned-off-by: Tariq Toukan <tariqt@mellanox.com>\nSigned-off-by: Saeed Mahameed <saeedm@mellanox.com>\n---\n drivers/net/ethernet/mellanox/mlx5/core/en.h | 3 +--\n drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 3 +--\n drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 15 ++-------------\n 3 files changed, 4 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en.h b/drivers/net/ethernet/mellanox/mlx5/core/en.h\nindex 1388a1e2f835..8b7d83bcc11a 100644\n--- a/drivers/net/ethernet/mellanox/mlx5/core/en.h\n+++ b/drivers/net/ethernet/mellanox/mlx5/core/en.h\n@@ -925,8 +925,7 @@ void mlx5e_switch_priv_channels(struct mlx5e_priv *priv,\n void mlx5e_activate_priv_channels(struct mlx5e_priv *priv);\n void mlx5e_deactivate_priv_channels(struct mlx5e_priv *priv);\n \n-void mlx5e_build_default_indir_rqt(struct mlx5_core_dev *mdev,\n-\t\t\t\t u32 *indirection_rqt, int len,\n+void mlx5e_build_default_indir_rqt(u32 *indirection_rqt, int len,\n \t\t\t\t int num_channels);\n int mlx5e_get_max_linkspeed(struct mlx5_core_dev *mdev, u32 *speed);\n \ndiff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c\nindex 6127e0d2f310..d12e9fc0d76b 100644\n--- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c\n+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c\n@@ -663,8 +663,7 @@ int mlx5e_ethtool_set_channels(struct mlx5e_priv *priv,\n \tnew_channels.params = priv->channels.params;\n \tnew_channels.params.num_channels = count;\n \tif (!netif_is_rxfh_configured(priv->netdev))\n-\t\tmlx5e_build_default_indir_rqt(priv->mdev,\n-\t\t\t\t\t new_channels.params.indirection_rqt,\n+\t\tmlx5e_build_default_indir_rqt(new_channels.params.indirection_rqt,\n \t\t\t\t\t MLX5E_INDIR_RQT_SIZE, count);\n \n \tif (!test_bit(MLX5E_STATE_OPENED, &priv->state)) {\ndiff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c\nindex 20f34131d4e5..77068609a153 100644\n--- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c\n+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c\n@@ -3833,22 +3833,11 @@ u16 mlx5e_get_max_inline_cap(struct mlx5_core_dev *mdev)\n \t 2 /*sizeof(mlx5e_tx_wqe.inline_hdr_start)*/;\n }\n \n-void mlx5e_build_default_indir_rqt(struct mlx5_core_dev *mdev,\n-\t\t\t\t u32 *indirection_rqt, int len,\n+void mlx5e_build_default_indir_rqt(u32 *indirection_rqt, int len,\n \t\t\t\t int num_channels)\n {\n-\tint node = mdev->priv.numa_node;\n-\tint node_num_of_cores;\n \tint i;\n \n-\tif (node == -1)\n-\t\tnode = first_online_node;\n-\n-\tnode_num_of_cores = cpumask_weight(cpumask_of_node(node));\n-\n-\tif (node_num_of_cores)\n-\t\tnum_channels = min_t(int, num_channels, node_num_of_cores);\n-\n \tfor (i = 0; i < len; i++)\n \t\tindirection_rqt[i] = i % num_channels;\n }\n@@ -3987,7 +3976,7 @@ void mlx5e_build_nic_params(struct mlx5_core_dev *mdev,\n \t/* RSS */\n \tparams->rss_hfunc = ETH_RSS_HASH_XOR;\n \tnetdev_rss_key_fill(params->toeplitz_hash_key, sizeof(params->toeplitz_hash_key));\n-\tmlx5e_build_default_indir_rqt(mdev, params->indirection_rqt,\n+\tmlx5e_build_default_indir_rqt(params->indirection_rqt,\n \t\t\t\t MLX5E_INDIR_RQT_SIZE, max_channels);\n }\n \n", "prefixes": [ "net-next", "17/17" ] }