Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/809191/?format=api
{ "id": 809191, "url": "http://patchwork.ozlabs.org/api/patches/809191/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170903012605.7435-3-jakub.kicinski@netronome.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170903012605.7435-3-jakub.kicinski@netronome.com>", "list_archive_url": null, "date": "2017-09-03T01:26:01", "name": "[net-next,2/6] nfp: flower: base lifetime of representors on existence of lower vNIC", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c66e3e88aef0bbb21743c16c6848efb44bb705b7", "submitter": { "id": 67484, "url": "http://patchwork.ozlabs.org/api/people/67484/?format=api", "name": "Jakub Kicinski", "email": "jakub.kicinski@netronome.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170903012605.7435-3-jakub.kicinski@netronome.com/mbox/", "series": [ { "id": 1191, "url": "http://patchwork.ozlabs.org/api/series/1191/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=1191", "date": "2017-09-03T01:26:03", "name": "nfp: refactor app init, and minor flower fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1191/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809191/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809191/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=netronome-com.20150623.gappssmtp.com\n\theader.i=@netronome-com.20150623.gappssmtp.com\n\theader.b=\"HBFLsPp0\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlFgn55cJz9sPk\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSun, 3 Sep 2017 11:26:45 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753012AbdICB0j (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSat, 2 Sep 2017 21:26:39 -0400", "from mail-pf0-f173.google.com ([209.85.192.173]:32882 \"EHLO\n\tmail-pf0-f173.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752954AbdICB0P (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Sat, 2 Sep 2017 21:26:15 -0400", "by mail-pf0-f173.google.com with SMTP id n73so9572482pfj.0\n\tfor <netdev@vger.kernel.org>; Sat, 02 Sep 2017 18:26:15 -0700 (PDT)", "from jkicinski-Precision-T1700.netronome.com ([75.53.12.129])\n\tby smtp.gmail.com with ESMTPSA id\n\tb187sm5180400pfg.133.2017.09.02.18.26.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSat, 02 Sep 2017 18:26:14 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=netronome-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=X9fW74yaFzVTu24WWeFFNg9gtWHOnBxgDMn6licbjnM=;\n\tb=HBFLsPp0zMzZNKvQl5eY9TmqkbMxeH4wXT8PbFsNS3Gri1T+Nj0xdC74mY8lfRkDmc\n\tIlv6r1aC1aRNbH7i4PJi2oh/FVwa06Aci8GEcD9JBC8hpo0GJ7pLJgl6nt8B3ADdCLBZ\n\t90Tm22wG8zVh/M7Br2cZwzV08WHjvgRDRvk3ncukzVe6aoem/1yZVOrhlTmBD8n4yGxX\n\tlkzmWYT+hOV0qtRi/rsnj0xyWqzoXusj0bl3ProyTIOHLAmj4pgwwk1ab/DcyixzM3Aa\n\t0gTCy+eP9yNRdX/l7V3dn2N+/VROBdJcWOzASsCrbycenq5rtpZRaAGzGTssNV6L3xUr\n\tR8yQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=X9fW74yaFzVTu24WWeFFNg9gtWHOnBxgDMn6licbjnM=;\n\tb=NYJ8PCm5yOx1didIBfcGjVcX3zkJ3xqpSjmDb0vYIuak0ZSwbaKmfZW4UFhLOdY6oH\n\thvvbV2MN4KTBvPkk8vbxBoTZ61dlK9/zaTTyk5NBSS8/h3madrCpFjVp3DN/kdz014XF\n\tPBkLwvPuIRBPM+jXWHcKwHEEK+2/cDRA5K/99VCid33xueGJ6yaS0pM9l0IiCWv5bN1x\n\tdGu23bnUCggkEnrdW6aMhq8CAoyyykIcQV0Vs0I+DY8LqEnfbQT4lWO6iHAvIi3Yyn/c\n\tWVC83a+L8FRga3dLvu/vQpQS3RcPR++QBKO8ZZUtEb6bckeumPGOCcfkd+pt/iuuRXl7\n\tdsHw==", "X-Gm-Message-State": "AHPjjUgJT4ZgZUT93pZrsycBgD1a+ilxeuf+1BWBlvGT+HTU2DBweb8i\n\tTr/W6V5SUQTxTsBrDSw=", "X-Google-Smtp-Source": "ADKCNb5Oht9MIB83mX8rFheZtPhOqH6IWwr3dklwQpM25D6xT9xM3cZ+vCZLUiZj4FtGp967sCC7kw==", "X-Received": "by 10.98.130.193 with SMTP id w184mr7362740pfd.218.1504401974525;\n\tSat, 02 Sep 2017 18:26:14 -0700 (PDT)", "From": "Jakub Kicinski <jakub.kicinski@netronome.com>", "To": "netdev@vger.kernel.org", "Cc": "oss-drivers@netronome.com, Jakub Kicinski <jakub.kicinski@netronome.com>", "Subject": "[PATCH net-next 2/6] nfp: flower: base lifetime of representors on\n\texistence of lower vNIC", "Date": "Sat, 2 Sep 2017 18:26:01 -0700", "Message-Id": "<20170903012605.7435-3-jakub.kicinski@netronome.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20170903012605.7435-1-jakub.kicinski@netronome.com>", "References": "<20170903012605.7435-1-jakub.kicinski@netronome.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Create representors after lower vNIC is registered and destroy\nthem before it is destroyed. Move the code out of start/stop\ncallbacks directly into vnic_init/clean callbacks. Make sure\nSR-IOV callbacks don't try to create representors when lower\ndevice does not exist.\n\nSigned-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>\nReviewed-by: Simon Horman <simon.horman@netronome.com>\n---\n drivers/net/ethernet/netronome/nfp/flower/main.c | 66 +++++++++++++++---------\n 1 file changed, 43 insertions(+), 23 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/netronome/nfp/flower/main.c b/drivers/net/ethernet/netronome/nfp/flower/main.c\nindex db59858c0f19..91fe03617106 100644\n--- a/drivers/net/ethernet/netronome/nfp/flower/main.c\n+++ b/drivers/net/ethernet/netronome/nfp/flower/main.c\n@@ -127,6 +127,11 @@ nfp_flower_repr_netdev_stop(struct nfp_app *app, struct nfp_repr *repr)\n \n static void nfp_flower_sriov_disable(struct nfp_app *app)\n {\n+\tstruct nfp_flower_priv *priv = app->priv;\n+\n+\tif (!priv->nn)\n+\t\treturn;\n+\n \tnfp_reprs_clean_and_free_by_type(app, NFP_REPR_TYPE_VF);\n }\n \n@@ -203,18 +208,16 @@ nfp_flower_spawn_vnic_reprs(struct nfp_app *app,\n \n static int nfp_flower_sriov_enable(struct nfp_app *app, int num_vfs)\n {\n+\tstruct nfp_flower_priv *priv = app->priv;\n+\n+\tif (!priv->nn)\n+\t\treturn 0;\n+\n \treturn nfp_flower_spawn_vnic_reprs(app,\n \t\t\t\t\t NFP_FLOWER_CMSG_PORT_VNIC_TYPE_VF,\n \t\t\t\t\t NFP_REPR_TYPE_VF, num_vfs);\n }\n \n-static void nfp_flower_stop(struct nfp_app *app)\n-{\n-\tnfp_reprs_clean_and_free_by_type(app, NFP_REPR_TYPE_PF);\n-\tnfp_reprs_clean_and_free_by_type(app, NFP_REPR_TYPE_PHYS_PORT);\n-\n-}\n-\n static int\n nfp_flower_spawn_phy_reprs(struct nfp_app *app, struct nfp_flower_priv *priv)\n {\n@@ -300,19 +303,6 @@ nfp_flower_spawn_phy_reprs(struct nfp_app *app, struct nfp_flower_priv *priv)\n \treturn err;\n }\n \n-static int nfp_flower_start(struct nfp_app *app)\n-{\n-\tint err;\n-\n-\terr = nfp_flower_spawn_phy_reprs(app, app->priv);\n-\tif (err)\n-\t\treturn err;\n-\n-\treturn nfp_flower_spawn_vnic_reprs(app,\n-\t\t\t\t\t NFP_FLOWER_CMSG_PORT_VNIC_TYPE_PF,\n-\t\t\t\t\t NFP_REPR_TYPE_PF, 1);\n-}\n-\n static int nfp_flower_vnic_alloc(struct nfp_app *app, struct nfp_net *nn,\n \t\t\t\t unsigned int id)\n {\n@@ -335,16 +325,49 @@ static void nfp_flower_vnic_clean(struct nfp_app *app, struct nfp_net *nn)\n {\n \tstruct nfp_flower_priv *priv = app->priv;\n \n+\tif (app->pf->num_vfs)\n+\t\tnfp_reprs_clean_and_free_by_type(app, NFP_REPR_TYPE_VF);\n+\tnfp_reprs_clean_and_free_by_type(app, NFP_REPR_TYPE_PF);\n+\tnfp_reprs_clean_and_free_by_type(app, NFP_REPR_TYPE_PHYS_PORT);\n+\n \tpriv->nn = NULL;\n }\n \n static int nfp_flower_vnic_init(struct nfp_app *app, struct nfp_net *nn)\n {\n \tstruct nfp_flower_priv *priv = app->priv;\n+\tint err;\n \n \tpriv->nn = nn;\n \n+\terr = nfp_flower_spawn_phy_reprs(app, app->priv);\n+\tif (err)\n+\t\tgoto err_clear_nn;\n+\n+\terr = nfp_flower_spawn_vnic_reprs(app,\n+\t\t\t\t\t NFP_FLOWER_CMSG_PORT_VNIC_TYPE_PF,\n+\t\t\t\t\t NFP_REPR_TYPE_PF, 1);\n+\tif (err)\n+\t\tgoto err_destroy_reprs_phy;\n+\n+\tif (app->pf->num_vfs) {\n+\t\terr = nfp_flower_spawn_vnic_reprs(app,\n+\t\t\t\t\t\t NFP_FLOWER_CMSG_PORT_VNIC_TYPE_VF,\n+\t\t\t\t\t\t NFP_REPR_TYPE_VF,\n+\t\t\t\t\t\t app->pf->num_vfs);\n+\t\tif (err)\n+\t\t\tgoto err_destroy_reprs_pf;\n+\t}\n+\n \treturn 0;\n+\n+err_destroy_reprs_pf:\n+\tnfp_reprs_clean_and_free_by_type(app, NFP_REPR_TYPE_PF);\n+err_destroy_reprs_phy:\n+\tnfp_reprs_clean_and_free_by_type(app, NFP_REPR_TYPE_PHYS_PORT);\n+err_clear_nn:\n+\tpriv->nn = NULL;\n+\treturn err;\n }\n \n static int nfp_flower_init(struct nfp_app *app)\n@@ -430,9 +453,6 @@ const struct nfp_app_type app_flower = {\n \t.repr_open\t= nfp_flower_repr_netdev_open,\n \t.repr_stop\t= nfp_flower_repr_netdev_stop,\n \n-\t.start\t\t= nfp_flower_start,\n-\t.stop\t\t= nfp_flower_stop,\n-\n \t.ctrl_msg_rx\t= nfp_flower_cmsg_rx,\n \n \t.sriov_enable\t= nfp_flower_sriov_enable,\n", "prefixes": [ "net-next", "2/6" ] }