Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/809187/?format=api
{ "id": 809187, "url": "http://patchwork.ozlabs.org/api/patches/809187/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170903012605.7435-7-jakub.kicinski@netronome.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170903012605.7435-7-jakub.kicinski@netronome.com>", "list_archive_url": null, "date": "2017-09-03T01:26:05", "name": "[net-next,6/6] nfp: flower: restore RTNL locking around representor updates", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ada6b0cb2ec7f47736d1f8db583dc1dcaedf20aa", "submitter": { "id": 67484, "url": "http://patchwork.ozlabs.org/api/people/67484/?format=api", "name": "Jakub Kicinski", "email": "jakub.kicinski@netronome.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170903012605.7435-7-jakub.kicinski@netronome.com/mbox/", "series": [ { "id": 1191, "url": "http://patchwork.ozlabs.org/api/series/1191/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=1191", "date": "2017-09-03T01:26:03", "name": "nfp: refactor app init, and minor flower fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1191/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809187/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809187/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=netronome-com.20150623.gappssmtp.com\n\theader.i=@netronome-com.20150623.gappssmtp.com\n\theader.b=\"t72uPgYs\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlFgS1s93z9sPk\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSun, 3 Sep 2017 11:26:28 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752984AbdICB00 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSat, 2 Sep 2017 21:26:26 -0400", "from mail-pg0-f47.google.com ([74.125.83.47]:37271 \"EHLO\n\tmail-pg0-f47.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752966AbdICB0S (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Sat, 2 Sep 2017 21:26:18 -0400", "by mail-pg0-f47.google.com with SMTP id 83so9852143pgb.4\n\tfor <netdev@vger.kernel.org>; Sat, 02 Sep 2017 18:26:18 -0700 (PDT)", "from jkicinski-Precision-T1700.netronome.com ([75.53.12.129])\n\tby smtp.gmail.com with ESMTPSA id\n\tb187sm5180400pfg.133.2017.09.02.18.26.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSat, 02 Sep 2017 18:26:17 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=netronome-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=qDcDlSUtoq4vX+mp0wI1TuArkLjeMH1wYJY2IPj/FcE=;\n\tb=t72uPgYsZn2ayQVup7ZUn0BfYKWIU/o5GgLaun1bJ7z6vB/Gnzc414Wioxzo8PBelC\n\t1ZEVuK48qreilT3iilEDCImslXi3tN9SU1g3twMSMSAgiyWNIxN7l/OAcifcsLz4vfGF\n\t0Uu77R9n1lIyrSvNtM3wtK7zvnNNSmYd2GxcLHzMyW8VEDovdSMPCwl7aop2AzuRdAZC\n\tAN9ccunhCrdhY+JUFzdxeo0Yuf7+L2do8PS34s1CCUyNx0SiDcAZ9FBvgokm6LM0w0RE\n\tkG3M7EzfyXHg9tTKhu+BfF/Pb6Tzo/gNpf67OcXpdHQUN1MQjXB47xnISVOUnf0oZ2kW\n\tgBVQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=qDcDlSUtoq4vX+mp0wI1TuArkLjeMH1wYJY2IPj/FcE=;\n\tb=rz5bO/S8FwA6gg0DN+stilNwZW5se4dXGhjW4LP0yiXu+1LtcDHlg9Pe8oF/SdNujE\n\tLx40YL54q+oxOVobz9qb2gtuWyMmXXyF3d/JxQQUjoq+b+RRzFkf4E79jU2odcxkdb1Q\n\tg90v2zQCoRhK7mZe1R8eNHubVKBOJx5UocJy9pPNUw+OXZ5IDjvWQ6klbQsIQbU2dj2z\n\tYKQAOTsc99S24J+P9Vp6DTy4Oril2sKTOs9N0TTpV4oQyRK0AGtZvKIT4nxvLPpqyGMe\n\t68YFeDzKDfLgGyzmt8FuIKghv9Qs5O5njMjQ0f0263mO2H28DbeNDhaBcPjmlpo3xpqJ\n\t4hEg==", "X-Gm-Message-State": "AHPjjUhn3qZvz0Yewq6PzWuBKF67zkyWsWm8Yl19IeAxNtDgRhKKOJz2\n\tqxgeqZTMgshrxsDJlJs=", "X-Google-Smtp-Source": "ADKCNb4haJwfxkEQLPoyIYHbsQ9PFi2N1NPiOoWndblbInA7PRotqJZgKpoCgZeoffbVucluX4mA0g==", "X-Received": "by 10.98.219.198 with SMTP id f189mr2221267pfg.110.1504401977787;\n\tSat, 02 Sep 2017 18:26:17 -0700 (PDT)", "From": "Jakub Kicinski <jakub.kicinski@netronome.com>", "To": "netdev@vger.kernel.org", "Cc": "oss-drivers@netronome.com, Jakub Kicinski <jakub.kicinski@netronome.com>", "Subject": "[PATCH net-next 6/6] nfp: flower: restore RTNL locking around\n\trepresentor updates", "Date": "Sat, 2 Sep 2017 18:26:05 -0700", "Message-Id": "<20170903012605.7435-7-jakub.kicinski@netronome.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20170903012605.7435-1-jakub.kicinski@netronome.com>", "References": "<20170903012605.7435-1-jakub.kicinski@netronome.com>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "When we moved to updating representors from a workqueue grabbing\nthe RTNL somehow got lost in the process. Restore it, and make\nsure RCU lock is not held while we are grabbing the RTNL. RCU\nprotects the representor table, so since we will be under RTNL\nwe can drop RCU lock as soon as we find the netdev pointer.\nRTNL is needed for the dev_set_mtu() call.\n\nFixes: 2dff19622421 (\"nfp: process MTU updates from firmware flower app\")\nSigned-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>\nReviewed-by: Simon Horman <simon.horman@netronome.com>\n---\n drivers/net/ethernet/netronome/nfp/flower/cmsg.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/netronome/nfp/flower/cmsg.c b/drivers/net/ethernet/netronome/nfp/flower/cmsg.c\nindex e014d862b9b6..c3ca05d10fe1 100644\n--- a/drivers/net/ethernet/netronome/nfp/flower/cmsg.c\n+++ b/drivers/net/ethernet/netronome/nfp/flower/cmsg.c\n@@ -141,12 +141,14 @@ nfp_flower_cmsg_portmod_rx(struct nfp_app *app, struct sk_buff *skb)\n \tmsg = nfp_flower_cmsg_get_data(skb);\n \tlink = msg->info & NFP_FLOWER_CMSG_PORTMOD_INFO_LINK;\n \n+\trtnl_lock();\n \trcu_read_lock();\n \tnetdev = nfp_app_repr_get(app, be32_to_cpu(msg->portnum));\n+\trcu_read_unlock();\n \tif (!netdev) {\n \t\tnfp_flower_cmsg_warn(app, \"ctrl msg for unknown port 0x%08x\\n\",\n \t\t\t\t be32_to_cpu(msg->portnum));\n-\t\trcu_read_unlock();\n+\t\trtnl_unlock();\n \t\treturn;\n \t}\n \n@@ -161,7 +163,7 @@ nfp_flower_cmsg_portmod_rx(struct nfp_app *app, struct sk_buff *skb)\n \t} else {\n \t\tnetif_carrier_off(netdev);\n \t}\n-\trcu_read_unlock();\n+\trtnl_unlock();\n }\n \n static void\n", "prefixes": [ "net-next", "6/6" ] }