Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/809170/?format=api
{ "id": 809170, "url": "http://patchwork.ozlabs.org/api/patches/809170/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170902214929.2890-7-jiri@resnulli.us/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170902214929.2890-7-jiri@resnulli.us>", "list_archive_url": null, "date": "2017-09-02T21:49:14", "name": "[net-next,v2,06/21] mlxsw: reg: Extract mlxsw_reg_ritr_mac_pack()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "cdd9244466bdcb29b71b298b8bbca1d11a6b5dc6", "submitter": { "id": 15321, "url": "http://patchwork.ozlabs.org/api/people/15321/?format=api", "name": "Jiri Pirko", "email": "jiri@resnulli.us" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170902214929.2890-7-jiri@resnulli.us/mbox/", "series": [ { "id": 1180, "url": "http://patchwork.ozlabs.org/api/series/1180/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=1180", "date": "2017-09-02T21:49:08", "name": "mlxsw: Offloading GRE tunnels", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/1180/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809170/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809170/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=resnulli-us.20150623.gappssmtp.com\n\theader.i=@resnulli-us.20150623.gappssmtp.com\n\theader.b=\"QBBhskl6\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xl8tv1q24z9sRY\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSun, 3 Sep 2017 07:51:03 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752965AbdIBVvB (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSat, 2 Sep 2017 17:51:01 -0400", "from mail-wr0-f194.google.com ([209.85.128.194]:36641 \"EHLO\n\tmail-wr0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752761AbdIBVtn (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Sat, 2 Sep 2017 17:49:43 -0400", "by mail-wr0-f194.google.com with SMTP id 40so1620578wrv.3\n\tfor <netdev@vger.kernel.org>; Sat, 02 Sep 2017 14:49:42 -0700 (PDT)", "from localhost (jirka.pirko.cz. [84.16.102.26])\n\tby smtp.gmail.com with ESMTPSA id\n\tr65sm1669368wmf.19.2017.09.02.14.49.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSat, 02 Sep 2017 14:49:40 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=resnulli-us.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=EaDouSy9DdrV6ciGe8GtuKFnzunYQFlHo93maNyl1t0=;\n\tb=QBBhskl6H4yUe6Gp32nF5sieCzamtS7BPMPM33c4wJCMOxwMZnALnWcJyWZg12nBnt\n\tamgX2uDxNsoA6IP529zhyoTc0VHHI1F/rfTTRWCnYB91Cduy7lwMHWKapOA06Mgv0dgc\n\t2ABL5gSLOE62DhZiaNkBv4PAtJS1YIG4n7Ends/0a6viDIFqjM08gbupE0p6KOpjPPFv\n\tZFXvEEqZD2NCbxk/eERmw31/oUcvotZuC/1306qFSwZ5B8/pJqpJ76P56+GQp9B2Q6vN\n\tLFfpduUwz7YCuJIh8YiEulMfW49Ds8AW6Og/QxQJV8Vth/WNPo9/+99GwlfD04zvjjjY\n\tZhsA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=EaDouSy9DdrV6ciGe8GtuKFnzunYQFlHo93maNyl1t0=;\n\tb=YqK6xXL20Gj08MtW0AbHuB1BSDFCIUK7bcqE/kxbFUB8r609402abbcXAeKiG3FAcB\n\tOyw+H1MYdT0TOqdrt2AL+Uc/il2/jZzOd37G3A0SjaqoF6fpMI/B+nyk9ERxjMXyDBLv\n\tSQaADhvSHB18HGpXtKjt+WHlHmu2pkJZK8xdawD0s0MUrNeTBEyWdAuV6vJPr9R75Ute\n\tf0M0aveF6/Udc6ZfG5I7TWA2zn+gsiREOLs1MysbRY/zpUT2fwnEthEGASY1C6m8VW8m\n\tDT3CosLtvTfZ3nP7wOYTbJJ3OExfrBtjSL6i623mhIkVA/ESTdCGQL0TKkdXwPEHkpcn\n\tQLDA==", "X-Gm-Message-State": "AHPjjUjV/QmqglW/kxpp58EnCgS0ukGMmTBlsRzIES2rOlYAjCfL8KyK\n\tNKDPzNn9eQ47Fd20T3s=", "X-Google-Smtp-Source": "ADKCNb5wG0yhU0nUmHGYb292RJpkLDnvjdpYqFJlis4+NEQ/mu+LOkIp748G8RBT3rkVzooJcctbQg==", "X-Received": "by 10.223.133.245 with SMTP id 50mr3413485wru.22.1504388981427; \n\tSat, 02 Sep 2017 14:49:41 -0700 (PDT)", "From": "Jiri Pirko <jiri@resnulli.us>", "To": "netdev@vger.kernel.org", "Cc": "davem@davemloft.net, petrm@mellanox.com, idosch@mellanox.com,\n\tmlxsw@mellanox.com", "Subject": "[patch net-next v2 06/21] mlxsw: reg: Extract\n\tmlxsw_reg_ritr_mac_pack()", "Date": "Sat, 2 Sep 2017 23:49:14 +0200", "Message-Id": "<20170902214929.2890-7-jiri@resnulli.us>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20170902214929.2890-1-jiri@resnulli.us>", "References": "<20170902214929.2890-1-jiri@resnulli.us>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: Petr Machata <petrm@mellanox.com>\n\nUnlike other interface types, loopback RIFs do not have MAC address. So\ndrop the corresponding argument from mlxsw_reg_ritr_pack() and move it\nto a new function. Call that from callers of mlxsw_reg_ritr_pack.\n\nSigned-off-by: Petr Machata <petrm@mellanox.com>\nReviewed-by: Ido Schimmel <idosch@mellanox.com>\nSigned-off-by: Jiri Pirko <jiri@mellanox.com>\n---\n drivers/net/ethernet/mellanox/mlxsw/reg.h | 7 +++++--\n drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 7 ++++---\n 2 files changed, 9 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/mellanox/mlxsw/reg.h b/drivers/net/ethernet/mellanox/mlxsw/reg.h\nindex a6eb96f..d80cf9b 100644\n--- a/drivers/net/ethernet/mellanox/mlxsw/reg.h\n+++ b/drivers/net/ethernet/mellanox/mlxsw/reg.h\n@@ -4263,8 +4263,7 @@ static inline void mlxsw_reg_ritr_sp_if_pack(char *payload, bool lag,\n \n static inline void mlxsw_reg_ritr_pack(char *payload, bool enable,\n \t\t\t\t enum mlxsw_reg_ritr_if_type type,\n-\t\t\t\t u16 rif, u16 vr_id, u16 mtu,\n-\t\t\t\t const char *mac)\n+\t\t\t\t u16 rif, u16 vr_id, u16 mtu)\n {\n \tbool op = enable ? MLXSW_REG_RITR_RIF_CREATE : MLXSW_REG_RITR_RIF_DEL;\n \n@@ -4280,6 +4279,10 @@ static inline void mlxsw_reg_ritr_pack(char *payload, bool enable,\n \tmlxsw_reg_ritr_lb_en_set(payload, 1);\n \tmlxsw_reg_ritr_virtual_router_set(payload, vr_id);\n \tmlxsw_reg_ritr_mtu_set(payload, mtu);\n+}\n+\n+static inline void mlxsw_reg_ritr_mac_pack(char *payload, const char *mac)\n+{\n \tmlxsw_reg_ritr_if_mac_memcpy_to(payload, mac);\n }\n \ndiff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c\nindex de15eac..3ddfbe3 100644\n--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c\n+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c\n@@ -4955,8 +4955,8 @@ static int mlxsw_sp_rif_subport_op(struct mlxsw_sp_rif *rif, bool enable)\n \n \trif_subport = mlxsw_sp_rif_subport_rif(rif);\n \tmlxsw_reg_ritr_pack(ritr_pl, enable, MLXSW_REG_RITR_SP_IF,\n-\t\t\t rif->rif_index, rif->vr_id, rif->dev->mtu,\n-\t\t\t rif->dev->dev_addr);\n+\t\t\t rif->rif_index, rif->vr_id, rif->dev->mtu);\n+\tmlxsw_reg_ritr_mac_pack(ritr_pl, rif->dev->dev_addr);\n \tmlxsw_reg_ritr_sp_if_pack(ritr_pl, rif_subport->lag,\n \t\t\t\t rif_subport->lag ? rif_subport->lag_id :\n \t\t\t\t\t\t rif_subport->system_port,\n@@ -4998,7 +4998,8 @@ static int mlxsw_sp_rif_vlan_fid_op(struct mlxsw_sp_rif *rif,\n \tchar ritr_pl[MLXSW_REG_RITR_LEN];\n \n \tmlxsw_reg_ritr_pack(ritr_pl, enable, type, rif->rif_index, rif->vr_id,\n-\t\t\t rif->dev->mtu, rif->dev->dev_addr);\n+\t\t\t rif->dev->mtu);\n+\tmlxsw_reg_ritr_mac_pack(ritr_pl, rif->dev->dev_addr);\n \tmlxsw_reg_ritr_fid_set(ritr_pl, type, vid_fid);\n \n \treturn mlxsw_reg_write(mlxsw_sp->core, MLXSW_REG(ritr), ritr_pl);\n", "prefixes": [ "net-next", "v2", "06/21" ] }