Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 809053,
    "url": "http://patchwork.ozlabs.org/api/patches/809053/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20170902090649.28426-4-antoine.tenart@free-electrons.com/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20170902090649.28426-4-antoine.tenart@free-electrons.com>",
    "list_archive_url": null,
    "date": "2017-09-02T09:06:49",
    "name": "[net-next,v3,3/3] net: mvpp2: fallback using h/w and random mac if the dt one isn't valid",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "a1bf44d77f846928429a3b950255873a444e6b29",
    "submitter": {
        "id": 61603,
        "url": "http://patchwork.ozlabs.org/api/people/61603/?format=api",
        "name": "Antoine Tenart",
        "email": "antoine.tenart@free-electrons.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20170902090649.28426-4-antoine.tenart@free-electrons.com/mbox/",
    "series": [
        {
            "id": 1145,
            "url": "http://patchwork.ozlabs.org/api/series/1145/?format=api",
            "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=1145",
            "date": "2017-09-02T09:06:49",
            "name": "net: mvpp2: improve the mac address retrieval logic",
            "version": 3,
            "mbox": "http://patchwork.ozlabs.org/series/1145/mbox/"
        }
    ],
    "comments": "http://patchwork.ozlabs.org/api/patches/809053/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/809053/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Authentication-Results": "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkqy81C9Lz9s7M\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat,  2 Sep 2017 19:07:43 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752646AbdIBJHR (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSat, 2 Sep 2017 05:07:17 -0400",
            "from mail.free-electrons.com ([62.4.15.54]:46065 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750992AbdIBJHO (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Sat, 2 Sep 2017 05:07:14 -0400",
            "by mail.free-electrons.com (Postfix, from userid 110)\n\tid D254921DAE; Sat,  2 Sep 2017 11:07:10 +0200 (CEST)",
            "from localhost (AToulouse-654-1-397-66.w90-55.abo.wanadoo.fr\n\t[90.55.196.66])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id A9DFF20A10;\n\tSat,  2 Sep 2017 11:07:10 +0200 (CEST)"
        ],
        "X-Spam-Checker-Version": "SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com",
        "X-Spam-Level": "",
        "X-Spam-Status": "No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0",
        "From": "Antoine Tenart <antoine.tenart@free-electrons.com>",
        "To": "davem@davemloft.net",
        "Cc": "Antoine Tenart <antoine.tenart@free-electrons.com>, andrew@lunn.ch,\n\tgregory.clement@free-electrons.com,\n\tthomas.petazzoni@free-electrons.com, nadavh@marvell.com,\n\tlinux@armlinux.org.uk, linux-kernel@vger.kernel.org,\n\tmw@semihalf.com, stefanc@marvell.com, netdev@vger.kernel.org",
        "Subject": "[PATCH net-next v3 3/3] net: mvpp2: fallback using h/w and random\n\tmac if the dt one isn't valid",
        "Date": "Sat,  2 Sep 2017 11:06:49 +0200",
        "Message-Id": "<20170902090649.28426-4-antoine.tenart@free-electrons.com>",
        "X-Mailer": "git-send-email 2.13.5",
        "In-Reply-To": "<20170902090649.28426-1-antoine.tenart@free-electrons.com>",
        "References": "<20170902090649.28426-1-antoine.tenart@free-electrons.com>",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "When using a mac address described in the device tree, a check is made\nto see if it is valid. When it's not, no fallback is defined. This\npatches tries to get the mac address from h/w (or use a random one if\nthe h/w one isn't valid) when the dt mac address isn't valid.\n\nSigned-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>\n---\n drivers/net/ethernet/marvell/mvpp2.c | 23 ++++++++++++-----------\n 1 file changed, 12 insertions(+), 11 deletions(-)",
    "diff": "diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c\nindex c6003508f166..dd0ee2691c86 100644\n--- a/drivers/net/ethernet/marvell/mvpp2.c\n+++ b/drivers/net/ethernet/marvell/mvpp2.c\n@@ -7477,19 +7477,20 @@ static void mvpp2_port_copy_mac_addr(struct net_device *dev, struct mvpp2 *priv,\n \tif (dt_mac_addr && is_valid_ether_addr(dt_mac_addr)) {\n \t\t*mac_from = \"device tree\";\n \t\tether_addr_copy(dev->dev_addr, dt_mac_addr);\n-\t} else {\n-\t\tif (priv->hw_version == MVPP21) {\n-\t\t\tmvpp21_get_mac_address(port, hw_mac_addr);\n-\t\t\tif (is_valid_ether_addr(hw_mac_addr)) {\n-\t\t\t\t*mac_from = \"hardware\";\n-\t\t\t\tether_addr_copy(dev->dev_addr, hw_mac_addr);\n-\t\t\t\treturn;\n-\t\t\t}\n-\t\t}\n+\t\treturn;\n+\t}\n \n-\t\t*mac_from = \"random\";\n-\t\teth_hw_addr_random(dev);\n+\tif (priv->hw_version == MVPP21) {\n+\t\tmvpp21_get_mac_address(port, hw_mac_addr);\n+\t\tif (is_valid_ether_addr(hw_mac_addr)) {\n+\t\t\t*mac_from = \"hardware\";\n+\t\t\tether_addr_copy(dev->dev_addr, hw_mac_addr);\n+\t\t\treturn;\n+\t\t}\n \t}\n+\n+\t*mac_from = \"random\";\n+\teth_hw_addr_random(dev);\n }\n \n /* Ports initialization */\n",
    "prefixes": [
        "net-next",
        "v3",
        "3/3"
    ]
}