Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/809036/?format=api
{ "id": 809036, "url": "http://patchwork.ozlabs.org/api/patches/809036/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/patch/20170902004138.17967-1-casantos@datacom.ind.br/", "project": { "id": 27, "url": "http://patchwork.ozlabs.org/api/projects/27/?format=api", "name": "Buildroot development", "link_name": "buildroot", "list_id": "buildroot.buildroot.org", "list_email": "buildroot@buildroot.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170902004138.17967-1-casantos@datacom.ind.br>", "list_archive_url": null, "date": "2017-09-02T00:41:38", "name": "[v5] util-linux: add menu items for login utilities", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e47bf0622b74fd8da2868461092b58e11bba2cdb", "submitter": { "id": 65860, "url": "http://patchwork.ozlabs.org/api/people/65860/?format=api", "name": "Carlos Santos", "email": "casantos@datacom.ind.br" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/buildroot/patch/20170902004138.17967-1-casantos@datacom.ind.br/mbox/", "series": [ { "id": 1133, "url": "http://patchwork.ozlabs.org/api/series/1133/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/list/?series=1133", "date": "2017-09-02T00:41:38", "name": "[v5] util-linux: add menu items for login utilities", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/1133/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809036/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809036/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<buildroot-bounces@busybox.net>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "buildroot@lists.busybox.net" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "buildroot@osuosl.org" ], "Authentication-Results": "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=<UNKNOWN>)", "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkckg02SYz9ryr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 2 Sep 2017 10:42:01 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D79AA30778;\n\tSat, 2 Sep 2017 00:41:58 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6++o0zIrjE8l; Sat, 2 Sep 2017 00:41:57 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 30DED2D19E;\n\tSat, 2 Sep 2017 00:41:57 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id C05DE1C201E\n\tfor <buildroot@lists.busybox.net>;\n\tSat, 2 Sep 2017 00:41:55 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B7ABE8A1CB\n\tfor <buildroot@lists.busybox.net>;\n\tSat, 2 Sep 2017 00:41:55 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 7MQxLr3MArBf for <buildroot@lists.busybox.net>;\n\tSat, 2 Sep 2017 00:41:54 +0000 (UTC)", "from mail.datacom.ind.br (mx.datacom.ind.br [177.66.5.10])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 9567A8A1C5\n\tfor <buildroot@buildroot.org>; Sat, 2 Sep 2017 00:41:53 +0000 (UTC)", "from mail.datacom.ind.br (localhost [127.0.0.1])\n\tby mail.datacom.ind.br (Postfix) with ESMTPS id 58E4D150C64B;\n\tFri, 1 Sep 2017 21:41:28 -0300 (BRT)", "from localhost (localhost [127.0.0.1])\n\tby mail.datacom.ind.br (Postfix) with ESMTP id 3C25A150C674;\n\tFri, 1 Sep 2017 21:41:28 -0300 (BRT)", "from mail.datacom.ind.br ([127.0.0.1])\n\tby localhost (mail.datacom.ind.br [127.0.0.1]) (amavisd-new,\n\tport 10026)\n\twith ESMTP id I62xLKjmtb50; Fri, 1 Sep 2017 21:41:28 -0300 (BRT)", "from p7-1130br.casantos.org (189.27.235.240.dynamic.adsl.gvt.net.br\n\t[189.27.235.240])\n\tby mail.datacom.ind.br (Postfix) with ESMTPSA id AEE6B150C64B;\n\tFri, 1 Sep 2017 21:41:27 -0300 (BRT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Carlos Santos <casantos@datacom.ind.br>", "To": "buildroot@buildroot.org", "Date": "Fri, 1 Sep 2017 21:41:38 -0300", "Message-Id": "<20170902004138.17967-1-casantos@datacom.ind.br>", "X-Mailer": "git-send-email 2.13.5", "In-Reply-To": "<20170825212645.1467-1-casantos@datacom.ind.br>", "References": "<20170825212645.1467-1-casantos@datacom.ind.br>", "Cc": "Thomas Petazzoni <thomas.petazzoni@free-electrons.com>", "Subject": "[Buildroot] [PATCH v5] util-linux: add menu items for login\n\tutilities", "X-BeenThere": "buildroot@busybox.net", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Discussion and development of buildroot <buildroot.busybox.net>", "List-Unsubscribe": "<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>", "List-Archive": "<http://lists.busybox.net/pipermail/buildroot/>", "List-Post": "<mailto:buildroot@busybox.net>", "List-Help": "<mailto:buildroot-request@busybox.net?subject=help>", "List-Subscribe": "<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "buildroot-bounces@busybox.net", "Sender": "\"buildroot\" <buildroot-bounces@busybox.net>" }, "content": "This change extends to the login utilities the current policy of having\na selection item in the configuration menu for each utility that has an\n--enable/--disable knob in the \"configure\" script:\n\n- add selection items for login, runuser, su and sulogin (there was\n already an item for \"last\")\n- move \"login utilities\" to Config.in.legacy\n- make \"login utilities\" select last, login, runuser, su and sulogin\n\nSigned-off-by: Carlos Santos <casantos@datacom.ind.br>\n\n---\nChanges v1->v2\n - do not add section titles\n - deprecate the \"login utilities\" group\nChanges v2->v3\n - improve comments\n - fix spelling errors\n - add comment to show when \"login\" is unavailable\nChanges v3->v4\n - install PAM files only if linux-pam is selected\nChanges v4->v5\n - Fix merge conflict in Config.in.legacy\n---\n Config.in.legacy | 15 ++++++++++++++\n package/util-linux/Config.in | 45 ++++++++++++++++++++++++++++------------\n package/util-linux/util-linux.mk | 10 +++++----\n 3 files changed, 53 insertions(+), 17 deletions(-)", "diff": "diff --git a/Config.in.legacy b/Config.in.legacy\nindex d35b409423..44303a42bc 100644\n--- a/Config.in.legacy\n+++ b/Config.in.legacy\n@@ -143,6 +143,21 @@ comment \"----------------------------------------------------\"\n endif\n \n ###############################################################################\n+comment \"Legacy options removed in 2017.11\"\n+\n+config BR2_PACKAGE_UTIL_LINUX_LOGIN_UTILS\n+\tbool \"util-linux login utilities option removed\"\n+\tselect BR2_LEGACY\n+\tselect BR2_PACKAGE_UTIL_LINUX_LAST\n+\tselect BR2_PACKAGE_UTIL_LINUX_LOGIN\n+\tselect BR2_PACKAGE_UTIL_LINUX_RUNUSER\n+\tselect BR2_PACKAGE_UTIL_LINUX_SU\n+\tselect BR2_PACKAGE_UTIL_LINUX_SULOGIN\n+\thelp\n+\t Login utilities (last, login, runuser, su, sulogin) now have\n+\t their own configuration options in the util-linux menu.\n+\n+###############################################################################\n comment \"Legacy options removed in 2017.08\"\n \n config BR2_PACKAGE_SIMICSFS\ndiff --git a/package/util-linux/Config.in b/package/util-linux/Config.in\nindex cba590c4f9..b3494af101 100644\n--- a/package/util-linux/Config.in\n+++ b/package/util-linux/Config.in\n@@ -164,26 +164,25 @@ config BR2_PACKAGE_UTIL_LINUX_LINE\n \thelp\n \t Read one line\n \n-config BR2_PACKAGE_UTIL_LINUX_LOGIN_UTILS\n-\tbool \"login utilities\"\n-\tdepends on BR2_USE_MMU # fork() (login, runuser, su, sulogin)\n-\tdepends on (BR2_ENABLE_LOCALE && BR2_USE_WCHAR) # linux-pam\n-\tdepends on !BR2_STATIC_LIBS\n+config BR2_PACKAGE_UTIL_LINUX_LOGGER\n+\tbool \"logger\"\n+\thelp\n+\t Enter messages into the system log\n+\n+config BR2_PACKAGE_UTIL_LINUX_LOGIN\n+\tbool \"login\"\n+\tdepends on BR2_ENABLE_LOCALE # linux-pam\n+\tdepends on BR2_USE_WCHAR # linux-pam\n \tdepends on !BR2_TOOLCHAIN_USES_MUSL # linux-pam\n-\tdepends on BR2_USE_MMU # linux-pam\n+\tdepends on BR2_USE_MMU # fork(), linux-pam\n \tselect BR2_PACKAGE_LINUX_PAM\n \thelp\n-\t Login utilities (last, login, runuser, su, sulogin)\n+\t Begin a session on the system\n \n-comment \"login utilities needs a uClibc or glibc toolchain w/ wchar, locale, dynamic library\"\n+comment \"login needs a uClibc or glibc toolchain w/ wchar, locale, dynamic library\"\n \tdepends on !(BR2_ENABLE_LOCALE && BR2_USE_WCHAR) \\\n \t\t|| BR2_STATIC_LIBS || BR2_TOOLCHAIN_USES_MUSL\n \n-config BR2_PACKAGE_UTIL_LINUX_LOGGER\n-\tbool \"logger\"\n-\thelp\n-\t Enter messages into the system log\n-\n config BR2_PACKAGE_UTIL_LINUX_LOSETUP\n \tbool \"losetup\"\n \tdepends on BR2_USE_MMU # libsmartcols\n@@ -296,6 +295,14 @@ config BR2_PACKAGE_UTIL_LINUX_RESET\n \thelp\n \t Reset the terminal\n \n+config BR2_PACKAGE_UTIL_LINUX_RUNUSER\n+\tbool \"runuser\"\n+\tdepends on BR2_USE_MMU # fork()\n+\thelp\n+\t Run a command with substitute user and group ID (does not need\n+\t to ask for a password, because it may be executed by the root\n+\t user only)\n+\n config BR2_PACKAGE_UTIL_LINUX_SCHEDUTILS\n \tbool \"scheduling utilities\"\n \thelp\n@@ -313,6 +320,18 @@ config BR2_PACKAGE_UTIL_LINUX_SETTERM\n \thelp\n \t Set terminal attributes\n \n+config BR2_PACKAGE_UTIL_LINUX_SU\n+\tbool \"su\"\n+\tdepends on BR2_USE_MMU # fork()\n+\thelp\n+\t Run a command with substitute user and group ID\n+\n+config BR2_PACKAGE_UTIL_LINUX_SULOGIN\n+\tbool \"sulogin\"\n+\tdepends on BR2_USE_MMU # fork()\n+\thelp\n+\t Single-user login\n+\n config BR2_PACKAGE_UTIL_LINUX_SWITCH_ROOT\n \tbool \"switch_root\"\n \tdepends on BR2_USE_MMU # fork()\ndiff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk\nindex fc32668869..5ebb5e6720 100644\n--- a/package/util-linux/util-linux.mk\n+++ b/package/util-linux/util-linux.mk\n@@ -118,7 +118,7 @@ UTIL_LINUX_CONF_OPTS += \\\n \t$(if $(BR2_PACKAGE_UTIL_LINUX_LIBUUID),--enable-libuuid,--disable-libuuid) \\\n \t$(if $(BR2_PACKAGE_UTIL_LINUX_LINE),--enable-line,--disable-line) \\\n \t$(if $(BR2_PACKAGE_UTIL_LINUX_LOGGER),--enable-logger,--disable-logger) \\\n-\t$(if $(BR2_PACKAGE_UTIL_LINUX_LOGIN_UTILS),--enable-last --enable-login --enable-runuser --enable-su --enable-sulogin,--disable-last --disable-login --disable-runuser --disable-su --disable-sulogin) \\\n+\t$(if $(BR2_PACKAGE_UTIL_LINUX_LOGIN),--enable-login,--disable-login) \\\n \t$(if $(BR2_PACKAGE_UTIL_LINUX_LOSETUP),--enable-losetup,--disable-losetup) \\\n \t$(if $(BR2_PACKAGE_UTIL_LINUX_LSLOGINS),--enable-lslogins,--disable-lslogins) \\\n \t$(if $(BR2_PACKAGE_UTIL_LINUX_LSMEM),--enable-lsmem,--disable-lsmem) \\\n@@ -136,9 +136,12 @@ UTIL_LINUX_CONF_OPTS += \\\n \t$(if $(BR2_PACKAGE_UTIL_LINUX_RAW),--enable-raw,--disable-raw) \\\n \t$(if $(BR2_PACKAGE_UTIL_LINUX_RENAME),--enable-rename,--disable-rename) \\\n \t$(if $(BR2_PACKAGE_UTIL_LINUX_RESET),--enable-reset,--disable-reset) \\\n+\t$(if $(BR2_PACKAGE_UTIL_LINUX_RUNUSER),--enable-runuser,--disable-runuser) \\\n \t$(if $(BR2_PACKAGE_UTIL_LINUX_SCHEDUTILS),--enable-schedutils,--disable-schedutils) \\\n \t$(if $(BR2_PACKAGE_UTIL_LINUX_SETPRIV),--enable-setpriv,--disable-setpriv) \\\n \t$(if $(BR2_PACKAGE_UTIL_LINUX_SETTERM),--enable-setterm,--disable-setterm) \\\n+\t$(if $(BR2_PACKAGE_UTIL_LINUX_SU),--enable-su,--disable-su) \\\n+\t$(if $(BR2_PACKAGE_UTIL_LINUX_SULOGIN),--enable-sulogin,--disable-sulogin) \\\n \t$(if $(BR2_PACKAGE_UTIL_LINUX_SWITCH_ROOT),--enable-switch_root,--disable-switch_root) \\\n \t$(if $(BR2_PACKAGE_UTIL_LINUX_TUNELP),--enable-tunelp,--disable-tunelp) \\\n \t$(if $(BR2_PACKAGE_UTIL_LINUX_UL),--enable-ul,--disable-ul) \\\n@@ -200,7 +203,7 @@ UTIL_LINUX_CONF_OPTS += --without-audit\n endif\n \n # Install PAM configuration files\n-ifeq ($(BR2_PACKAGE_UTIL_LINUX_LOGIN_UTILS),y)\n+ifeq ($(BR2_PACKAGE_UTIL_LINUX_SU)$(BR2_PACKAGE_LINUX_PAM),yy)\n define UTIL_LINUX_INSTALL_PAMFILES\n \t$(INSTALL) -m 0644 package/util-linux/su.pam \\\n \t\t$(TARGET_DIR)/etc/pam.d/su\n@@ -208,9 +211,8 @@ define UTIL_LINUX_INSTALL_PAMFILES\n \t\t$(TARGET_DIR)/etc/pam.d/su-l\n \t$(UTIL_LINUX_SELINUX_PAMFILES_TWEAK)\n endef\n-endif\n-\n UTIL_LINUX_POST_INSTALL_TARGET_HOOKS += UTIL_LINUX_INSTALL_PAMFILES\n+endif\n \n # Install agetty->getty symlink to avoid breakage when there's no busybox\n ifeq ($(BR2_PACKAGE_UTIL_LINUX_AGETTY),y)\n", "prefixes": [ "v5" ] }