Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/809035/?format=api
{ "id": 809035, "url": "http://patchwork.ozlabs.org/api/patches/809035/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/1504312354-62020-1-git-send-email-f.fainelli@gmail.com/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1504312354-62020-1-git-send-email-f.fainelli@gmail.com>", "list_archive_url": null, "date": "2017-09-02T00:32:34", "name": "[net-next] net: systemport: Correctly set TSB endian for host", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f4bee8bff6d3859e01ef34595c77bc9ea590a466", "submitter": { "id": 2800, "url": "http://patchwork.ozlabs.org/api/people/2800/?format=api", "name": "Florian Fainelli", "email": "f.fainelli@gmail.com" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/1504312354-62020-1-git-send-email-f.fainelli@gmail.com/mbox/", "series": [ { "id": 1132, "url": "http://patchwork.ozlabs.org/api/series/1132/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/list/?series=1132", "date": "2017-09-02T00:32:34", "name": "[net-next] net: systemport: Correctly set TSB endian for host", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1132/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/809035/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/809035/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"MbS1WTcr\"; dkim-atps=neutral" ], "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkcfj15b1z9sPt\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 2 Sep 2017 10:38:37 +1000 (AEST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752475AbdIBAid (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 1 Sep 2017 20:38:33 -0400", "from mail-qk0-f193.google.com ([209.85.220.193]:37873 \"EHLO\n\tmail-qk0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752264AbdIBAic (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 1 Sep 2017 20:38:32 -0400", "by mail-qk0-f193.google.com with SMTP id c6so499044qkh.4\n\tfor <netdev@vger.kernel.org>; Fri, 01 Sep 2017 17:38:31 -0700 (PDT)", "from stb-bld-04.irv.broadcom.com ([192.19.255.250])\n\tby smtp.gmail.com with ESMTPSA id\n\t23sm1097761qtm.56.2017.09.01.17.38.28\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 01 Sep 2017 17:38:29 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=qozWQc45lNFOkAQQ3j2roNrvpdbOEe1vIG4ZElmcSFo=;\n\tb=MbS1WTcr4Xln17KL4BQnnl6rRX9tfUKXmsOccks0gmy0OIJumdvrCAWX0CTbhj0/Av\n\tBHnuGwwV5zmTh60KZb1VPwcbV06mD41cbQyiv7dY8xJHZ8yEAasy/7HJ98Wj01A4RC/O\n\tFOkmjAeQUf3DcsTS3KBkS94PHE844h465Fuuxoo2D6DSPa3W4LKF1DyExF5zwx2rJ08D\n\t+Kh1urpGbGobDEHtzNT7Y7+0kNTzMt2p1OpATqIAh3HRXmL5h9L0zVw/V6SGAb3tRoC4\n\tMQZCA6YnQRO8jvulKcNMYr/XHUw2Oci+RNT40cxxm0531gpm86QuuvoNisjm2bwUy4eA\n\tIUbA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=qozWQc45lNFOkAQQ3j2roNrvpdbOEe1vIG4ZElmcSFo=;\n\tb=cDe4AMLpnOkh7FA8NqVuqXl7B82+wICih+/stfXw5lf9Vx1eKQOObBICfZNwB9fshS\n\tnrZXzKE0Hw0LMtHGA7HtlJ1+Ky3nPqd5iKPHrhDZo7d1j85I91OAJgNx8I165XYgbxwa\n\tAw3NIR9zOjWo+CnKGgA1b32O+7mG3ugPGrqPjQ1iPHbDSFoyyjgHyz2vGFw8/YGkjPEn\n\tuMzc1tT8wcIiuB+HlaGzRxc2DvNSoZLqeVfcn26XjxF8/PvxwpVDVgurWBhsRFyqIzEk\n\t1sdvHktCb63H4hnuORfMjN1moScdXl6MPoIh95hcjPrFy+mPMWpogbwLR+KFcpGSmiuj\n\tyl/w==", "X-Gm-Message-State": "AHPjjUhccL1QczpvLoItm96zYytvbK6bbh9xwk0LwBUgZCMbJd9GcVU/\n\taY+FqkMH0joGFhd/Eug=", "X-Google-Smtp-Source": "ADKCNb7iuwbvUyv8d52EO8T1t2hGQ6Cvbh1S/doXDrhFMN1kySUR9LSpmLnuaele/PHiGkLaxVUvug==", "X-Received": "by 10.55.5.21 with SMTP id 21mr4056621qkf.158.1504312711074;\n\tFri, 01 Sep 2017 17:38:31 -0700 (PDT)", "From": "Florian Fainelli <f.fainelli@gmail.com>", "To": "netdev@vger.kernel.org", "Cc": "davem@davemloft.net, Florian Fainelli <f.fainelli@gmail.com>", "Subject": "[PATCH net-next] net: systemport: Correctly set TSB endian for host", "Date": "Fri, 1 Sep 2017 17:32:34 -0700", "Message-Id": "<1504312354-62020-1-git-send-email-f.fainelli@gmail.com>", "X-Mailer": "git-send-email 1.9.1", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "Similarly to how we configure the RSB (Receive Status Block) we also\nneed to set the TSB (Transmit Status Block) based on the host endian.\nThis was missing from the commit indicated below.\n\nFixes: 389a06bc534e (\"net: systemport: Set correct RSB endian bits based on host\")\nSigned-off-by: Florian Fainelli <f.fainelli@gmail.com>\n---\n drivers/net/ethernet/broadcom/bcmsysport.c | 13 +++++++++++++\n drivers/net/ethernet/broadcom/bcmsysport.h | 3 ++-\n 2 files changed, 15 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c\nindex 931751e4f369..ef13b6041ef1 100644\n--- a/drivers/net/ethernet/broadcom/bcmsysport.c\n+++ b/drivers/net/ethernet/broadcom/bcmsysport.c\n@@ -1390,6 +1390,19 @@ static int bcm_sysport_init_tx_ring(struct bcm_sysport_priv *priv,\n \ttdma_writel(priv, RING_IGNORE_STATUS, TDMA_DESC_RING_MAPPING(index));\n \ttdma_writel(priv, 0, TDMA_DESC_RING_PCP_DEI_VID(index));\n \n+\t/* Do not use tdma_control_bit() here because TSB_SWAP1 collides\n+\t * with the original definition of ACB_ALGO\n+\t */\n+\treg = tdma_readl(priv, TDMA_CONTROL);\n+\tif (priv->is_lite)\n+\t\treg &= ~BIT(TSB_SWAP1);\n+\t/* Set a correct TSB format based on host endian */\n+\tif (!IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))\n+\t\treg |= tdma_control_bit(priv, TSB_SWAP0);\n+\telse\n+\t\treg &= ~tdma_control_bit(priv, TSB_SWAP0);\n+\ttdma_writel(priv, reg, TDMA_CONTROL);\n+\n \t/* Program the number of descriptors as MAX_THRESHOLD and half of\n \t * its size for the hysteresis trigger\n \t */\ndiff --git a/drivers/net/ethernet/broadcom/bcmsysport.h b/drivers/net/ethernet/broadcom/bcmsysport.h\nindex 80b4ffff63b7..82e401df199e 100644\n--- a/drivers/net/ethernet/broadcom/bcmsysport.h\n+++ b/drivers/net/ethernet/broadcom/bcmsysport.h\n@@ -449,7 +449,8 @@ struct bcm_rsb {\n /* Uses 2 bits on SYSTEMPORT Lite and shifts everything by 1 bit, we\n * keep the SYSTEMPORT layout here and adjust with tdma_control_bit()\n */\n-#define TSB_SWAP\t\t\t2\n+#define TSB_SWAP0\t\t\t2\n+#define TSB_SWAP1\t\t\t3\n #define ACB_ALGO\t\t\t3\n #define BUF_DATA_OFFSET_SHIFT\t\t4\n #define BUF_DATA_OFFSET_MASK\t\t0x3ff\n", "prefixes": [ "net-next" ] }