Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808984/?format=api
{ "id": 808984, "url": "http://patchwork.ozlabs.org/api/patches/808984/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20170901202816.GR2323@tucnak/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170901202816.GR2323@tucnak>", "list_archive_url": null, "date": "2017-09-01T20:28:16", "name": "Add UBSAN_{PTR,BOUNDS} folding (PR sanitizer/81981, take 2)", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "90962c401f077a7559c41abd7fc15e720579ed65", "submitter": { "id": 671, "url": "http://patchwork.ozlabs.org/api/people/671/?format=api", "name": "Jakub Jelinek", "email": "jakub@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20170901202816.GR2323@tucnak/mbox/", "series": [ { "id": 1105, "url": "http://patchwork.ozlabs.org/api/series/1105/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=1105", "date": "2017-09-01T20:28:16", "name": "Add UBSAN_{PTR,BOUNDS} folding (PR sanitizer/81981, take 2)", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/1105/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808984/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808984/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-return-461330-incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "mailing list gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-461330-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"CIn7zkVj\"; dkim-atps=neutral", "sourceware.org; auth=none", "ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jakub@redhat.com" ], "Received": [ "from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkW680CWbz9s7M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 2 Sep 2017 06:28:31 +1000 (AEST)", "(qmail 129648 invoked by alias); 1 Sep 2017 20:28:25 -0000", "(qmail 129638 invoked by uid 89); 1 Sep 2017 20:28:24 -0000", "from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tFri, 01 Sep 2017 20:28:23 +0000", "from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com\n\t[10.5.11.12])\t(using TLSv1.2 with cipher AECDH-AES256-SHA\n\t(256/256 bits))\t(No client certificate requested)\tby\n\tmx1.redhat.com (Postfix) with ESMTPS id 14876C057FA1;\n\tFri, 1 Sep 2017 20:28:22 +0000 (UTC)", "from tucnak.zalov.cz (ovpn-116-33.ams2.redhat.com\n\t[10.36.116.33])\tby smtp.corp.redhat.com (Postfix) with ESMTPS\n\tid B17ED5CC17; Fri, 1 Sep 2017 20:28:21 +0000 (UTC)", "from tucnak.zalov.cz (localhost [127.0.0.1])\tby tucnak.zalov.cz\n\t(8.15.2/8.15.2) with ESMTP id v81KSJlH012683;\n\tFri, 1 Sep 2017 22:28:19 +0200", "(from jakub@localhost)\tby tucnak.zalov.cz (8.15.2/8.15.2/Submit)\n\tid v81KSGRP012682; Fri, 1 Sep 2017 22:28:16 +0200" ], "DomainKey-Signature": "a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:reply-to:references:mime-version\n\t:content-type:in-reply-to; q=dns; s=default; b=AfGagC24EOERVQfHQ\n\tljDls7PB6/p0uouNBLPG7XJHVXpmqyNtPGkE6GVXW2LumO6yzwOHlLOf9iXIHU3Y\n\tkLIgOI4g0wzATi6J6TI8cx/TxiF6jpzVHkmpFyLJe1fc2kHTdNjnyt0mtaa50rwF\n\t67rAIy4HXzjCnAJcFeKqAYBItI=", "DKIM-Signature": "v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:reply-to:references:mime-version\n\t:content-type:in-reply-to; s=default; bh=Cwq4XbbMZKRfGapZQ/p4yg7\n\t3Tao=; b=CIn7zkVjGiz3EVTBaNblOw0GqzMOQPxcZ5K03OoxxMaR6H8sm5O4kv2\n\txAe2sI69txtQ7dq4jC6uh6tZu1k/VUQwt7/QmQRNvMYtYCPY084VvV+y4Qw8Ky28\n\tR771Qf+V1RzYLSijWDAY1a169BZSyR8qcao++LbIIXs6GCCKrd8M=", "Mailing-List": "contact gcc-patches-help@gcc.gnu.org; run by ezmlm", "Precedence": "bulk", "List-Id": "<gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org>", "List-Archive": "<http://gcc.gnu.org/ml/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-help@gcc.gnu.org>", "Sender": "gcc-patches-owner@gcc.gnu.org", "X-Virus-Found": "No", "X-Spam-SWARE-Status": "No, score=-16.9 required=5.0 tests=BAYES_00, GIT_PATCH_1,\n\tGIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=", "X-HELO": "mx1.redhat.com", "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 14876C057FA1", "Date": "Fri, 1 Sep 2017 22:28:16 +0200", "From": "Jakub Jelinek <jakub@redhat.com>", "To": "Richard Biener <rguenther@suse.de>", "Cc": "gcc-patches@gcc.gnu.org", "Subject": "[PATCH] Add UBSAN_{PTR, BOUNDS} folding (PR sanitizer/81981, take 2)", "Message-ID": "<20170901202816.GR2323@tucnak>", "Reply-To": "Jakub Jelinek <jakub@redhat.com>", "References": "<20170901111654.GE2323@tucnak>\n\t<C026072F-D7E6-42FC-A44E-E4080575E585@suse.de>\n\t<20170901135328.GL2323@tucnak>\n\t<E8CEFE96-C8AA-4199-8C57-10BBD88BBBC4@suse.de>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<E8CEFE96-C8AA-4199-8C57-10BBD88BBBC4@suse.de>", "User-Agent": "Mutt/1.7.1 (2016-10-04)", "X-IsSubscribed": "yes" }, "content": "On Fri, Sep 01, 2017 at 07:10:51PM +0200, Richard Biener wrote:\n> OK, I thought we have one. Can you add a helper for it please? \n> replace_with_nop or so? I thought there's maybe replace_with_value which\n> handles null lhs by replacing with nop. (can't check, writing from phone)\n\nActually, you're right, replace_call_with_value does the right thing\nwhen called on call without lhs (all these internal fns don't have lhs),\nand NULL_TREE val ensures we'd ICE if that ever wasn't the case.\n\nBootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?\n\n2017-09-01 Jakub Jelinek <jakub@redhat.com>\n\n\tPR sanitizer/81981\n\t* gimple-fold.c (gimple_fold_call): Optimize away useless UBSAN_PTR\n\tand UBSAN_BOUNDS internal calls. Clean up IFN_UBSAN_OBJECT_SIZE\n\thandling. Use replace_call_with_value with NULL instead of\n\tgsi_replace, unlink_stmt_vdef and release_defs.\n\n\t* gcc.dg/ubsan/pr81981.c: New test.\n\n\n\n\tJakub", "diff": "--- gcc/gimple-fold.c.jj\t2017-09-01 09:26:37.054748039 +0200\n+++ gcc/gimple-fold.c\t2017-09-01 19:37:03.283795450 +0200\n@@ -3936,18 +3936,43 @@ gimple_fold_call (gimple_stmt_iterator *\n \t\t\t\t\tgimple_call_arg (stmt, 2));\n \t break;\n \tcase IFN_UBSAN_OBJECT_SIZE:\n-\t if (integer_all_onesp (gimple_call_arg (stmt, 2))\n-\t || (TREE_CODE (gimple_call_arg (stmt, 1)) == INTEGER_CST\n-\t\t && TREE_CODE (gimple_call_arg (stmt, 2)) == INTEGER_CST\n-\t\t && tree_int_cst_le (gimple_call_arg (stmt, 1),\n-\t\t\t\t gimple_call_arg (stmt, 2))))\n+\t {\n+\t tree offset = gimple_call_arg (stmt, 1);\n+\t tree objsize = gimple_call_arg (stmt, 2);\n+\t if (integer_all_onesp (objsize)\n+\t\t|| (TREE_CODE (offset) == INTEGER_CST\n+\t\t && TREE_CODE (objsize) == INTEGER_CST\n+\t\t && tree_int_cst_le (offset, objsize)))\n+\t {\n+\t\treplace_call_with_value (gsi, NULL_TREE);\n+\t\treturn true;\n+\t }\n+\t }\n+\t break;\n+\tcase IFN_UBSAN_PTR:\n+\t if (integer_zerop (gimple_call_arg (stmt, 1)))\n \t {\n-\t gsi_replace (gsi, gimple_build_nop (), false);\n-\t unlink_stmt_vdef (stmt);\n-\t release_defs (stmt);\n+\t replace_call_with_value (gsi, NULL_TREE);\n \t return true;\n \t }\n \t break;\n+\tcase IFN_UBSAN_BOUNDS:\n+\t {\n+\t tree index = gimple_call_arg (stmt, 1);\n+\t tree bound = gimple_call_arg (stmt, 2);\n+\t if (TREE_CODE (index) == INTEGER_CST\n+\t\t&& TREE_CODE (bound) == INTEGER_CST)\n+\t {\n+\t\tindex = fold_convert (TREE_TYPE (bound), index);\n+\t\tif (TREE_CODE (index) == INTEGER_CST\n+\t\t && tree_int_cst_le (index, bound))\n+\t\t {\n+\t\t replace_call_with_value (gsi, NULL_TREE);\n+\t\t return true;\n+\t\t }\n+\t }\n+\t }\n+\t break;\n \tcase IFN_GOACC_DIM_SIZE:\n \tcase IFN_GOACC_DIM_POS:\n \t result = fold_internal_goacc_dim (stmt);\n--- gcc/testsuite/gcc.dg/ubsan/pr81981.c.jj\t2017-09-01 19:35:37.555782465 +0200\n+++ gcc/testsuite/gcc.dg/ubsan/pr81981.c\t2017-09-01 19:35:37.555782465 +0200\n@@ -0,0 +1,21 @@\n+/* PR sanitizer/81981 */\n+/* { dg-do compile } */\n+/* { dg-options \"-O2 -Wmaybe-uninitialized -fsanitize=undefined -ffat-lto-objects\" } */\n+\n+int v;\n+\n+int\n+foo (int i)\n+{\n+ int t[1], u[1];\n+ int n = 0;\n+\n+ if (i)\n+ {\n+ t[n] = i;\n+ u[0] = i;\n+ }\n+\n+ v = u[0];\t\t/* { dg-warning \"may be used uninitialized in this function\" } */\n+ return t[0];\t\t/* { dg-warning \"may be used uninitialized in this function\" } */\n+}\n", "prefixes": [] }