Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/808894/?format=api
{ "id": 808894, "url": "http://patchwork.ozlabs.org/api/patches/808894/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901180340.30009-8-eblake@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20170901180340.30009-8-eblake@redhat.com>", "list_archive_url": null, "date": "2017-09-01T18:03:18", "name": "[v6,07/29] libqtest: Remove dead qtest_instances variable", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "71cadc8a9ab39a0a31c201b24322ca7ba6229946", "submitter": { "id": 6591, "url": "http://patchwork.ozlabs.org/api/people/6591/?format=api", "name": "Eric Blake", "email": "eblake@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20170901180340.30009-8-eblake@redhat.com/mbox/", "series": [ { "id": 1089, "url": "http://patchwork.ozlabs.org/api/series/1089/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=1089", "date": "2017-09-01T18:03:12", "name": "Preliminary libqtest cleanups", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/1089/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/808894/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/808894/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com", "ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com" ], "Received": [ "from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkRzW32sVz9t3k\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 2 Sep 2017 04:07:35 +1000 (AEST)", "from localhost ([::1]:53093 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dnqLt-0001cX-DW\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 14:07:33 -0400", "from eggs.gnu.org ([2001:4830:134:3::10]:55730)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <eblake@redhat.com>) id 1dnqIR-00076f-EP\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 14:04:00 -0400", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <eblake@redhat.com>) id 1dnqIO-0001YB-Bl\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 14:03:59 -0400", "from mx1.redhat.com ([209.132.183.28]:45598)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <eblake@redhat.com>) id 1dnqIO-0001Xr-5v\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 14:03:56 -0400", "from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 38ACA769E6\n\tfor <qemu-devel@nongnu.org>; Fri, 1 Sep 2017 18:03:55 +0000 (UTC)", "from red.redhat.com (ovpn-121-149.rdu2.redhat.com [10.10.121.149])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5B1C417100;\n\tFri, 1 Sep 2017 18:03:54 +0000 (UTC)" ], "DMARC-Filter": "OpenDMARC Filter v1.3.2 mx1.redhat.com 38ACA769E6", "From": "Eric Blake <eblake@redhat.com>", "To": "qemu-devel@nongnu.org", "Date": "Fri, 1 Sep 2017 13:03:18 -0500", "Message-Id": "<20170901180340.30009-8-eblake@redhat.com>", "In-Reply-To": "<20170901180340.30009-1-eblake@redhat.com>", "References": "<20170901180340.30009-1-eblake@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tFri, 01 Sep 2017 18:03:55 +0000 (UTC)", "Content-Transfer-Encoding": "quoted-printable", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "209.132.183.28", "Subject": "[Qemu-devel] [PATCH v6 07/29] libqtest: Remove dead qtest_instances\n\tvariable", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.21", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<http://lists.nongnu.org/archive/html/qemu-devel/>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "pbonzini@redhat.com, armbru@redhat.com", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "Prior to commit 063c23d9, we were tracking a list of parallel\nqtest objects, in order to safely clean up a SIGABRT handler\nonly after the last connection quits. But when we switched to\nmore of glib's infrastructure, the list became dead code that\nis never assigned to.\n\nSigned-off-by: Eric Blake <eblake@redhat.com>\nReviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\n---\n tests/libqtest.c | 6 +-----\n 1 file changed, 1 insertion(+), 5 deletions(-)", "diff": "diff --git a/tests/libqtest.c b/tests/libqtest.c\nindex b9a1f180e1..3f956f09fc 100644\n--- a/tests/libqtest.c\n+++ b/tests/libqtest.c\n@@ -42,7 +42,6 @@ struct QTestState\n };\n\n static GHookList abrt_hooks;\n-static GList *qtest_instances;\n static struct sigaction sigact_old;\n\n #define g_assert_no_errno(ret) do { \\\n@@ -240,13 +239,10 @@ QTestState *qtest_init(const char *extra_args)\n\n void qtest_quit(QTestState *s)\n {\n- qtest_instances = g_list_remove(qtest_instances, s);\n g_hook_destroy_link(&abrt_hooks, g_hook_find_data(&abrt_hooks, TRUE, s));\n\n /* Uninstall SIGABRT handler on last instance */\n- if (!qtest_instances) {\n- cleanup_sigabrt_handler();\n- }\n+ cleanup_sigabrt_handler();\n\n kill_qemu(s);\n close(s->fd);\n", "prefixes": [ "v6", "07/29" ] }